Re: [PATCH 10/14] mm/hmm: rename HMM_PFN_DEVICE_UNADDRESSABLE to HMM_PFN_DEVICE_PRIVATE
On 03/16/2018 01:35 PM, jgli...@redhat.com wrote: > From: Jérôme Glisse> > Make naming consistent accross code, DEVICE_PRIVATE is the name use > outside HMM code so use that one. > > Signed-off-by: Jérôme Glisse > Cc: Evgeny Baskakov > Cc: Ralph Campbell > Cc: Mark Hairgrove > Cc: John Hubbard > --- > include/linux/hmm.h | 4 ++-- > mm/hmm.c| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Seems entirely harmless. :) Reviewed-by: John Hubbard > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > index 6d2b6bf6da4b..78018b3e7a9f 100644 > --- a/include/linux/hmm.h > +++ b/include/linux/hmm.h > @@ -88,13 +88,13 @@ struct hmm; > * result of vm_insert_pfn() or vm_insert_page(). Therefore, it should > not > * be mirrored by a device, because the entry will never have > HMM_PFN_VALID > * set and the pfn value is undefined. > - * HMM_PFN_DEVICE_UNADDRESSABLE: unaddressable device memory (ZONE_DEVICE) > + * HMM_PFN_DEVICE_PRIVATE: unaddressable device memory (ZONE_DEVICE) > */ > #define HMM_PFN_VALID (1 << 0) > #define HMM_PFN_WRITE (1 << 1) > #define HMM_PFN_ERROR (1 << 2) > #define HMM_PFN_SPECIAL (1 << 3) > -#define HMM_PFN_DEVICE_UNADDRESSABLE (1 << 4) > +#define HMM_PFN_DEVICE_PRIVATE (1 << 4) > #define HMM_PFN_SHIFT 5 > > /* > diff --git a/mm/hmm.c b/mm/hmm.c > index 2118e42cb838..857eec622c98 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -429,7 +429,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > pfns[i] |= HMM_PFN_WRITE; > } else if (write_fault) > goto fault; > - pfns[i] |= HMM_PFN_DEVICE_UNADDRESSABLE; > + pfns[i] |= HMM_PFN_DEVICE_PRIVATE; > } else if (is_migration_entry(entry)) { > if (hmm_vma_walk->fault) { > pte_unmap(ptep); > thanks, -- John Hubbard NVIDIA
Re: [PATCH 10/14] mm/hmm: rename HMM_PFN_DEVICE_UNADDRESSABLE to HMM_PFN_DEVICE_PRIVATE
On 03/16/2018 01:35 PM, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Make naming consistent accross code, DEVICE_PRIVATE is the name use > outside HMM code so use that one. > > Signed-off-by: Jérôme Glisse > Cc: Evgeny Baskakov > Cc: Ralph Campbell > Cc: Mark Hairgrove > Cc: John Hubbard > --- > include/linux/hmm.h | 4 ++-- > mm/hmm.c| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Seems entirely harmless. :) Reviewed-by: John Hubbard > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > index 6d2b6bf6da4b..78018b3e7a9f 100644 > --- a/include/linux/hmm.h > +++ b/include/linux/hmm.h > @@ -88,13 +88,13 @@ struct hmm; > * result of vm_insert_pfn() or vm_insert_page(). Therefore, it should > not > * be mirrored by a device, because the entry will never have > HMM_PFN_VALID > * set and the pfn value is undefined. > - * HMM_PFN_DEVICE_UNADDRESSABLE: unaddressable device memory (ZONE_DEVICE) > + * HMM_PFN_DEVICE_PRIVATE: unaddressable device memory (ZONE_DEVICE) > */ > #define HMM_PFN_VALID (1 << 0) > #define HMM_PFN_WRITE (1 << 1) > #define HMM_PFN_ERROR (1 << 2) > #define HMM_PFN_SPECIAL (1 << 3) > -#define HMM_PFN_DEVICE_UNADDRESSABLE (1 << 4) > +#define HMM_PFN_DEVICE_PRIVATE (1 << 4) > #define HMM_PFN_SHIFT 5 > > /* > diff --git a/mm/hmm.c b/mm/hmm.c > index 2118e42cb838..857eec622c98 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -429,7 +429,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > pfns[i] |= HMM_PFN_WRITE; > } else if (write_fault) > goto fault; > - pfns[i] |= HMM_PFN_DEVICE_UNADDRESSABLE; > + pfns[i] |= HMM_PFN_DEVICE_PRIVATE; > } else if (is_migration_entry(entry)) { > if (hmm_vma_walk->fault) { > pte_unmap(ptep); > thanks, -- John Hubbard NVIDIA
[PATCH 10/14] mm/hmm: rename HMM_PFN_DEVICE_UNADDRESSABLE to HMM_PFN_DEVICE_PRIVATE
From: Jérôme GlisseMake naming consistent accross code, DEVICE_PRIVATE is the name use outside HMM code so use that one. Signed-off-by: Jérôme Glisse Cc: Evgeny Baskakov Cc: Ralph Campbell Cc: Mark Hairgrove Cc: John Hubbard --- include/linux/hmm.h | 4 ++-- mm/hmm.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 6d2b6bf6da4b..78018b3e7a9f 100644 --- a/include/linux/hmm.h +++ b/include/linux/hmm.h @@ -88,13 +88,13 @@ struct hmm; * result of vm_insert_pfn() or vm_insert_page(). Therefore, it should not * be mirrored by a device, because the entry will never have HMM_PFN_VALID * set and the pfn value is undefined. - * HMM_PFN_DEVICE_UNADDRESSABLE: unaddressable device memory (ZONE_DEVICE) + * HMM_PFN_DEVICE_PRIVATE: unaddressable device memory (ZONE_DEVICE) */ #define HMM_PFN_VALID (1 << 0) #define HMM_PFN_WRITE (1 << 1) #define HMM_PFN_ERROR (1 << 2) #define HMM_PFN_SPECIAL (1 << 3) -#define HMM_PFN_DEVICE_UNADDRESSABLE (1 << 4) +#define HMM_PFN_DEVICE_PRIVATE (1 << 4) #define HMM_PFN_SHIFT 5 /* diff --git a/mm/hmm.c b/mm/hmm.c index 2118e42cb838..857eec622c98 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -429,7 +429,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, pfns[i] |= HMM_PFN_WRITE; } else if (write_fault) goto fault; - pfns[i] |= HMM_PFN_DEVICE_UNADDRESSABLE; + pfns[i] |= HMM_PFN_DEVICE_PRIVATE; } else if (is_migration_entry(entry)) { if (hmm_vma_walk->fault) { pte_unmap(ptep); -- 2.14.3
[PATCH 10/14] mm/hmm: rename HMM_PFN_DEVICE_UNADDRESSABLE to HMM_PFN_DEVICE_PRIVATE
From: Jérôme Glisse Make naming consistent accross code, DEVICE_PRIVATE is the name use outside HMM code so use that one. Signed-off-by: Jérôme Glisse Cc: Evgeny Baskakov Cc: Ralph Campbell Cc: Mark Hairgrove Cc: John Hubbard --- include/linux/hmm.h | 4 ++-- mm/hmm.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 6d2b6bf6da4b..78018b3e7a9f 100644 --- a/include/linux/hmm.h +++ b/include/linux/hmm.h @@ -88,13 +88,13 @@ struct hmm; * result of vm_insert_pfn() or vm_insert_page(). Therefore, it should not * be mirrored by a device, because the entry will never have HMM_PFN_VALID * set and the pfn value is undefined. - * HMM_PFN_DEVICE_UNADDRESSABLE: unaddressable device memory (ZONE_DEVICE) + * HMM_PFN_DEVICE_PRIVATE: unaddressable device memory (ZONE_DEVICE) */ #define HMM_PFN_VALID (1 << 0) #define HMM_PFN_WRITE (1 << 1) #define HMM_PFN_ERROR (1 << 2) #define HMM_PFN_SPECIAL (1 << 3) -#define HMM_PFN_DEVICE_UNADDRESSABLE (1 << 4) +#define HMM_PFN_DEVICE_PRIVATE (1 << 4) #define HMM_PFN_SHIFT 5 /* diff --git a/mm/hmm.c b/mm/hmm.c index 2118e42cb838..857eec622c98 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -429,7 +429,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, pfns[i] |= HMM_PFN_WRITE; } else if (write_fault) goto fault; - pfns[i] |= HMM_PFN_DEVICE_UNADDRESSABLE; + pfns[i] |= HMM_PFN_DEVICE_PRIVATE; } else if (is_migration_entry(entry)) { if (hmm_vma_walk->fault) { pte_unmap(ptep); -- 2.14.3