Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-03-04 Thread Jiri Olsa
On Mon, Feb 25, 2019 at 05:33:35AM -0800, Andi Kleen wrote: > On Mon, Feb 25, 2019 at 01:56:15PM +0100, Jiri Olsa wrote: > > On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote: > > > > SNIP > > > > > +static void hists__res_sample(struct hist_entry *he, struct perf_sample > > > *sample)

Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-02-25 Thread Jiri Olsa
On Mon, Feb 25, 2019 at 05:31:04AM -0800, Andi Kleen wrote: > > for some reason can't see those items in menu > > These one needs --samples 10 or similar. > > It's off by default currently. I did, must be those hacks I put in to compile it, will check in new version jirka

Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-02-25 Thread Andi Kleen
On Mon, Feb 25, 2019 at 01:56:15PM +0100, Jiri Olsa wrote: > On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote: > > SNIP > > > +static void hists__res_sample(struct hist_entry *he, struct perf_sample > > *sample) > > +{ > > + struct res_sample *r; > > + int j; > > + > > + if

Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-02-25 Thread Andi Kleen
> for some reason can't see those items in menu These one needs --samples 10 or similar. It's off by default currently. -Andi

Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-02-25 Thread Jiri Olsa
On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote: SNIP > +static void hists__res_sample(struct hist_entry *he, struct perf_sample > *sample) > +{ > + struct res_sample *r; > + int j; > + > + if (!he->res_samples) { > + he->res_samples = calloc(sizeof(struct

Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-02-25 Thread Jiri Olsa
On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote: SNIP > static int > do_switch_data(struct hist_browser *browser __maybe_unused, > struct popup_action *act __maybe_unused) > @@ -3115,6 +3150,18 @@ static int perf_evsel__hists_browse(struct perf_evsel > *evsel, int

Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-02-25 Thread Jiri Olsa
On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote: SNIP > diff --git a/tools/perf/ui/browsers/res_sample.c > b/tools/perf/ui/browsers/res_sample.c > new file mode 100644 > index ..5b4807c29c2c > --- /dev/null > +++ b/tools/perf/ui/browsers/res_sample.c > @@ -0,0 +1,74 @@ >

[PATCH 11/11] perf tools report: Implement browsing of individual samples

2019-02-24 Thread Andi Kleen
From: Andi Kleen Now report can show whole time periods with perf script, but the user still has to find individual samples of interest manually. It would be expensive and complicated to search for the right samples in the whole perf file. Typically users only need to look at a small number of