Re: [PATCH 11/12] pinctrl: samsung: use __devinit section for init code

2012-10-02 Thread Thierry Reding
On Fri, Sep 28, 2012 at 11:36:16PM +0200, Arnd Bergmann wrote: > The samsung pinctrl driver has a probe function that is > __devinit and that calls a lot of other functions that are > marked __init, which kbuild complains about. > > Marking everything __devinit means that the code does not > disca

Re: [PATCH 11/12] pinctrl: samsung: use __devinit section for init code

2012-10-02 Thread Linus Walleij
On Tue, Oct 2, 2012 at 1:52 PM, Arnd Bergmann wrote: > On Monday 01 October 2012, Linus Walleij wrote: >> On Fri, Sep 28, 2012 at 11:36 PM, Arnd Bergmann wrote: >> >> > The samsung pinctrl driver has a probe function that is >> > __devinit and that calls a lot of other functions that are >> > mar

Re: [PATCH 11/12] pinctrl: samsung: use __devinit section for init code

2012-10-02 Thread Arnd Bergmann
On Monday 01 October 2012, Linus Walleij wrote: > On Fri, Sep 28, 2012 at 11:36 PM, Arnd Bergmann wrote: > > > The samsung pinctrl driver has a probe function that is > > __devinit and that calls a lot of other functions that are > > marked __init, which kbuild complains about. > > > > Marking ev

Re: [PATCH 11/12] pinctrl: samsung: use __devinit section for init code

2012-09-30 Thread Linus Walleij
On Fri, Sep 28, 2012 at 11:36 PM, Arnd Bergmann wrote: > The samsung pinctrl driver has a probe function that is > __devinit and that calls a lot of other functions that are > marked __init, which kbuild complains about. > > Marking everything __devinit means that the code does not > discarded wh

[PATCH 11/12] pinctrl: samsung: use __devinit section for init code

2012-09-28 Thread Arnd Bergmann
The samsung pinctrl driver has a probe function that is __devinit and that calls a lot of other functions that are marked __init, which kbuild complains about. Marking everything __devinit means that the code does not discarded when CONFIG_HOTPLUG is set, which is a little more wasteful, but also