Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Paolo Bonzini
On 09/01/2017 09:40, h...@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: >> On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: >>> On 28/12/2016 18:09, Roman Kagan wrote: Am I correct assuming that QEMU is currently the only user

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Paolo Bonzini
On 09/01/2017 09:40, h...@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: >> On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: >>> On 28/12/2016 18:09, Roman Kagan wrote: Am I correct assuming that QEMU is currently the only user of

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Roman Kagan
On Mon, Jan 09, 2017 at 12:40:48AM -0800, h...@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: > >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > >> On 28/12/2016 18:09, Roman Kagan wrote: > >> > Am I correct assuming that QEMU is

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Roman Kagan
On Mon, Jan 09, 2017 at 12:40:48AM -0800, h...@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: > >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > >> On 28/12/2016 18:09, Roman Kagan wrote: > >> > Am I correct assuming that QEMU is currently the only user

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread hpa
On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: >> On 28/12/2016 18:09, Roman Kagan wrote: >> > Am I correct assuming that QEMU is currently the only user of >> > arch/x86/include/uapi/asm/hyperv.h? >> >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread hpa
On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: >> On 28/12/2016 18:09, Roman Kagan wrote: >> > Am I correct assuming that QEMU is currently the only user of >> > arch/x86/include/uapi/asm/hyperv.h? >> > >> > Then I think

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Roman Kagan
On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > On 28/12/2016 18:09, Roman Kagan wrote: > > Am I correct assuming that QEMU is currently the only user of > > arch/x86/include/uapi/asm/hyperv.h? > > > > Then I think we're fine withdrawing it from uapi as a whole and letting > >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Roman Kagan
On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > On 28/12/2016 18:09, Roman Kagan wrote: > > Am I correct assuming that QEMU is currently the only user of > > arch/x86/include/uapi/asm/hyperv.h? > > > > Then I think we're fine withdrawing it from uapi as a whole and letting > >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-03 Thread Paolo Bonzini
On 02/01/2017 20:39, Stephen Hemminger wrote: >>> >>> I would like to minimize what we include in the uapi header; especially >>> when MSFT has made no guarantees >>> with regards how they may be evolved. I will also work on getting some >>> clarity on both stability and >>> under what

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-03 Thread Paolo Bonzini
On 02/01/2017 20:39, Stephen Hemminger wrote: >>> >>> I would like to minimize what we include in the uapi header; especially >>> when MSFT has made no guarantees >>> with regards how they may be evolved. I will also work on getting some >>> clarity on both stability and >>> under what

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-02 Thread Stephen Hemminger
> > <mi...@redhat.com>; H. Peter Anvin <h...@zytor.com>; > > > de...@linuxdriverproject.org; Thomas Gleixner <t...@linutronix.de> > > > Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi > > > > > > On Wed, 21 Dec 2016 09:

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-02 Thread Stephen Hemminger
t; > > x...@kernel.org; linux-kernel@vger.kernel.org; Ingo Molnar > > > ; H. Peter Anvin ; > > > de...@linuxdriverproject.org; Thomas Gleixner > > > Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi > > > > > > On Wed, 21 Dec 2016

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-02 Thread Paolo Bonzini
On 28/12/2016 18:09, Roman Kagan wrote: > Am I correct assuming that QEMU is currently the only user of > arch/x86/include/uapi/asm/hyperv.h? > > Then I think we're fine withdrawing it from uapi as a whole and letting > QEMU pull it in through its header-harvesting scripts (as does now >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-02 Thread Paolo Bonzini
On 28/12/2016 18:09, Roman Kagan wrote: > Am I correct assuming that QEMU is currently the only user of > arch/x86/include/uapi/asm/hyperv.h? > > Then I think we're fine withdrawing it from uapi as a whole and letting > QEMU pull it in through its header-harvesting scripts (as does now >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-29 Thread Stephen Hemminger
> > <mi...@redhat.com>; H. Peter Anvin <h...@zytor.com>; > > > de...@linuxdriverproject.org; Thomas Gleixner <t...@linutronix.de> > > > Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi > > > > > > On Wed, 21 Dec 2016 09:

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-29 Thread Stephen Hemminger
t; > > x...@kernel.org; linux-kernel@vger.kernel.org; Ingo Molnar > > > ; H. Peter Anvin ; > > > de...@linuxdriverproject.org; Thomas Gleixner > > > Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi > > > > > > On Wed, 21 Dec 2016

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-28 Thread Roman Kagan
gt; <d...@openvz.org>; Haiyang Zhang <haiya...@microsoft.com>; > > x...@kernel.org; linux-kernel@vger.kernel.org; Ingo Molnar > > <mi...@redhat.com>; H. Peter Anvin <h...@zytor.com>; > > de...@linuxdriverproject.org; Thomas Gleixner <t...@linutronix.de&g

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-28 Thread Roman Kagan
Roman Kagan > > ; Radim Krčmář ; KY > > Srinivasan ; Vitaly Kuznetsov > > ; k...@vger.kernel.org; Denis V . Lunev > > ; Haiyang Zhang ; > > x...@kernel.org; linux-kernel@vger.kernel.org; Ingo Molnar > > ; H. Peter Anvin ; > > de...@linuxdriverproject.org;

RE: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread KY Srinivasan
r.kernel.org; Ingo Molnar > <mi...@redhat.com>; H. Peter Anvin <h...@zytor.com>; > de...@linuxdriverproject.org; Thomas Gleixner <t...@linutronix.de> > Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi > > On Wed, 21 Dec 2016 09:58:36 -0800 > Chri

RE: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread KY Srinivasan
nel.org; Denis V . Lunev > ; Haiyang Zhang ; > x...@kernel.org; linux-kernel@vger.kernel.org; Ingo Molnar > ; H. Peter Anvin ; > de...@linuxdriverproject.org; Thomas Gleixner > Subject: Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi > > On Wed, 21 Dec 2016 09:58:36 -0

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Stephen Hemminger
On Wed, 21 Dec 2016 09:58:36 -0800 Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 09:50:49AM -0800, Stephen Hemminger wrote: > > Lastly, there is licensing issues on headers. It would be good to have any > > userspace ABI headers licensed with a more liberal license so

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Stephen Hemminger
On Wed, 21 Dec 2016 09:58:36 -0800 Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 09:50:49AM -0800, Stephen Hemminger wrote: > > Lastly, there is licensing issues on headers. It would be good to have any > > userspace ABI headers licensed with a more liberal license so that BSD and > > DPDK

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 09:50:49AM -0800, Stephen Hemminger wrote: > Lastly, there is licensing issues on headers. It would be good to have any > userspace ABI headers licensed with a more liberal license so that BSD and > DPDK drivers > could use them directly. Right now each one reinvents.

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 09:50:49AM -0800, Stephen Hemminger wrote: > Lastly, there is licensing issues on headers. It would be good to have any > userspace ABI headers licensed with a more liberal license so that BSD and > DPDK drivers > could use them directly. Right now each one reinvents.

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 18:50, Stephen Hemminger wrote: > The other problem with the hyperv headers is they were initially done with > only the Linux driver usage in mind. This made perfect sense at the time, > the problem is that they mix internal state with protocol definitions. Yes, and this was

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 18:50, Stephen Hemminger wrote: > The other problem with the hyperv headers is they were initially done with > only the Linux driver usage in mind. This made perfect sense at the time, > the problem is that they mix internal state with protocol definitions. Yes, and this was

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Stephen Hemminger
On Wed, 21 Dec 2016 07:43:48 -0800 Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 04:39:18PM +0100, Paolo Bonzini wrote: > > That said, there are precedents in using UAPI this way for PV > > interfaces. See for example include/uapi/linux/virtio*.h and > >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Stephen Hemminger
On Wed, 21 Dec 2016 07:43:48 -0800 Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 04:39:18PM +0100, Paolo Bonzini wrote: > > That said, there are precedents in using UAPI this way for PV > > interfaces. See for example include/uapi/linux/virtio*.h and > >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 16:43, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 04:39:18PM +0100, Paolo Bonzini wrote: >> That said, there are precedents in using UAPI this way for PV >> interfaces. See for example include/uapi/linux/virtio*.h and >> arch/x86/include/uapi/asm/kvm_para.h. > > We have

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 16:43, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 04:39:18PM +0100, Paolo Bonzini wrote: >> That said, there are precedents in using UAPI this way for PV >> interfaces. See for example include/uapi/linux/virtio*.h and >> arch/x86/include/uapi/asm/kvm_para.h. > > We have

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 04:39:18PM +0100, Paolo Bonzini wrote: > That said, there are precedents in using UAPI this way for PV > interfaces. See for example include/uapi/linux/virtio*.h and > arch/x86/include/uapi/asm/kvm_para.h. We have all kinds of historical examples, but most of them turned

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 04:39:18PM +0100, Paolo Bonzini wrote: > That said, there are precedents in using UAPI this way for PV > interfaces. See for example include/uapi/linux/virtio*.h and > arch/x86/include/uapi/asm/kvm_para.h. We have all kinds of historical examples, but most of them turned

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 15:26, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: >> That's fine by me. >> >> I guess the series should then start with a complete move >> arch/x86/include/uapi/asm/hyperv.h -> >> arch/x86/include/asm/hyperv_proto.h, and the remaining

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Paolo Bonzini
On 21/12/2016 15:26, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: >> That's fine by me. >> >> I guess the series should then start with a complete move >> arch/x86/include/uapi/asm/hyperv.h -> >> arch/x86/include/asm/hyperv_proto.h, and the remaining

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Roman Kagan
On Wed, Dec 21, 2016 at 04:18:58AM -0800, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 09:29:39AM +0300, Roman Kagan wrote: > > QEMU in particular. We're planning to implement VMBus devices in QEMU > > and would like to have the definitions shared with the Linux guest > > drivers for

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Roman Kagan
On Wed, Dec 21, 2016 at 04:18:58AM -0800, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 09:29:39AM +0300, Roman Kagan wrote: > > QEMU in particular. We're planning to implement VMBus devices in QEMU > > and would like to have the definitions shared with the Linux guest > > drivers for

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Roman Kagan
On Wed, Dec 21, 2016 at 06:26:54AM -0800, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: > > That's fine by me. > > > > I guess the series should then start with a complete move > > arch/x86/include/uapi/asm/hyperv.h -> > >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Roman Kagan
On Wed, Dec 21, 2016 at 06:26:54AM -0800, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: > > That's fine by me. > > > > I guess the series should then start with a complete move > > arch/x86/include/uapi/asm/hyperv.h -> > >

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: > That's fine by me. > > I guess the series should then start with a complete move > arch/x86/include/uapi/asm/hyperv.h -> > arch/x86/include/asm/hyperv_proto.h, and the remaining patches have to > change the latter instead of the

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: > That's fine by me. > > I guess the series should then start with a complete move > arch/x86/include/uapi/asm/hyperv.h -> > arch/x86/include/asm/hyperv_proto.h, and the remaining patches have to > change the latter instead of the

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 09:29:39AM +0300, Roman Kagan wrote: > QEMU in particular. We're planning to implement VMBus devices in QEMU > and would like to have the definitions shared with the Linux guest > drivers for Hyper-V. And that's everything but a userspace API. The way to go for protocol

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 09:29:39AM +0300, Roman Kagan wrote: > QEMU in particular. We're planning to implement VMBus devices in QEMU > and would like to have the definitions shared with the Linux guest > drivers for Hyper-V. And that's everything but a userspace API. The way to go for protocol

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-20 Thread Roman Kagan
On Tue, Dec 20, 2016 at 09:25:43AM -0800, Stephen Hemminger wrote: > On Tue, 20 Dec 2016 18:55:59 +0300 > Roman Kagan wrote: > > > Userspace will need them too. > > > > Signed-off-by: Roman Kagan > > What userspace? I am worried about creating more

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-20 Thread Roman Kagan
On Tue, Dec 20, 2016 at 09:25:43AM -0800, Stephen Hemminger wrote: > On Tue, 20 Dec 2016 18:55:59 +0300 > Roman Kagan wrote: > > > Userspace will need them too. > > > > Signed-off-by: Roman Kagan > > What userspace? I am worried about creating more stable API's that can't > change. QEMU in

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 18:55:59 +0300 Roman Kagan wrote: > Userspace will need them too. > > Signed-off-by: Roman Kagan What userspace? I am worried about creating more stable API's that can't change.

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2016 18:55:59 +0300 Roman Kagan wrote: > Userspace will need them too. > > Signed-off-by: Roman Kagan What userspace? I am worried about creating more stable API's that can't change.

[PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-20 Thread Roman Kagan
Userspace will need them too. Signed-off-by: Roman Kagan --- arch/x86/include/uapi/asm/hyperv.h | 9 + drivers/hv/hyperv_vmbus.h | 10 -- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/uapi/asm/hyperv.h

[PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-20 Thread Roman Kagan
Userspace will need them too. Signed-off-by: Roman Kagan --- arch/x86/include/uapi/asm/hyperv.h | 9 + drivers/hv/hyperv_vmbus.h | 10 -- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/uapi/asm/hyperv.h