Re: [PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-10-01 Thread Shuah Khan
On Mon, Oct 1, 2012 at 2:05 AM, Joerg Roedel wrote: > On Fri, Sep 28, 2012 at 05:18:18PM -0600, Shuah Khan wrote: >> > +void amd_iommu_disable(void) >> > +{ >> > + amd_iommu_suspend(); >> >> Is it safe to attempt to suspend when iommu is in suspend state? In >> other words what happens if

Re: [PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-10-01 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 05:18:18PM -0600, Shuah Khan wrote: > > +void amd_iommu_disable(void) > > +{ > > + amd_iommu_suspend(); > > Is it safe to attempt to suspend when iommu is in suspend state? In > other words what happens if amd_iommu_disable() gets called when iommu > is already in

Re: [PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-10-01 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 05:18:18PM -0600, Shuah Khan wrote: +void amd_iommu_disable(void) +{ + amd_iommu_suspend(); Is it safe to attempt to suspend when iommu is in suspend state? In other words what happens if amd_iommu_disable() gets called when iommu is already in suspend

Re: [PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-10-01 Thread Shuah Khan
On Mon, Oct 1, 2012 at 2:05 AM, Joerg Roedel joerg.roe...@amd.com wrote: On Fri, Sep 28, 2012 at 05:18:18PM -0600, Shuah Khan wrote: +void amd_iommu_disable(void) +{ + amd_iommu_suspend(); Is it safe to attempt to suspend when iommu is in suspend state? In other words what happens

Re: [PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-09-28 Thread Shuah Khan
Joerg, On Fri, Sep 28, 2012 at 6:24 AM, Joerg Roedel wrote: > Add the six routines required to setup interrupt remapping > with the AMD IOMMU. Also put it all together into the AMD > specific irq_remap_ops. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/amd_iommu.c | 16

[PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-09-28 Thread Joerg Roedel
Add the six routines required to setup interrupt remapping with the AMD IOMMU. Also put it all together into the AMD specific irq_remap_ops. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c | 16 +++ drivers/iommu/amd_iommu_init.c | 42

[PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-09-28 Thread Joerg Roedel
Add the six routines required to setup interrupt remapping with the AMD IOMMU. Also put it all together into the AMD specific irq_remap_ops. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- drivers/iommu/amd_iommu.c | 16 +++ drivers/iommu/amd_iommu_init.c | 42

Re: [PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping

2012-09-28 Thread Shuah Khan
Joerg, On Fri, Sep 28, 2012 at 6:24 AM, Joerg Roedel joerg.roe...@amd.com wrote: Add the six routines required to setup interrupt remapping with the AMD IOMMU. Also put it all together into the AMD specific irq_remap_ops. Signed-off-by: Joerg Roedel joerg.roe...@amd.com ---