Re: [PATCH 12/27] tty: hvc: convert to u8 and size_t

2023-12-06 Thread Christophe Leroy


Le 06/12/2023 à 08:36, Jiri Slaby (SUSE) a écrit :
> Switch character types to u8 and sizes to size_t. To conform to
> characters/sizes in the rest of the tty layer.
> 
> Signed-off-by: Jiri Slaby (SUSE) 
> Cc: Michael Ellerman 
> Cc: Nicholas Piggin 
> Cc: Christophe Leroy 
> Cc: Amit Shah 
> Cc: Arnd Bergmann 
> Cc: Paul Walmsley 
> Cc: Palmer Dabbelt 
> Cc: Albert Ou 
> Cc: linuxppc-...@lists.ozlabs.org
> Cc: virtualizat...@lists.linux.dev
> Cc: linux-ri...@lists.infradead.org
> ---
>   arch/powerpc/include/asm/hvconsole.h   |  4 ++--
>   arch/powerpc/include/asm/hvsi.h| 18 
>   arch/powerpc/include/asm/opal.h|  8 +---
>   arch/powerpc/platforms/powernv/opal.c  | 14 +++--
>   arch/powerpc/platforms/pseries/hvconsole.c |  4 ++--
>   drivers/char/virtio_console.c  | 10 -
>   drivers/tty/hvc/hvc_console.h  |  4 ++--
>   drivers/tty/hvc/hvc_dcc.c  | 24 +++---
>   drivers/tty/hvc/hvc_iucv.c | 18 
>   drivers/tty/hvc/hvc_opal.c |  5 +++--
>   drivers/tty/hvc/hvc_riscv_sbi.c|  9 
>   drivers/tty/hvc/hvc_rtas.c | 11 +-
>   drivers/tty/hvc/hvc_udbg.c |  9 
>   drivers/tty/hvc/hvc_vio.c  | 18 
>   drivers/tty/hvc/hvc_xen.c  | 23 +++--
>   drivers/tty/hvc/hvsi_lib.c | 20 ++
>   16 files changed, 107 insertions(+), 92 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/hvconsole.h 
> b/arch/powerpc/include/asm/hvconsole.h
> index ccb2034506f0..d841a97010a0 100644
> --- a/arch/powerpc/include/asm/hvconsole.h
> +++ b/arch/powerpc/include/asm/hvconsole.h
> @@ -21,8 +21,8 @@
>* Vio firmware always attempts to fetch MAX_VIO_GET_CHARS chars.  The 
> 'count'
>* parm is included to conform to put_chars() function pointer template
>*/
> -extern int hvc_get_chars(uint32_t vtermno, char *buf, int count);
> -extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count);
> +extern ssize_t hvc_get_chars(uint32_t vtermno, u8 *buf, size_t count);
> +extern ssize_t hvc_put_chars(uint32_t vtermno, const u8 *buf, size_t count);

Would be a good opportunity to drop this pointless deprecated 'extern' 
keyword on all function prototypes you are changing.

Christophe


[PATCH 12/27] tty: hvc: convert to u8 and size_t

2023-12-05 Thread Jiri Slaby (SUSE)
Switch character types to u8 and sizes to size_t. To conform to
characters/sizes in the rest of the tty layer.

Signed-off-by: Jiri Slaby (SUSE) 
Cc: Michael Ellerman 
Cc: Nicholas Piggin 
Cc: Christophe Leroy 
Cc: Amit Shah 
Cc: Arnd Bergmann 
Cc: Paul Walmsley 
Cc: Palmer Dabbelt 
Cc: Albert Ou 
Cc: linuxppc-...@lists.ozlabs.org
Cc: virtualizat...@lists.linux.dev
Cc: linux-ri...@lists.infradead.org
---
 arch/powerpc/include/asm/hvconsole.h   |  4 ++--
 arch/powerpc/include/asm/hvsi.h| 18 
 arch/powerpc/include/asm/opal.h|  8 +---
 arch/powerpc/platforms/powernv/opal.c  | 14 +++--
 arch/powerpc/platforms/pseries/hvconsole.c |  4 ++--
 drivers/char/virtio_console.c  | 10 -
 drivers/tty/hvc/hvc_console.h  |  4 ++--
 drivers/tty/hvc/hvc_dcc.c  | 24 +++---
 drivers/tty/hvc/hvc_iucv.c | 18 
 drivers/tty/hvc/hvc_opal.c |  5 +++--
 drivers/tty/hvc/hvc_riscv_sbi.c|  9 
 drivers/tty/hvc/hvc_rtas.c | 11 +-
 drivers/tty/hvc/hvc_udbg.c |  9 
 drivers/tty/hvc/hvc_vio.c  | 18 
 drivers/tty/hvc/hvc_xen.c  | 23 +++--
 drivers/tty/hvc/hvsi_lib.c | 20 ++
 16 files changed, 107 insertions(+), 92 deletions(-)

diff --git a/arch/powerpc/include/asm/hvconsole.h 
b/arch/powerpc/include/asm/hvconsole.h
index ccb2034506f0..d841a97010a0 100644
--- a/arch/powerpc/include/asm/hvconsole.h
+++ b/arch/powerpc/include/asm/hvconsole.h
@@ -21,8 +21,8 @@
  * Vio firmware always attempts to fetch MAX_VIO_GET_CHARS chars.  The 'count'
  * parm is included to conform to put_chars() function pointer template
  */
-extern int hvc_get_chars(uint32_t vtermno, char *buf, int count);
-extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count);
+extern ssize_t hvc_get_chars(uint32_t vtermno, u8 *buf, size_t count);
+extern ssize_t hvc_put_chars(uint32_t vtermno, const u8 *buf, size_t count);
 
 /* Provided by HVC VIO */
 void hvc_vio_init_early(void);
diff --git a/arch/powerpc/include/asm/hvsi.h b/arch/powerpc/include/asm/hvsi.h
index 464a7519ed64..9058edcb632b 100644
--- a/arch/powerpc/include/asm/hvsi.h
+++ b/arch/powerpc/include/asm/hvsi.h
@@ -64,7 +64,7 @@ struct hvsi_priv {
unsigned intinbuf_len;  /* data in input buffer */
unsigned char   inbuf[HVSI_INBUF_SIZE];
unsigned intinbuf_cur;  /* Cursor in input buffer */
-   unsigned intinbuf_pktlen;   /* packet length from cursor */
+   size_t  inbuf_pktlen;   /* packet length from cursor */
atomic_tseqno;  /* packet sequence number */
unsigned intopened:1;   /* driver opened */
unsigned intestablished:1;  /* protocol established */
@@ -72,24 +72,26 @@ struct hvsi_priv {
unsigned intmctrl_update:1; /* modem control updated */
unsigned short  mctrl;  /* modem control */
struct tty_struct *tty; /* tty structure */
-   int (*get_chars)(uint32_t termno, char *buf, int count);
-   int (*put_chars)(uint32_t termno, const char *buf, int count);
+   ssize_t (*get_chars)(uint32_t termno, u8 *buf, size_t count);
+   ssize_t (*put_chars)(uint32_t termno, const u8 *buf, size_t count);
uint32_ttermno;
 };
 
 /* hvsi lib functions */
 struct hvc_struct;
 extern void hvsilib_init(struct hvsi_priv *pv,
-int (*get_chars)(uint32_t termno, char *buf, int 
count),
-int (*put_chars)(uint32_t termno, const char *buf,
- int count),
+ssize_t (*get_chars)(uint32_t termno, u8 *buf,
+ size_t count),
+ssize_t (*put_chars)(uint32_t termno, const u8 *buf,
+ size_t count),
 int termno, int is_console);
 extern int hvsilib_open(struct hvsi_priv *pv, struct hvc_struct *hp);
 extern void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp);
 extern int hvsilib_read_mctrl(struct hvsi_priv *pv);
 extern int hvsilib_write_mctrl(struct hvsi_priv *pv, int dtr);
 extern void hvsilib_establish(struct hvsi_priv *pv);
-extern int hvsilib_get_chars(struct hvsi_priv *pv, char *buf, int count);
-extern int hvsilib_put_chars(struct hvsi_priv *pv, const char *buf, int count);
+extern ssize_t hvsilib_get_chars(struct hvsi_priv *pv, u8 *buf, size_t count);
+extern ssize_t hvsilib_put_chars(struct hvsi_priv *pv, const u8 *buf,
+size_t count);
 
 #endif /* _HVSI_H */
diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm/opal.h
index b66b0c615f4f..af304e6cb486 100644
--- a/arch/powerpc/include/asm/opal.h
+++