Re: [PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-30 Thread Peter Zijlstra
On Fri, Oct 26, 2018 at 03:17:07AM -0700, Matthew Wilcox wrote: > On Fri, Oct 26, 2018 at 11:32:05AM +0200, Peter Zijlstra wrote: > > On Wed, Oct 24, 2018 at 12:35:00AM +0300, Igor Stoppa wrote: > > > Some of the data structures used in list management are composed by two > > > pointers. Since the

Re: [PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-29 Thread Igor Stoppa
On 24/10/2018 14:43, Alexey Dobriyan wrote: On Wed, Oct 24, 2018 at 12:35:00AM +0300, Igor Stoppa wrote: Some of the data structures used in list management are composed by two pointers. Since the kernel is now configured by default to randomize the layout of data structures soleley composed

Re: [PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-26 Thread Matthew Wilcox
On Fri, Oct 26, 2018 at 11:32:05AM +0200, Peter Zijlstra wrote: > On Wed, Oct 24, 2018 at 12:35:00AM +0300, Igor Stoppa wrote: > > Some of the data structures used in list management are composed by two > > pointers. Since the kernel is now configured by default to randomize the > > layout of data

Re: [PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-26 Thread Peter Zijlstra
On Wed, Oct 24, 2018 at 12:35:00AM +0300, Igor Stoppa wrote: > Some of the data structures used in list management are composed by two > pointers. Since the kernel is now configured by default to randomize the > layout of data structures soleley composed by pointers, this might > prevent correct ty

Re: [PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-24 Thread Alexey Dobriyan
On Wed, Oct 24, 2018 at 12:35:00AM +0300, Igor Stoppa wrote: > Some of the data structures used in list management are composed by two > pointers. Since the kernel is now configured by default to randomize the > layout of data structures soleley composed by pointers, Isn't this true for function p

[PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-23 Thread Igor Stoppa
Some of the data structures used in list management are composed by two pointers. Since the kernel is now configured by default to randomize the layout of data structures soleley composed by pointers, this might prevent correct type punning between these structures and their write rare counterpart.