Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Mark Brown
On Mon, Jul 30, 2012 at 03:26:58PM +0100, Lee Jones wrote: > On 30/07/12 14:40, Mark Brown wrote: > >>We use it register the driver for probe()ing. In the same way we do > >>for the PMU and Regulators. All three of which actually belong to a > >>different hardware block. Do you know of a better

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Lee Jones
On 30/07/12 14:40, Mark Brown wrote: On Mon, Jul 30, 2012 at 08:32:43AM +0100, Lee Jones wrote: On 29/07/12 21:50, Mark Brown wrote: On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: + pcm: ux500-pcm { + compatible = "stericsson,ux500-pcm"; +

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Mark Brown
On Mon, Jul 30, 2012 at 08:32:43AM +0100, Lee Jones wrote: > On 29/07/12 21:50, Mark Brown wrote: > >On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: > >>+ pcm: ux500-pcm { > >>+ compatible = "stericsson,ux500-pcm"; > >>+ }; > >>+ > >One of two

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Lee Jones
On 29/07/12 21:50, Mark Brown wrote: On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: Nothing special here. We're only providing a compatible string to ensure the driver is probed using a Device Tree boot. + pcm: ux500-pcm { + compatible =

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Lee Jones
On 29/07/12 21:50, Mark Brown wrote: On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: Nothing special here. We're only providing a compatible string to ensure the driver is probed using a Device Tree boot. + pcm: ux500-pcm { + compatible =

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Mark Brown
On Mon, Jul 30, 2012 at 08:32:43AM +0100, Lee Jones wrote: On 29/07/12 21:50, Mark Brown wrote: On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: + pcm: ux500-pcm { + compatible = stericsson,ux500-pcm; + }; + One of two things is wrong here.

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Lee Jones
On 30/07/12 14:40, Mark Brown wrote: On Mon, Jul 30, 2012 at 08:32:43AM +0100, Lee Jones wrote: On 29/07/12 21:50, Mark Brown wrote: On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: + pcm: ux500-pcm { + compatible = stericsson,ux500-pcm; +

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-30 Thread Mark Brown
On Mon, Jul 30, 2012 at 03:26:58PM +0100, Lee Jones wrote: On 30/07/12 14:40, Mark Brown wrote: We use it register the driver for probe()ing. In the same way we do for the PMU and Regulators. All three of which actually belong to a different hardware block. Do you know of a better way to

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-29 Thread Mark Brown
On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: > Nothing special here. We're only providing a compatible string > to ensure the driver is probed using a Device Tree boot. > + pcm: ux500-pcm { > + compatible = "stericsson,ux500-pcm"; > + }; >

Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-29 Thread Mark Brown
On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: Nothing special here. We're only providing a compatible string to ensure the driver is probed using a Device Tree boot. + pcm: ux500-pcm { + compatible = stericsson,ux500-pcm; + }; + One

[PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-27 Thread Lee Jones
Nothing special here. We're only providing a compatible string to ensure the driver is probed using a Device Tree boot. Signed-off-by: Lee Jones --- arch/arm/boot/dts/db8500.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/db8500.dtsi

[PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

2012-07-27 Thread Lee Jones
Nothing special here. We're only providing a compatible string to ensure the driver is probed using a Device Tree boot. Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/db8500.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/db8500.dtsi