Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-24 Thread Javier Martinez Canillas
Hello Rob and Jonathan, On 08/24/2015 12:10 AM, Rob Herring wrote: > On Sat, Aug 22, 2015 at 12:48 PM, Jonathan Cameron wrote: >> On 20/08/15 23:48, Javier Martinez Canillas wrote: >>> Hello Michael, >>> >>> On 08/21/2015 12:29 AM, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:02:40AM

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-24 Thread Javier Martinez Canillas
Hello Rob and Jonathan, On 08/24/2015 12:10 AM, Rob Herring wrote: On Sat, Aug 22, 2015 at 12:48 PM, Jonathan Cameron ji...@kernel.org wrote: On 20/08/15 23:48, Javier Martinez Canillas wrote: Hello Michael, On 08/21/2015 12:29 AM, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:02:40AM

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-23 Thread Rob Herring
On Sat, Aug 22, 2015 at 12:48 PM, Jonathan Cameron wrote: > On 20/08/15 23:48, Javier Martinez Canillas wrote: >> Hello Michael, >> >> On 08/21/2015 12:29 AM, Michael Welling wrote: >>> On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael, On

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-23 Thread Rob Herring
On Sat, Aug 22, 2015 at 12:48 PM, Jonathan Cameron ji...@kernel.org wrote: On 20/08/15 23:48, Javier Martinez Canillas wrote: Hello Michael, On 08/21/2015 12:29 AM, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/20/2015

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-22 Thread Jonathan Cameron
On 21/08/15 00:53, Michael Welling wrote: > On Fri, Aug 21, 2015 at 12:48:23AM +0200, Javier Martinez Canillas wrote: >> Hello Michael, >> >> On 08/21/2015 12:29 AM, Michael Welling wrote: >>> On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael,

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-22 Thread Jonathan Cameron
On 20/08/15 23:48, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/21/2015 12:29 AM, Michael Welling wrote: >> On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: >>> Hello Michael, >>> >>> On 08/20/2015 10:09 PM, Michael Welling wrote: On Thu, Aug 20, 2015

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-22 Thread Jonathan Cameron
On 20/08/15 23:48, Javier Martinez Canillas wrote: Hello Michael, On 08/21/2015 12:29 AM, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/20/2015 10:09 PM, Michael Welling wrote: On Thu, Aug 20, 2015 at 09:07:26AM

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-22 Thread Jonathan Cameron
On 21/08/15 00:53, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:48:23AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/21/2015 12:29 AM, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/20/2015 10:09 PM,

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Fri, Aug 21, 2015 at 12:48:23AM +0200, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/21/2015 12:29 AM, Michael Welling wrote: > > On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: > >> Hello Michael, > >> > >> On 08/20/2015 10:09 PM, Michael Welling wrote:

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Javier Martinez Canillas
Hello Michael, On 08/21/2015 12:29 AM, Michael Welling wrote: > On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: >> Hello Michael, >> >> On 08/20/2015 10:09 PM, Michael Welling wrote: >>> On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: The

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/20/2015 10:09 PM, Michael Welling wrote: > > On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: > >> The driver has an OF id table but the .of_match_table is not set so > >>

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Javier Martinez Canillas
Hello Michael, On 08/20/2015 10:09 PM, Michael Welling wrote: > On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: >> The driver has an OF id table but the .of_match_table is not set so >> the SPI core can't do an OF style match and the table was unused. >> > > Is an OF

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: > The driver has an OF id table but the .of_match_table is not set so > the SPI core can't do an OF style match and the table was unused. > Is an OF style match necessary? I have been using devicetree and it matches based

[PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Javier Martinez Canillas
The driver has an OF id table but the .of_match_table is not set so the SPI core can't do an OF style match and the table was unused. Signed-off-by: Javier Martinez Canillas --- drivers/iio/adc/mcp320x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/adc/mcp320x.c

[PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Javier Martinez Canillas
The driver has an OF id table but the .of_match_table is not set so the SPI core can't do an OF style match and the table was unused. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com --- drivers/iio/adc/mcp320x.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Fri, Aug 21, 2015 at 12:48:23AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/21/2015 12:29 AM, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/20/2015 10:09 PM, Michael Welling wrote: On Thu, Aug

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Javier Martinez Canillas
Hello Michael, On 08/21/2015 12:29 AM, Michael Welling wrote: On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/20/2015 10:09 PM, Michael Welling wrote: On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: The driver has an

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: The driver has an OF id table but the .of_match_table is not set so the SPI core can't do an OF style match and the table was unused. Is an OF style match necessary? I have been using devicetree and it matches based on

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Javier Martinez Canillas
Hello Michael, On 08/20/2015 10:09 PM, Michael Welling wrote: On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: The driver has an OF id table but the .of_match_table is not set so the SPI core can't do an OF style match and the table was unused. Is an OF style match

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: Hello Michael, On 08/20/2015 10:09 PM, Michael Welling wrote: On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: The driver has an OF id table but the .of_match_table is not set so the SPI