Re: [PATCH 13/18] tracing: Add array type to function based events

2018-02-08 Thread Steven Rostedt
On Fri, 9 Feb 2018 10:17:45 +0900 Namhyung Kim wrote: > > + # echo 1 > events/functions/ip_rcv/enable > > + # cat trace > > +-0 [003] ..s3 219.813582: > > __netif_receive_skb_core->ip_rcv(skb=880118195e00, > > perm_addr=b4,b5,2f,ce,18,65) > > +-0 [003] ..s3 219.813595:

Re: [PATCH 13/18] tracing: Add array type to function based events

2018-02-08 Thread Namhyung Kim
On Fri, Feb 02, 2018 at 06:05:11PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add syntex to allow the user to create an array type. Brackets after the > type field will denote that this is an array type. For example: > > # echo 'SyS_open(x8[32] buf, x32 flags, x32 mode)'

Re: [PATCH 13/18] tracing: Add array type to function based events

2018-02-03 Thread Masami Hiramatsu
On Sat, 3 Feb 2018 10:29:03 -0500 Steven Rostedt wrote: > On Sat, 3 Feb 2018 22:56:15 +0900 > Masami Hiramatsu wrote: > > > This idea looks good for kprobe events too. > > I'll try to implement same one :) > > We should have the two re-use the same code. > > In other words, I would like as mu

Re: [PATCH 13/18] tracing: Add array type to function based events

2018-02-03 Thread Steven Rostedt
On Sat, 3 Feb 2018 22:56:15 +0900 Masami Hiramatsu wrote: > This idea looks good for kprobe events too. > I'll try to implement same one :) We should have the two re-use the same code. In other words, I would like as much code sharing as possible. -- Steve

Re: [PATCH 13/18] tracing: Add array type to function based events

2018-02-03 Thread Masami Hiramatsu
On Fri, 02 Feb 2018 18:05:11 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add syntex to allow the user to create an array type. Brackets after the > type field will denote that this is an array type. For example: > > # echo 'SyS_open(x8[32] buf, x32 flags, x32 mode)' > fu

[PATCH 13/18] tracing: Add array type to function based events

2018-02-02 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Add syntex to allow the user to create an array type. Brackets after the type field will denote that this is an array type. For example: # echo 'SyS_open(x8[32] buf, x32 flags, x32 mode)' > function_events Will make the first argument of the sys_open function ca