Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

> Am 10.05.2018 um 18:42 schrieb Mauro Carvalho Chehab > : > > Em Thu, 10 May 2018 09:38:46 -0600 > Jonathan Corbet escreveu: > >> On Thu, 10 May 2018 11:21:13 -0300 >> Mauro Carvalho Chehab wrote: >> >>> The problem

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

> Am 10.05.2018 um 18:42 schrieb Mauro Carvalho Chehab > : > > Em Thu, 10 May 2018 09:38:46 -0600 > Jonathan Corbet escreveu: > >> On Thu, 10 May 2018 11:21:13 -0300 >> Mauro Carvalho Chehab wrote: >> >>> The problem with a hint-based mechanism is that it will generate >>> false hints. If

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 18:52:20 +0200 Andrea Parri escreveu: > On Thu, May 10, 2018 at 07:15:59AM -0600, Jonathan Corbet wrote: > > On Thu, 10 May 2018 14:23:35 +0200 > > Andrea Parri wrote: > > > > > only > > > remember that

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 18:52:20 +0200 Andrea Parri escreveu: > On Thu, May 10, 2018 at 07:15:59AM -0600, Jonathan Corbet wrote: > > On Thu, 10 May 2018 14:23:35 +0200 > > Andrea Parri wrote: > > > > > only > > > remember that other people (including some developers running into the > > >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 13:42:58 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 10 May 2018 09:38:46 -0600 > Jonathan Corbet escreveu: > > > On Thu, 10 May 2018 11:21:13 -0300 > > Mauro Carvalho Chehab wrote: > > > > > The

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 13:42:58 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 10 May 2018 09:38:46 -0600 > Jonathan Corbet escreveu: > > > On Thu, 10 May 2018 11:21:13 -0300 > > Mauro Carvalho Chehab wrote: > > > > > The problem with a hint-based mechanism is that it will generate > > > false

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, May 10, 2018 at 07:15:59AM -0600, Jonathan Corbet wrote: > On Thu, 10 May 2018 14:23:35 +0200 > Andrea Parri wrote: > > > only > > remember that other people (including some developers running into the > > "disadventure" of opening an RST doc. from

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, May 10, 2018 at 07:15:59AM -0600, Jonathan Corbet wrote: > On Thu, 10 May 2018 14:23:35 +0200 > Andrea Parri wrote: > > > only > > remember that other people (including some developers running into the > > "disadventure" of opening an RST doc. from their preferred text editor > > and

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 09:38:46 -0600 Jonathan Corbet escreveu: > On Thu, 10 May 2018 11:21:13 -0300 > Mauro Carvalho Chehab wrote: > > > The problem with a hint-based mechanism is that it will generate > > false hints. If added, we may end by needing

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 09:38:46 -0600 Jonathan Corbet escreveu: > On Thu, 10 May 2018 11:21:13 -0300 > Mauro Carvalho Chehab wrote: > > > The problem with a hint-based mechanism is that it will generate > > false hints. If added, we may end by needing to add extra tags to > > disable the hints

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 11:21:13 -0300 Mauro Carvalho Chehab wrote: > The problem with a hint-based mechanism is that it will generate > false hints. If added, we may end by needing to add extra tags to > disable the hints mechanism where it gets wrong, or to periodically

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 11:21:13 -0300 Mauro Carvalho Chehab wrote: > The problem with a hint-based mechanism is that it will generate > false hints. If added, we may end by needing to add extra tags to > disable the hints mechanism where it gets wrong, or to periodically > do code changes at

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 07:30:12 -0600 Jonathan Corbet escreveu: > On Thu, 10 May 2018 06:38:05 -0300 > Mauro Carvalho Chehab wrote: > > > (Peter said): > > > Independent of any philosophical discussion not allowing a setence to > > > end with a single

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 07:30:12 -0600 Jonathan Corbet escreveu: > On Thu, 10 May 2018 06:38:05 -0300 > Mauro Carvalho Chehab wrote: > > > (Peter said): > > > Independent of any philosophical discussion not allowing a setence to > > > end with a single ':' is completely idiotic. Please fix the

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 07:30:12 -0600 Jonathan Corbet wrote: > > (Peter said): > > > Independent of any philosophical discussion not allowing a setence to > > > end with a single ':' is completely idiotic. Please fix the tooling > > > instead to allow it, as it is very important

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 07:30:12 -0600 Jonathan Corbet wrote: > > (Peter said): > > > Independent of any philosophical discussion not allowing a setence to > > > end with a single ':' is completely idiotic. Please fix the tooling > > > instead to allow it, as it is very important for being able

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 06:38:05 -0300 Mauro Carvalho Chehab wrote: > (Peter said): > > Independent of any philosophical discussion not allowing a setence to > > end with a single ':' is completely idiotic. Please fix the tooling > > instead to allow it, as it is very

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 06:38:05 -0300 Mauro Carvalho Chehab wrote: > (Peter said): > > Independent of any philosophical discussion not allowing a setence to > > end with a single ':' is completely idiotic. Please fix the tooling > > instead to allow it, as it is very important for being able to

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 14:23:35 +0200 Andrea Parri wrote: > only > remember that other people (including some developers running into the > "disadventure" of opening an RST doc. from their preferred text editor > and being brought to conclude: "WTH! I need to

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, 10 May 2018 14:23:35 +0200 Andrea Parri wrote: > only > remember that other people (including some developers running into the > "disadventure" of opening an RST doc. from their preferred text editor > and being brought to conclude: "WTH! I need to open a web browser, I > guess...")

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 14:20:36 +0200 Peter Zijlstra escreveu: > On Thu, May 10, 2018 at 06:38:05AM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 10 May 2018 01:38:38 -0700 > > Christoph Hellwig escreveu: > > > > > > * Use either while holding

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 14:20:36 +0200 Peter Zijlstra escreveu: > On Thu, May 10, 2018 at 06:38:05AM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 10 May 2018 01:38:38 -0700 > > Christoph Hellwig escreveu: > > > > > > * Use either while holding wait_queue_head::lock or when used for > > > >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, May 09, 2018 at 08:45:18AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 10:41:20 +0200 > Peter Zijlstra wrote: > > > > This is easily done by using "::" instead of just ":". > > > > And I'll voice my objection once again. This makes a regular comment > >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, May 09, 2018 at 08:45:18AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 10:41:20 +0200 > Peter Zijlstra wrote: > > > > This is easily done by using "::" instead of just ":". > > > > And I'll voice my objection once again. This makes a regular comment > > worse. This rst stuff is

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, May 10, 2018 at 06:38:05AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 10 May 2018 01:38:38 -0700 > Christoph Hellwig escreveu: > > > > * Use either while holding wait_queue_head::lock or when used for > > > wakeups > > > - * with an extra smp_mb() like: > > > +

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Thu, May 10, 2018 at 06:38:05AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 10 May 2018 01:38:38 -0700 > Christoph Hellwig escreveu: > > > > * Use either while holding wait_queue_head::lock or when used for > > > wakeups > > > - * with an extra smp_mb() like: > > > + * with an extra

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 01:38:38 -0700 Christoph Hellwig escreveu: > > * Use either while holding wait_queue_head::lock or when used for wakeups > > - * with an extra smp_mb() like: > > + * with an extra smp_mb() like:: > > Independent of any philosophical discussion not

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

Em Thu, 10 May 2018 01:38:38 -0700 Christoph Hellwig escreveu: > > * Use either while holding wait_queue_head::lock or when used for wakeups > > - * with an extra smp_mb() like: > > + * with an extra smp_mb() like:: > > Independent of any philosophical discussion not allowing a setence to >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

> * Use either while holding wait_queue_head::lock or when used for wakeups > - * with an extra smp_mb() like: > + * with an extra smp_mb() like:: Independent of any philosophical discussion not allowing a setence to end with a single ':' is completely idiotic. Please fix the tooling instead

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

> * Use either while holding wait_queue_head::lock or when used for wakeups > - * with an extra smp_mb() like: > + * with an extra smp_mb() like:: Independent of any philosophical discussion not allowing a setence to end with a single ':' is completely idiotic. Please fix the tooling instead

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, May 09, 2018 at 12:35:40PM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 17:20:26 +0200 > Peter Zijlstra wrote: > > > The whole rst wankery is detrimental to that interface in order to > > pander to something else.. I don't see the value. I've objected before,

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, May 09, 2018 at 12:35:40PM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 17:20:26 +0200 > Peter Zijlstra wrote: > > > The whole rst wankery is detrimental to that interface in order to > > pander to something else.. I don't see the value. I've objected before, > > and I suppose I'll

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

> Am 09.05.2018 um 20:35 schrieb Jonathan Corbet : > >> Why should I care for people not using text editors to write code? Eh? .. why must readers write code? We have rules how to write kernel-doc markup since the beginning of the century. If you do not want to contribute

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

> Am 09.05.2018 um 20:35 schrieb Jonathan Corbet : > >> Why should I care for people not using text editors to write code? Eh? .. why must readers write code? We have rules how to write kernel-doc markup since the beginning of the century. If you do not want to contribute kernel-doc markups,

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, 9 May 2018 17:20:26 +0200 Peter Zijlstra wrote: > The whole rst wankery is detrimental to that interface in order to > pander to something else.. I don't see the value. I've objected before, > and I suppose I'll object again. One person's wankery is another's

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, 9 May 2018 17:20:26 +0200 Peter Zijlstra wrote: > The whole rst wankery is detrimental to that interface in order to > pander to something else.. I don't see the value. I've objected before, > and I suppose I'll object again. One person's wankery is another's integrated, browsable, and

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, May 09, 2018 at 08:45:18AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 10:41:20 +0200 > Peter Zijlstra wrote: > > > > This is easily done by using "::" instead of just ":". > > > > And I'll voice my objection once again. This makes a regular comment > >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, May 09, 2018 at 08:45:18AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 10:41:20 +0200 > Peter Zijlstra wrote: > > > > This is easily done by using "::" instead of just ":". > > > > And I'll voice my objection once again. This makes a regular comment > > worse. This rst stuff is

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, 9 May 2018 10:41:20 +0200 Peter Zijlstra wrote: > > This is easily done by using "::" instead of just ":". > > And I'll voice my objection once again. This makes a regular comment > worse. This rst stuff is utter shit for making normal text files less > readable

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Wed, 9 May 2018 10:41:20 +0200 Peter Zijlstra wrote: > > This is easily done by using "::" instead of just ":". > > And I'll voice my objection once again. This makes a regular comment > worse. This rst stuff is utter shit for making normal text files less > readable in your favourite text

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Mon, May 07, 2018 at 06:35:49AM -0300, Mauro Carvalho Chehab wrote: > The flow diagram should be inside a code-block to avoid those > warnings: > ./include/linux/wait.h:110: WARNING: Block quote ends without a blank > line; unexpected unindent. > ./include/linux/wait.h:113:

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

On Mon, May 07, 2018 at 06:35:49AM -0300, Mauro Carvalho Chehab wrote: > The flow diagram should be inside a code-block to avoid those > warnings: > ./include/linux/wait.h:110: WARNING: Block quote ends without a blank > line; unexpected unindent. > ./include/linux/wait.h:113:

[PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

The flow diagram should be inside a code-block to avoid those warnings: ./include/linux/wait.h:110: WARNING: Block quote ends without a blank line; unexpected unindent. ./include/linux/wait.h:113: WARNING: Unexpected indentation. ./include/linux/wait.h:115: WARNING: Block

[PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

The flow diagram should be inside a code-block to avoid those warnings: ./include/linux/wait.h:110: WARNING: Block quote ends without a blank line; unexpected unindent. ./include/linux/wait.h:113: WARNING: Unexpected indentation. ./include/linux/wait.h:115: WARNING: Block