Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-14 Thread Gabbay, Oded
On Sat, 2014-07-12 at 07:42 +1000, Dave Airlie wrote: > > +/* The 64-bit ABI is the authoritative version. */ > > +#pragma pack(push, 8) > > + > > Don't do this, pad and align things explicitly in structs. > > > +struct kfd_ioctl_create_queue_args { > > + uint64_t ring_base_address;

Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-14 Thread Gabbay, Oded
On Sat, 2014-07-12 at 07:42 +1000, Dave Airlie wrote: +/* The 64-bit ABI is the authoritative version. */ +#pragma pack(push, 8) + Don't do this, pad and align things explicitly in structs. +struct kfd_ioctl_create_queue_args { + uint64_t ring_base_address; /* to

Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-11 Thread Dave Airlie
> +/* The 64-bit ABI is the authoritative version. */ > +#pragma pack(push, 8) > + Don't do this, pad and align things explicitly in structs. > +struct kfd_ioctl_create_queue_args { > + uint64_t ring_base_address; /* to KFD */ > + uint32_t ring_size; /* to KFD */ > +

Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-11 Thread Jerome Glisse
On Fri, Jul 11, 2014 at 12:50:13AM +0300, Oded Gabbay wrote: > This patch adds 2 new IOCTL to kfd driver. > > The first IOCTL is KFD_IOC_CREATE_QUEUE that is used by the user-mode > application to create a compute queue on the GPU. > > The second IOCTL is KFD_IOC_DESTROY_QUEUE that is used by

Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-11 Thread Jerome Glisse
On Fri, Jul 11, 2014 at 12:50:13AM +0300, Oded Gabbay wrote: > This patch adds 2 new IOCTL to kfd driver. > > The first IOCTL is KFD_IOC_CREATE_QUEUE that is used by the user-mode > application to create a compute queue on the GPU. > > The second IOCTL is KFD_IOC_DESTROY_QUEUE that is used by

Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-11 Thread Jerome Glisse
On Fri, Jul 11, 2014 at 12:50:13AM +0300, Oded Gabbay wrote: This patch adds 2 new IOCTL to kfd driver. The first IOCTL is KFD_IOC_CREATE_QUEUE that is used by the user-mode application to create a compute queue on the GPU. The second IOCTL is KFD_IOC_DESTROY_QUEUE that is used by the

Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-11 Thread Jerome Glisse
On Fri, Jul 11, 2014 at 12:50:13AM +0300, Oded Gabbay wrote: This patch adds 2 new IOCTL to kfd driver. The first IOCTL is KFD_IOC_CREATE_QUEUE that is used by the user-mode application to create a compute queue on the GPU. The second IOCTL is KFD_IOC_DESTROY_QUEUE that is used by the

Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-11 Thread Dave Airlie
+/* The 64-bit ABI is the authoritative version. */ +#pragma pack(push, 8) + Don't do this, pad and align things explicitly in structs. +struct kfd_ioctl_create_queue_args { + uint64_t ring_base_address; /* to KFD */ + uint32_t ring_size; /* to KFD */ +

[PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-10 Thread Oded Gabbay
This patch adds 2 new IOCTL to kfd driver. The first IOCTL is KFD_IOC_CREATE_QUEUE that is used by the user-mode application to create a compute queue on the GPU. The second IOCTL is KFD_IOC_DESTROY_QUEUE that is used by the user-mode application to destroy an existing compute queue on the GPU.

[PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

2014-07-10 Thread Oded Gabbay
This patch adds 2 new IOCTL to kfd driver. The first IOCTL is KFD_IOC_CREATE_QUEUE that is used by the user-mode application to create a compute queue on the GPU. The second IOCTL is KFD_IOC_DESTROY_QUEUE that is used by the user-mode application to destroy an existing compute queue on the GPU.