Re: [PATCH 14/14] misc: ti-st: Drop superseded driver
On Fri, Dec 21, 2018 at 9:00 PM Sebastian Reichel wrote: > > Hi, > > On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote: > > On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote: > > > > > > From: Sebastian Reichel > > > > > > This driver has been superseded by the serdev based Bluetooth > > > hci_ll driver, which is initialized from DT. All mainline users > > > have been converted and this driver can be safely dropped. > > > > There seems to be an issue with my wl1283 because the > > logicod-torpedo-37xx-devkit doesn't work with the proposed device tree > > changes, but the older shared transport driver still works. > > I commented on the patch that modifies the board with details of the > > firmware timeout. > > > > Until this is resolved, I'd like to hold off on applying these changes. > > mh :/ I can't help with this, since I don't have this board (nor any > other wl1283 based one). Is the FM part usable on that device? If > its unusable the patchset could be splitted. I don't have functional FM (it's not wired), so i have no issues splitting the FM part. I'm hoping to hear from some other 1283-st users to see if they have success. > > > Also, there are references to this driver inside pdata-quirks that > > need to be removed as well once the loading and timeout issues have > > been resolved. > > I dropped the pdata-quirks for TI_ST in patch 3 of this series. My bad, sorry I missed it that part. > > -- Sebastian > adam > > > > adam > > > > > > Signed-off-by: Sebastian Reichel > > > --- > > > drivers/misc/Kconfig | 1 - > > > drivers/misc/Makefile| 1 - > > > drivers/misc/ti-st/Kconfig | 18 - > > > drivers/misc/ti-st/Makefile | 6 - > > > drivers/misc/ti-st/st_core.c | 922 --- > > > drivers/misc/ti-st/st_kim.c | 868 - > > > drivers/misc/ti-st/st_ll.c | 169 --- > > > include/linux/ti_wilink_st.h | 335 - > > > 8 files changed, 2320 deletions(-) > > > delete mode 100644 drivers/misc/ti-st/Kconfig > > > delete mode 100644 drivers/misc/ti-st/Makefile > > > delete mode 100644 drivers/misc/ti-st/st_core.c > > > delete mode 100644 drivers/misc/ti-st/st_kim.c > > > delete mode 100644 drivers/misc/ti-st/st_ll.c > > > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > > index 3726eacdf65d..a5cc07d33c74 100644 > > > --- a/drivers/misc/Kconfig > > > +++ b/drivers/misc/Kconfig > > > @@ -516,7 +516,6 @@ config MISC_RTSX > > > source "drivers/misc/c2port/Kconfig" > > > source "drivers/misc/eeprom/Kconfig" > > > source "drivers/misc/cb710/Kconfig" > > > -source "drivers/misc/ti-st/Kconfig" > > > source "drivers/misc/lis3lv02d/Kconfig" > > > source "drivers/misc/altera-stapl/Kconfig" > > > source "drivers/misc/mei/Kconfig" > > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > > index af22bbc3d00c..31c1e3eb4952 100644 > > > --- a/drivers/misc/Makefile > > > +++ b/drivers/misc/Makefile > > > @@ -39,7 +39,6 @@ obj-y += cb710/ > > > obj-$(CONFIG_SPEAR13XX_PCIE_GADGET)+= spear13xx_pcie_gadget.o > > > obj-$(CONFIG_VMWARE_BALLOON) += vmw_balloon.o > > > obj-$(CONFIG_PCH_PHUB) += pch_phub.o > > > -obj-y += ti-st/ > > > obj-y += lis3lv02d/ > > > obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o > > > obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ > > > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > > > deleted file mode 100644 > > > index 5bb92698bc80.. > > > --- a/drivers/misc/ti-st/Kconfig > > > +++ /dev/null > > > @@ -1,18 +0,0 @@ > > > -# > > > -# TI's shared transport line discipline and the protocol > > > -# drivers (BT, FM and GPS) > > > -# > > > -menu "Texas Instruments shared transport line discipline" > > > -config TI_ST > > > - tristate "Shared transport core driver" > > > - depends on NET && TTY > > > - depends on GPIOLIB || COMPILE_TEST > > > - select FW_LOADER > > > - help > > > - This enables the shared transport core driver for TI > > > - BT / FM and GPS combo chips. This enables protocol drivers > > > - to register themselves with core and send data, the responses > > > - are returned to relevant protocol drivers based on their > > > - packet types. > > > - > > > -endmenu > > > diff --git a/drivers/misc/ti-st/Makefile b/drivers/misc/ti-st/Makefile > > > deleted file mode 100644 > > > index 78d7ebb14749.. > > > --- a/drivers/misc/ti-st/Makefile > > > +++ /dev/null > > > @@ -1,6 +0,0 @@ > > > -# > > > -# Makefile for TI's shared transport line discipline > > > -# and its protocol drivers (BT, FM, GPS) > > > -# > > > -obj-$(CONFIG_TI_ST)+= st_drv.o > > > -st_drv-objs:= st_core.o st_kim.o st_ll.o > > > diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c > > > deleted file mode 100644 > >
Re: [PATCH 14/14] misc: ti-st: Drop superseded driver
Hi, On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote: > On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote: > > > > From: Sebastian Reichel > > > > This driver has been superseded by the serdev based Bluetooth > > hci_ll driver, which is initialized from DT. All mainline users > > have been converted and this driver can be safely dropped. > > There seems to be an issue with my wl1283 because the > logicod-torpedo-37xx-devkit doesn't work with the proposed device tree > changes, but the older shared transport driver still works. > I commented on the patch that modifies the board with details of the > firmware timeout. > > Until this is resolved, I'd like to hold off on applying these changes. mh :/ I can't help with this, since I don't have this board (nor any other wl1283 based one). Is the FM part usable on that device? If its unusable the patchset could be splitted. > Also, there are references to this driver inside pdata-quirks that > need to be removed as well once the loading and timeout issues have > been resolved. I dropped the pdata-quirks for TI_ST in patch 3 of this series. -- Sebastian > > adam > > > > Signed-off-by: Sebastian Reichel > > --- > > drivers/misc/Kconfig | 1 - > > drivers/misc/Makefile| 1 - > > drivers/misc/ti-st/Kconfig | 18 - > > drivers/misc/ti-st/Makefile | 6 - > > drivers/misc/ti-st/st_core.c | 922 --- > > drivers/misc/ti-st/st_kim.c | 868 - > > drivers/misc/ti-st/st_ll.c | 169 --- > > include/linux/ti_wilink_st.h | 335 - > > 8 files changed, 2320 deletions(-) > > delete mode 100644 drivers/misc/ti-st/Kconfig > > delete mode 100644 drivers/misc/ti-st/Makefile > > delete mode 100644 drivers/misc/ti-st/st_core.c > > delete mode 100644 drivers/misc/ti-st/st_kim.c > > delete mode 100644 drivers/misc/ti-st/st_ll.c > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > index 3726eacdf65d..a5cc07d33c74 100644 > > --- a/drivers/misc/Kconfig > > +++ b/drivers/misc/Kconfig > > @@ -516,7 +516,6 @@ config MISC_RTSX > > source "drivers/misc/c2port/Kconfig" > > source "drivers/misc/eeprom/Kconfig" > > source "drivers/misc/cb710/Kconfig" > > -source "drivers/misc/ti-st/Kconfig" > > source "drivers/misc/lis3lv02d/Kconfig" > > source "drivers/misc/altera-stapl/Kconfig" > > source "drivers/misc/mei/Kconfig" > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > index af22bbc3d00c..31c1e3eb4952 100644 > > --- a/drivers/misc/Makefile > > +++ b/drivers/misc/Makefile > > @@ -39,7 +39,6 @@ obj-y += cb710/ > > obj-$(CONFIG_SPEAR13XX_PCIE_GADGET)+= spear13xx_pcie_gadget.o > > obj-$(CONFIG_VMWARE_BALLOON) += vmw_balloon.o > > obj-$(CONFIG_PCH_PHUB) += pch_phub.o > > -obj-y += ti-st/ > > obj-y += lis3lv02d/ > > obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o > > obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ > > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > > deleted file mode 100644 > > index 5bb92698bc80.. > > --- a/drivers/misc/ti-st/Kconfig > > +++ /dev/null > > @@ -1,18 +0,0 @@ > > -# > > -# TI's shared transport line discipline and the protocol > > -# drivers (BT, FM and GPS) > > -# > > -menu "Texas Instruments shared transport line discipline" > > -config TI_ST > > - tristate "Shared transport core driver" > > - depends on NET && TTY > > - depends on GPIOLIB || COMPILE_TEST > > - select FW_LOADER > > - help > > - This enables the shared transport core driver for TI > > - BT / FM and GPS combo chips. This enables protocol drivers > > - to register themselves with core and send data, the responses > > - are returned to relevant protocol drivers based on their > > - packet types. > > - > > -endmenu > > diff --git a/drivers/misc/ti-st/Makefile b/drivers/misc/ti-st/Makefile > > deleted file mode 100644 > > index 78d7ebb14749.. > > --- a/drivers/misc/ti-st/Makefile > > +++ /dev/null > > @@ -1,6 +0,0 @@ > > -# > > -# Makefile for TI's shared transport line discipline > > -# and its protocol drivers (BT, FM, GPS) > > -# > > -obj-$(CONFIG_TI_ST)+= st_drv.o > > -st_drv-objs:= st_core.o st_kim.o st_ll.o > > diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c > > deleted file mode 100644 > > index eda8d407be28.. > > --- a/drivers/misc/ti-st/st_core.c > > +++ /dev/null > > @@ -1,922 +0,0 @@ > > -/* > > - * Shared Transport Line discipline driver Core > > - * This hooks up ST KIM driver and ST LL driver > > - * Copyright (C) 2009-2010 Texas Instruments > > - * Author: Pavan Savoy > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - *
Re: [PATCH 14/14] misc: ti-st: Drop superseded driver
On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote: > > From: Sebastian Reichel > > This driver has been superseded by the serdev based Bluetooth > hci_ll driver, which is initialized from DT. All mainline users > have been converted and this driver can be safely dropped. There seems to be an issue with my wl1283 because the logicod-torpedo-37xx-devkit doesn't work with the proposed device tree changes, but the older shared transport driver still works. I commented on the patch that modifies the board with details of the firmware timeout. Until this is resolved, I'd like to hold off on applying these changes. Also, there are references to this driver inside pdata-quirks that need to be removed as well once the loading and timeout issues have been resolved. adam > > Signed-off-by: Sebastian Reichel > --- > drivers/misc/Kconfig | 1 - > drivers/misc/Makefile| 1 - > drivers/misc/ti-st/Kconfig | 18 - > drivers/misc/ti-st/Makefile | 6 - > drivers/misc/ti-st/st_core.c | 922 --- > drivers/misc/ti-st/st_kim.c | 868 - > drivers/misc/ti-st/st_ll.c | 169 --- > include/linux/ti_wilink_st.h | 335 - > 8 files changed, 2320 deletions(-) > delete mode 100644 drivers/misc/ti-st/Kconfig > delete mode 100644 drivers/misc/ti-st/Makefile > delete mode 100644 drivers/misc/ti-st/st_core.c > delete mode 100644 drivers/misc/ti-st/st_kim.c > delete mode 100644 drivers/misc/ti-st/st_ll.c > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 3726eacdf65d..a5cc07d33c74 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -516,7 +516,6 @@ config MISC_RTSX > source "drivers/misc/c2port/Kconfig" > source "drivers/misc/eeprom/Kconfig" > source "drivers/misc/cb710/Kconfig" > -source "drivers/misc/ti-st/Kconfig" > source "drivers/misc/lis3lv02d/Kconfig" > source "drivers/misc/altera-stapl/Kconfig" > source "drivers/misc/mei/Kconfig" > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index af22bbc3d00c..31c1e3eb4952 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -39,7 +39,6 @@ obj-y += cb710/ > obj-$(CONFIG_SPEAR13XX_PCIE_GADGET)+= spear13xx_pcie_gadget.o > obj-$(CONFIG_VMWARE_BALLOON) += vmw_balloon.o > obj-$(CONFIG_PCH_PHUB) += pch_phub.o > -obj-y += ti-st/ > obj-y += lis3lv02d/ > obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o > obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/ > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > deleted file mode 100644 > index 5bb92698bc80.. > --- a/drivers/misc/ti-st/Kconfig > +++ /dev/null > @@ -1,18 +0,0 @@ > -# > -# TI's shared transport line discipline and the protocol > -# drivers (BT, FM and GPS) > -# > -menu "Texas Instruments shared transport line discipline" > -config TI_ST > - tristate "Shared transport core driver" > - depends on NET && TTY > - depends on GPIOLIB || COMPILE_TEST > - select FW_LOADER > - help > - This enables the shared transport core driver for TI > - BT / FM and GPS combo chips. This enables protocol drivers > - to register themselves with core and send data, the responses > - are returned to relevant protocol drivers based on their > - packet types. > - > -endmenu > diff --git a/drivers/misc/ti-st/Makefile b/drivers/misc/ti-st/Makefile > deleted file mode 100644 > index 78d7ebb14749.. > --- a/drivers/misc/ti-st/Makefile > +++ /dev/null > @@ -1,6 +0,0 @@ > -# > -# Makefile for TI's shared transport line discipline > -# and its protocol drivers (BT, FM, GPS) > -# > -obj-$(CONFIG_TI_ST)+= st_drv.o > -st_drv-objs:= st_core.o st_kim.o st_ll.o > diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c > deleted file mode 100644 > index eda8d407be28.. > --- a/drivers/misc/ti-st/st_core.c > +++ /dev/null > @@ -1,922 +0,0 @@ > -/* > - * Shared Transport Line discipline driver Core > - * This hooks up ST KIM driver and ST LL driver > - * Copyright (C) 2009-2010 Texas Instruments > - * Author: Pavan Savoy > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > - * > - */ > - >
[PATCH 14/14] misc: ti-st: Drop superseded driver
From: Sebastian Reichel
This driver has been superseded by the serdev based Bluetooth
hci_ll driver, which is initialized from DT. All mainline users
have been converted and this driver can be safely dropped.
Signed-off-by: Sebastian Reichel
---
drivers/misc/Kconfig | 1 -
drivers/misc/Makefile| 1 -
drivers/misc/ti-st/Kconfig | 18 -
drivers/misc/ti-st/Makefile | 6 -
drivers/misc/ti-st/st_core.c | 922 ---
drivers/misc/ti-st/st_kim.c | 868 -
drivers/misc/ti-st/st_ll.c | 169 ---
include/linux/ti_wilink_st.h | 335 -
8 files changed, 2320 deletions(-)
delete mode 100644 drivers/misc/ti-st/Kconfig
delete mode 100644 drivers/misc/ti-st/Makefile
delete mode 100644 drivers/misc/ti-st/st_core.c
delete mode 100644 drivers/misc/ti-st/st_kim.c
delete mode 100644 drivers/misc/ti-st/st_ll.c
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 3726eacdf65d..a5cc07d33c74 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -516,7 +516,6 @@ config MISC_RTSX
source "drivers/misc/c2port/Kconfig"
source "drivers/misc/eeprom/Kconfig"
source "drivers/misc/cb710/Kconfig"
-source "drivers/misc/ti-st/Kconfig"
source "drivers/misc/lis3lv02d/Kconfig"
source "drivers/misc/altera-stapl/Kconfig"
source "drivers/misc/mei/Kconfig"
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index af22bbc3d00c..31c1e3eb4952 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -39,7 +39,6 @@ obj-y += cb710/
obj-$(CONFIG_SPEAR13XX_PCIE_GADGET)+= spear13xx_pcie_gadget.o
obj-$(CONFIG_VMWARE_BALLOON) += vmw_balloon.o
obj-$(CONFIG_PCH_PHUB) += pch_phub.o
-obj-y += ti-st/
obj-y += lis3lv02d/
obj-$(CONFIG_USB_SWITCH_FSA9480) += fsa9480.o
obj-$(CONFIG_ALTERA_STAPL) +=altera-stapl/
diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig
deleted file mode 100644
index 5bb92698bc80..
--- a/drivers/misc/ti-st/Kconfig
+++ /dev/null
@@ -1,18 +0,0 @@
-#
-# TI's shared transport line discipline and the protocol
-# drivers (BT, FM and GPS)
-#
-menu "Texas Instruments shared transport line discipline"
-config TI_ST
- tristate "Shared transport core driver"
- depends on NET && TTY
- depends on GPIOLIB || COMPILE_TEST
- select FW_LOADER
- help
- This enables the shared transport core driver for TI
- BT / FM and GPS combo chips. This enables protocol drivers
- to register themselves with core and send data, the responses
- are returned to relevant protocol drivers based on their
- packet types.
-
-endmenu
diff --git a/drivers/misc/ti-st/Makefile b/drivers/misc/ti-st/Makefile
deleted file mode 100644
index 78d7ebb14749..
--- a/drivers/misc/ti-st/Makefile
+++ /dev/null
@@ -1,6 +0,0 @@
-#
-# Makefile for TI's shared transport line discipline
-# and its protocol drivers (BT, FM, GPS)
-#
-obj-$(CONFIG_TI_ST)+= st_drv.o
-st_drv-objs:= st_core.o st_kim.o st_ll.o
diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
deleted file mode 100644
index eda8d407be28..
--- a/drivers/misc/ti-st/st_core.c
+++ /dev/null
@@ -1,922 +0,0 @@
-/*
- * Shared Transport Line discipline driver Core
- * This hooks up ST KIM driver and ST LL driver
- * Copyright (C) 2009-2010 Texas Instruments
- * Author: Pavan Savoy
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
- */
-
-#define pr_fmt(fmt)"(stc): " fmt
-#include
-#include
-#include
-
-#include
-#include
-
-#include
-
-extern void st_kim_recv(void *, const unsigned char *, long);
-void st_int_recv(void *, const unsigned char *, long);
-/* function pointer pointing to either,
- * st_kim_recv during registration to receive fw download responses
- * st_int_recv after registration to receive proto stack responses
- */
-static void (*st_recv) (void *, const unsigned char *, long);
-
-//
-static void add_channel_to_table(struct st_data_s *st_gdata,
- struct st_proto_s *new_proto)
-{
- pr_info("%s: id %d\n", __func__, new_proto->chnl_id);
- /* list now has the channel id as index itself */
-
