Re: [PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

2018-08-06 Thread Jiri Olsa
On Mon, Aug 06, 2018 at 12:22:19PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > > > -ops->set_jumps_percent_color, > > > > ops->printf, > > > > -ops->write_graph); > > > > + __annotation_line__write(al, notes, wops->first_l

Re: [PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 06, 2018 at 04:24:47PM +0200, Jiri Olsa escreveu: > On Mon, Aug 06, 2018 at 10:45:07PM +0900, Namhyung Kim wrote: > > Hi Jiri, > > > > On Sat, Aug 04, 2018 at 03:05:15PM +0200, Jiri Olsa wrote: > > > Passing struct annotation_options to map_symbol__annotation_dump, > > > to carry on an

Re: [PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

2018-08-06 Thread Jiri Olsa
On Mon, Aug 06, 2018 at 10:45:07PM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Sat, Aug 04, 2018 at 03:05:15PM +0200, Jiri Olsa wrote: > > Passing struct annotation_options to map_symbol__annotation_dump, > > to carry on and pass the percent_type value. > > > > Link: http://lkml.kernel.org/n/tip

Re: [PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

2018-08-06 Thread Namhyung Kim
Hi Jiri, On Sat, Aug 04, 2018 at 03:05:15PM +0200, Jiri Olsa wrote: > Passing struct annotation_options to map_symbol__annotation_dump, > to carry on and pass the percent_type value. > > Link: http://lkml.kernel.org/n/tip-5toohgdkgpk3vn6zebusr...@git.kernel.org > Signed-off-by: Jiri Olsa > ---

[PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

2018-08-04 Thread Jiri Olsa
Passing struct annotation_options to map_symbol__annotation_dump, to carry on and pass the percent_type value. Link: http://lkml.kernel.org/n/tip-5toohgdkgpk3vn6zebusr...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/ui/browsers/annotate.c | 4 +-- tools/perf/util/annotate.c| 4