Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-03 Thread Adrian Hunter
On 02/02/15 19:30, Jiri Olsa wrote: > On Mon, Feb 02, 2015 at 11:56:09PM +0900, Namhyung Kim wrote: >> Hi Jiri and Adrian, >> >> On Mon, Feb 2, 2015 at 9:13 PM, Jiri Olsa wrote: >>> On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: >>> >>> SNIP >>> >> >> Why not make it the

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-03 Thread Adrian Hunter
On 02/02/15 19:30, Jiri Olsa wrote: On Mon, Feb 02, 2015 at 11:56:09PM +0900, Namhyung Kim wrote: Hi Jiri and Adrian, On Mon, Feb 2, 2015 at 9:13 PM, Jiri Olsa jo...@redhat.com wrote: On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: SNIP Why not make it the same as all the

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 11:56:09PM +0900, Namhyung Kim wrote: > Hi Jiri and Adrian, > > On Mon, Feb 2, 2015 at 9:13 PM, Jiri Olsa wrote: > > On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: > > > > SNIP > > > >> >> > >> >> Why not make it the same as all the other data. i.e. find

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Namhyung Kim
Hi Jiri and Adrian, On Mon, Feb 2, 2015 at 9:13 PM, Jiri Olsa wrote: > On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: > > SNIP > >> >> >> >> Why not make it the same as all the other data. i.e. find the start and >> >> size >> >> via the index? And then just lump all the data

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: SNIP > >> > >> Why not make it the same as all the other data. i.e. find the start and > >> size > >> via the index? And then just lump all the data together? > > > > thats what I suggested > > No, I meant really lump it all

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Adrian Hunter
On 02/02/15 12:05, Jiri Olsa wrote: > On Mon, Feb 02, 2015 at 11:52:26AM +0200, Adrian Hunter wrote: >> On 02/02/15 11:15, Jiri Olsa wrote: >>> On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: >>> >>> SNIP >>> > but how about bump up the header version for this feature? ;-) >

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 11:52:26AM +0200, Adrian Hunter wrote: > On 02/02/15 11:15, Jiri Olsa wrote: > > On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: > > > > SNIP > > > >>> but how about bump up the header version for this feature? ;-) > >>> > >>> currently it's: > >>> > >>>

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Adrian Hunter
On 02/02/15 11:15, Jiri Olsa wrote: > On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: > > SNIP > >>> but how about bump up the header version for this feature? ;-) >>> >>> currently it's: >>> >>> struct perf_file_header { >>> u64 magic; >>>

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: SNIP > > but how about bump up the header version for this feature? ;-) > > > > currently it's: > > > > struct perf_file_header { > > u64 magic; > > u64 size;

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Adrian Hunter
On 01/02/15 20:06, Jiri Olsa wrote: > On Thu, Jan 29, 2015 at 05:06:55PM +0900, Namhyung Kim wrote: >> The new --index option will create indexed data file which can be >> processed by multiple threads parallelly. It saves meta event and >> sample data in separate files and merges them with an

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Adrian Hunter
On 02/02/15 12:05, Jiri Olsa wrote: On Mon, Feb 02, 2015 at 11:52:26AM +0200, Adrian Hunter wrote: On 02/02/15 11:15, Jiri Olsa wrote: On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: SNIP but how about bump up the header version for this feature? ;-) currently it's:

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Adrian Hunter
On 02/02/15 11:15, Jiri Olsa wrote: On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: SNIP but how about bump up the header version for this feature? ;-) currently it's: struct perf_file_header { u64 magic; u64

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: SNIP Why not make it the same as all the other data. i.e. find the start and size via the index? And then just lump all the data together? thats what I suggested No, I meant really lump it all together. i.e.

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 11:52:26AM +0200, Adrian Hunter wrote: On 02/02/15 11:15, Jiri Olsa wrote: On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: SNIP but how about bump up the header version for this feature? ;-) currently it's: struct perf_file_header {

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Namhyung Kim
Hi Jiri and Adrian, On Mon, Feb 2, 2015 at 9:13 PM, Jiri Olsa jo...@redhat.com wrote: On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: SNIP Why not make it the same as all the other data. i.e. find the start and size via the index? And then just lump all the data

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 11:56:09PM +0900, Namhyung Kim wrote: Hi Jiri and Adrian, On Mon, Feb 2, 2015 at 9:13 PM, Jiri Olsa jo...@redhat.com wrote: On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote: SNIP Why not make it the same as all the other data. i.e. find the

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Adrian Hunter
On 01/02/15 20:06, Jiri Olsa wrote: On Thu, Jan 29, 2015 at 05:06:55PM +0900, Namhyung Kim wrote: The new --index option will create indexed data file which can be processed by multiple threads parallelly. It saves meta event and sample data in separate files and merges them with an index

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-02 Thread Jiri Olsa
On Mon, Feb 02, 2015 at 10:34:50AM +0200, Adrian Hunter wrote: SNIP but how about bump up the header version for this feature? ;-) currently it's: struct perf_file_header { u64 magic; u64 size; u64

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-01 Thread Jiri Olsa
On Thu, Jan 29, 2015 at 05:06:55PM +0900, Namhyung Kim wrote: > The new --index option will create indexed data file which can be > processed by multiple threads parallelly. It saves meta event and > sample data in separate files and merges them with an index table. > > To build an index table,

Re: [PATCH 14/42] perf record: Add --index option for building index table

2015-02-01 Thread Jiri Olsa
On Thu, Jan 29, 2015 at 05:06:55PM +0900, Namhyung Kim wrote: The new --index option will create indexed data file which can be processed by multiple threads parallelly. It saves meta event and sample data in separate files and merges them with an index table. To build an index table, it

[PATCH 14/42] perf record: Add --index option for building index table

2015-01-29 Thread Namhyung Kim
The new --index option will create indexed data file which can be processed by multiple threads parallelly. It saves meta event and sample data in separate files and merges them with an index table. To build an index table, it needs to know exact offsets and sizes for each sample data. However

[PATCH 14/42] perf record: Add --index option for building index table

2015-01-29 Thread Namhyung Kim
The new --index option will create indexed data file which can be processed by multiple threads parallelly. It saves meta event and sample data in separate files and merges them with an index table. To build an index table, it needs to know exact offsets and sizes for each sample data. However