Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 01:03:19AM +0200, Tomasz Figa wrote: > On Sunday 11 of August 2013 20:11:40 Mark Brown wrote: > > Do we need the select here (or should we have other selects for the > > Exynos SoCs)? > The driver would build fine without this symbol selected, but since it > relies on

Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 01:03:19AM +0200, Tomasz Figa wrote: On Sunday 11 of August 2013 20:11:40 Mark Brown wrote: Do we need the select here (or should we have other selects for the Exynos SoCs)? The driver would build fine without this symbol selected, but since it relies on

Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Tomasz Figa
Hi Mark, On Sunday 11 of August 2013 20:11:40 Mark Brown wrote: > On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote: > > @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ > > > > config SPI_S3C64XX > > > > tristate "Samsung S3C64XX series type SPI" > > depends on (ARCH_S3C24XX ||

Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Mark Brown
On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote: > @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ > config SPI_S3C64XX > tristate "Samsung S3C64XX series type SPI" > depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_EXYNOS) > - select S3C64XX_DMA if

[PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Tomasz Figa
The legacy S3C64xx DMA driver has been removed, DMA support on S3C64xx is provided only by the generic PL08x driver. This patch modifies the Kconfig entry of spi-s3c64xx driver, which relies on availability of DMA, to always select the S3C64XX_PL080 symbol. Signed-off-by: Tomasz Figa ---

[PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Tomasz Figa
The legacy S3C64xx DMA driver has been removed, DMA support on S3C64xx is provided only by the generic PL08x driver. This patch modifies the Kconfig entry of spi-s3c64xx driver, which relies on availability of DMA, to always select the S3C64XX_PL080 symbol. Signed-off-by: Tomasz Figa

Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Mark Brown
On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote: @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ config SPI_S3C64XX tristate Samsung S3C64XX series type SPI depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_EXYNOS) - select S3C64XX_DMA if ARCH_S3C64XX

Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Tomasz Figa
Hi Mark, On Sunday 11 of August 2013 20:11:40 Mark Brown wrote: On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote: @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ config SPI_S3C64XX tristate Samsung S3C64XX series type SPI depends on (ARCH_S3C24XX || ARCH_S3C64XX ||