Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2013-06-07 Thread Konrad Rzeszutek Wilk
On Wed, Nov 28, 2012 at 10:14:44AM +1100, Dave Chinner wrote: > From: Dave Chinner > > Convert the driver shrinkers to the new API. Most changes are > compile tested only because I either don't have the hardware or it's > staging stuff. I presume that the the i915, ttm_page_alloc and ttm_page_al

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-29 Thread Dave Chinner
On Thu, Nov 29, 2012 at 02:29:33PM +0400, Glauber Costa wrote: > On 11/29/2012 01:28 AM, Dave Chinner wrote: > > On Wed, Nov 28, 2012 at 12:21:54PM +0400, Glauber Costa wrote: > >> On 11/28/2012 07:17 AM, Dave Chinner wrote: > >>> On Wed, Nov 28, 2012 at 01:13:11AM +, Chris Wilson wrote: >

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-29 Thread Glauber Costa
On 11/29/2012 01:28 AM, Dave Chinner wrote: > On Wed, Nov 28, 2012 at 12:21:54PM +0400, Glauber Costa wrote: >> On 11/28/2012 07:17 AM, Dave Chinner wrote: >>> On Wed, Nov 28, 2012 at 01:13:11AM +, Chris Wilson wrote: On Wed, 28 Nov 2012 10:14:44 +1100, Dave Chinner wrote: > +/*

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-28 Thread Dave Chinner
On Wed, Nov 28, 2012 at 12:21:54PM +0400, Glauber Costa wrote: > On 11/28/2012 07:17 AM, Dave Chinner wrote: > > On Wed, Nov 28, 2012 at 01:13:11AM +, Chris Wilson wrote: > >> On Wed, 28 Nov 2012 10:14:44 +1100, Dave Chinner > >> wrote: > >>> +/* > >>> + * XXX: (dchinner) This is one of the w

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-28 Thread Glauber Costa
On 11/28/2012 07:17 AM, Dave Chinner wrote: > On Wed, Nov 28, 2012 at 01:13:11AM +, Chris Wilson wrote: >> On Wed, 28 Nov 2012 10:14:44 +1100, Dave Chinner wrote: >>> +/* >>> + * XXX: (dchinner) This is one of the worst cases of shrinker abuse I've >>> seen. >>> + * >>> + * i915_gem_purge() e

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-27 Thread Dave Chinner
On Wed, Nov 28, 2012 at 01:13:11AM +, Chris Wilson wrote: > On Wed, 28 Nov 2012 10:14:44 +1100, Dave Chinner wrote: > > +/* > > + * XXX: (dchinner) This is one of the worst cases of shrinker abuse I've > > seen. > > + * > > + * i915_gem_purge() expects a byte count to be passed, and the minim

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-27 Thread Chris Wilson
On Wed, 28 Nov 2012 10:14:44 +1100, Dave Chinner wrote: > +/* > + * XXX: (dchinner) This is one of the worst cases of shrinker abuse I've > seen. > + * > + * i915_gem_purge() expects a byte count to be passed, and the minimum object > + * size is PAGE_SIZE. No, purge() expects a count of pages t

[PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-27 Thread Dave Chinner
From: Dave Chinner Convert the driver shrinkers to the new API. Most changes are compile tested only because I either don't have the hardware or it's staging stuff. FWIW, the md and android code is pretty good, but the rest of it makes me want to claw my eyes out. The amount of broken code I ju