Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-25 Thread Arnd Bergmann
On Tuesday, October 25, 2016 8:13:09 PM CEST Mark Brown wrote: > > Not enough information to check signature validity. Show Details > On Mon, Oct 24, 2016 at 10:37:53PM +0200, Arnd Bergmann wrote: > > > I think my patch (the version I sent) should ideally make it into > > v4.9 as a bugfix. This

Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-25 Thread Mark Brown
On Mon, Oct 24, 2016 at 10:37:53PM +0200, Arnd Bergmann wrote: > I think my patch (the version I sent) should ideally make it into > v4.9 as a bugfix. This was the powerpc warning I saw from Olof's > autobuilder with the -Wmaybe-uninitialized warning added back, and > it's one of the actual bugs I

Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-24 Thread Arnd Bergmann
On Monday, October 24, 2016 7:45:43 PM CEST Mark Brown wrote: > On Mon, Oct 24, 2016 at 08:36:37PM +0200, Heiner Kallweit wrote: > > Am 24.10.2016 um 19:27 schrieb Mark Brown: > > > > This doesn't apply against current code, please check and resend. > > > The not yet reviewed part of my patch ser

Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-24 Thread Mark Brown
On Tue, Oct 18, 2016 at 12:13:38AM +0200, Arnd Bergmann wrote: > When we get a spurious interrupt in fsl_espi_irq, we end up > processing four uninitalized bytes of data, as shown in this > warning message: This doesn't apply against current code, please check and resend. signature.asc Descripti

Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-24 Thread Mark Brown
On Mon, Oct 24, 2016 at 08:36:37PM +0200, Heiner Kallweit wrote: > Am 24.10.2016 um 19:27 schrieb Mark Brown: > > This doesn't apply against current code, please check and resend. > The not yet reviewed part of my patch series from Oct 2nd, > namely "[PATCH 07/11] spi: fsl-espi: fix and improve r

Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-24 Thread Heiner Kallweit
Am 24.10.2016 um 19:27 schrieb Mark Brown: > On Tue, Oct 18, 2016 at 12:13:38AM +0200, Arnd Bergmann wrote: >> When we get a spurious interrupt in fsl_espi_irq, we end up >> processing four uninitalized bytes of data, as shown in this >> warning message: > > This doesn't apply against current code

[PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-17 Thread Arnd Bergmann
When we get a spurious interrupt in fsl_espi_irq, we end up processing four uninitalized bytes of data, as shown in this warning message: drivers/spi/spi-fsl-espi.c: In function 'fsl_espi_irq': drivers/spi/spi-fsl-espi.c:462:4: warning: 'rx_data' may be used uninitialized in this function [