Re: [PATCH 19/26 v5] tracing: Use trace_seq_used() and seq_buf_used() instead of len

2014-11-17 Thread Steven Rostedt
On Fri, 14 Nov 2014 23:59:06 -0500 > /* > @@ -4575,20 +4575,33 @@ static size_t > tracing_fill_pipe_page(size_t rem, struct trace_iterator *iter) > { > size_t count; > + int save_len; > int ret; > > /* Seq buffer is page-sized, exactly what we need. */ >

Re: [PATCH 19/26 v5] tracing: Use trace_seq_used() and seq_buf_used() instead of len

2014-11-17 Thread Steven Rostedt
On Fri, 14 Nov 2014 23:59:06 -0500 /* @@ -4575,20 +4575,33 @@ static size_t tracing_fill_pipe_page(size_t rem, struct trace_iterator *iter) { size_t count; + int save_len; int ret; /* Seq buffer is page-sized, exactly what we need. */ for (;;) {

[PATCH 19/26 v5] tracing: Use trace_seq_used() and seq_buf_used() instead of len

2014-11-14 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" As the seq_buf->len will soon be +1 size when there's an overflow, we must use trace_seq_used() or seq_buf_used() methods to get the real length. This will prevent buffer overflow issues if just the len of the seq_buf descriptor is used to copy memory. Link:

[PATCH 19/26 v5] tracing: Use trace_seq_used() and seq_buf_used() instead of len

2014-11-14 Thread Steven Rostedt
From: Steven Rostedt (Red Hat) rost...@goodmis.org As the seq_buf-len will soon be +1 size when there's an overflow, we must use trace_seq_used() or seq_buf_used() methods to get the real length. This will prevent buffer overflow issues if just the len of the seq_buf descriptor is used to copy