Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2017 05:08 AM, Marek Szyprowski wrote: [snip] >> >> This seems to be caused by some needed clocks to access the power domains >> to be gated, since I don't get these erros when passing clk_ignore_unused >> as parameter in the kernel command line. > > I think that those

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2017 05:08 AM, Marek Szyprowski wrote: [snip] >> >> This seems to be caused by some needed clocks to access the power domains >> to be gated, since I don't get these erros when passing clk_ignore_unused >> as parameter in the kernel command line. > > I think that those

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello, On 01/20/2017 07:06 AM, Javier Martinez Canillas wrote: > Hello Marek, > > On 01/20/2017 05:37 AM, Marek Szyprowski wrote: > > [snip] >> >> Please send this patch instead of adding more clocks to the power domains. >> This way we will avoid adding more dependencies to userspace (DT ABI).

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello, On 01/20/2017 07:06 AM, Javier Martinez Canillas wrote: > Hello Marek, > > On 01/20/2017 05:37 AM, Marek Szyprowski wrote: > > [snip] >> >> Please send this patch instead of adding more clocks to the power domains. >> This way we will avoid adding more dependencies to userspace (DT ABI).

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2017 05:37 AM, Marek Szyprowski wrote: [snip] >> I'll post a proper patch for the exynos5800.dtsi, to override the >> clocks in the gsc_pd device node. >> >> I also see that the two power domains that fail to be disabled msc_pd >> (power-domain@10044120) and isp_pd

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2017 05:37 AM, Marek Szyprowski wrote: [snip] >> I'll post a proper patch for the exynos5800.dtsi, to override the >> clocks in the gsc_pd device node. >> >> I also see that the two power domains that fail to be disabled msc_pd >> (power-domain@10044120) and isp_pd

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2017 05:08 AM, Marek Szyprowski wrote: > Hi Javier, > [snip] >> Ok, I misunderstood the relationship between runtime PM and the power domains >> then. I thought the power domains were only powered on when the runtime PM >> framework resumed an associated device (i.e:

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2017 05:08 AM, Marek Szyprowski wrote: > Hi Javier, > [snip] >> Ok, I misunderstood the relationship between runtime PM and the power domains >> then. I thought the power domains were only powered on when the runtime PM >> framework resumed an associated device (i.e:

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Marek Szyprowski
Hi Javier, On 2017-01-19 18:51, Javier Martinez Canillas wrote: On 01/19/2017 11:56 AM, Javier Martinez Canillas wrote: On 01/19/2017 11:17 AM, Marek Szyprowski wrote: [snip] Also when removing the exynos_gsc driver, I get the same error: # rmmod s5p_mfc [ 106.405972] s5p-mfc

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Marek Szyprowski
Hi Javier, On 2017-01-19 18:51, Javier Martinez Canillas wrote: On 01/19/2017 11:56 AM, Javier Martinez Canillas wrote: On 01/19/2017 11:17 AM, Marek Szyprowski wrote: [snip] Also when removing the exynos_gsc driver, I get the same error: # rmmod s5p_mfc [ 106.405972] s5p-mfc

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Marek Szyprowski
Hi Javier, On 2017-01-19 15:56, Javier Martinez Canillas wrote: Thanks a lot for your feedback. On 01/19/2017 11:17 AM, Marek Szyprowski wrote: On 2017-01-18 01:30, Javier Martinez Canillas wrote: Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset")

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Marek Szyprowski
Hi Javier, On 2017-01-19 15:56, Javier Martinez Canillas wrote: Thanks a lot for your feedback. On 01/19/2017 11:17 AM, Marek Szyprowski wrote: On 2017-01-18 01:30, Javier Martinez Canillas wrote: Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset")

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Javier Martinez Canillas
Hello Marek, On 01/19/2017 11:56 AM, Javier Martinez Canillas wrote: > On 01/19/2017 11:17 AM, Marek Szyprowski wrote: [snip] > > Also when removing the exynos_gsc driver, I get the same error: > > # rmmod s5p_mfc > [ 106.405972] s5p-mfc 1100.codec: Removing 1100.codec > # rmmod

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Javier Martinez Canillas
Hello Marek, On 01/19/2017 11:56 AM, Javier Martinez Canillas wrote: > On 01/19/2017 11:17 AM, Marek Szyprowski wrote: [snip] > > Also when removing the exynos_gsc driver, I get the same error: > > # rmmod s5p_mfc > [ 106.405972] s5p-mfc 1100.codec: Removing 1100.codec > # rmmod

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Javier Martinez Canillas
Hello Marek, Thanks a lot for your feedback. On 01/19/2017 11:17 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-01-18 01:30, Javier Martinez Canillas wrote: >> Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when >> CONFIG_PM is unset") removed the implicit dependency

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Javier Martinez Canillas
Hello Marek, Thanks a lot for your feedback. On 01/19/2017 11:17 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-01-18 01:30, Javier Martinez Canillas wrote: >> Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when >> CONFIG_PM is unset") removed the implicit dependency

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Marek Szyprowski
Hi Javier, On 2017-01-18 01:30, Javier Martinez Canillas wrote: Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset") removed the implicit dependency that the driver had with CONFIG_PM, since it relied on the config option to be enabled. In order to work

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Marek Szyprowski
Hi Javier, On 2017-01-18 01:30, Javier Martinez Canillas wrote: Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset") removed the implicit dependency that the driver had with CONFIG_PM, since it relied on the config option to be enabled. In order to work

[PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-17 Thread Javier Martinez Canillas
Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset") removed the implicit dependency that the driver had with CONFIG_PM, since it relied on the config option to be enabled. In order to work with !CONFIG_PM, the GSC reset logic that happens in the runtime

[PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-17 Thread Javier Martinez Canillas
Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset") removed the implicit dependency that the driver had with CONFIG_PM, since it relied on the config option to be enabled. In order to work with !CONFIG_PM, the GSC reset logic that happens in the runtime