Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Mark Brown
On Fri, Jun 22, 2018 at 12:49:49PM +0200, Takashi Iwai wrote: > Hm, some of these users (e.g. drivers/usb/core/*) do call > of_node_put() properly at releasing, but some look leaking to me. > I don't think we have the common code in the driver core to release > dev->of_node, at least. > If any,

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Mark Brown
On Fri, Jun 22, 2018 at 12:49:49PM +0200, Takashi Iwai wrote: > Hm, some of these users (e.g. drivers/usb/core/*) do call > of_node_put() properly at releasing, but some look leaking to me. > I don't think we have the common code in the driver core to release > dev->of_node, at least. > If any,

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Takashi Iwai
On Fri, 22 Jun 2018 12:41:14 +0200, Robert Jarzmik wrote: > > Takashi Iwai writes: > > >> Special review query: review the "return of_node_get(node)", which > >> assumes that upon device removal, of_put_node(dev.of_node) will be > >> called... > > > > Is it really done automagically? I

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Takashi Iwai
On Fri, 22 Jun 2018 12:41:14 +0200, Robert Jarzmik wrote: > > Takashi Iwai writes: > > >> Special review query: review the "return of_node_get(node)", which > >> assumes that upon device removal, of_put_node(dev.of_node) will be > >> called... > > > > Is it really done automagically? I

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Robert Jarzmik
Takashi Iwai writes: >> Special review query: review the "return of_node_get(node)", which >> assumes that upon device removal, of_put_node(dev.of_node) will be >> called... > > Is it really done automagically? I couldn't spot it. Neither could I ... I based this on

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Robert Jarzmik
Takashi Iwai writes: >> Special review query: review the "return of_node_get(node)", which >> assumes that upon device removal, of_put_node(dev.of_node) will be >> called... > > Is it really done automagically? I couldn't spot it. Neither could I ... I based this on

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-21 Thread Takashi Iwai
On Thu, 21 Jun 2018 17:43:56 +0200, Robert Jarzmik wrote: > > Add a devicetree binding for codecs. This is especially useful if the > AC97 bitclk clock is provided by the codec, as it has to be described in > the devicetree description for the ac97 bus code to aquire it. > > Signed-off-by:

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-21 Thread Takashi Iwai
On Thu, 21 Jun 2018 17:43:56 +0200, Robert Jarzmik wrote: > > Add a devicetree binding for codecs. This is especially useful if the > AC97 bitclk clock is provided by the codec, as it has to be described in > the devicetree description for the ac97 bus code to aquire it. > > Signed-off-by:

[PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-21 Thread Robert Jarzmik
Add a devicetree binding for codecs. This is especially useful if the AC97 bitclk clock is provided by the codec, as it has to be described in the devicetree description for the ac97 bus code to aquire it. Signed-off-by: Robert Jarzmik --- Special review query: review the "return

[PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-21 Thread Robert Jarzmik
Add a devicetree binding for codecs. This is especially useful if the AC97 bitclk clock is provided by the codec, as it has to be described in the devicetree description for the ac97 bus code to aquire it. Signed-off-by: Robert Jarzmik --- Special review query: review the "return