Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-11 Thread Rusty Russell
Andrew Morton writes: > On Wed, 10 Oct 2012 16:34:37 -0700 > Jeremy Fitzhardinge wrote: > >> On 10/09/2012 06:14 PM, Andrew Morton wrote: >> > On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan >> > wrote: >> > >> + if (!pg) { >> + *alloc_error =

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-11 Thread Rusty Russell
Andrew Morton a...@linux-foundation.org writes: On Wed, 10 Oct 2012 16:34:37 -0700 Jeremy Fitzhardinge jer...@goop.org wrote: On 10/09/2012 06:14 PM, Andrew Morton wrote: On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan k...@microsoft.com wrote: + if (!pg) { +

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Andrew Morton
On Wed, 10 Oct 2012 16:34:37 -0700 Jeremy Fitzhardinge wrote: > On 10/09/2012 06:14 PM, Andrew Morton wrote: > > On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan wrote: > > > +if (!pg) { > +*alloc_error = true; > +

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Jeremy Fitzhardinge
On 10/09/2012 06:14 PM, Andrew Morton wrote: > On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan wrote: > + if (!pg) { + *alloc_error = true; + return i * alloc_unit; + } + + totalram_pages -= alloc_unit;

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Avi Kivity
On 10/09/2012 09:44 PM, Andrew Morton wrote: > On Sun, 7 Oct 2012 16:59:46 -0700 > "K. Y. Srinivasan" wrote: > >> Add the basic balloon driver. > > hm, how many balloon drivers does one kernel need? > > Although I see that the great majority of this code is hypervisor-specific. Much like

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Avi Kivity
On 10/09/2012 09:44 PM, Andrew Morton wrote: On Sun, 7 Oct 2012 16:59:46 -0700 K. Y. Srinivasan k...@microsoft.com wrote: Add the basic balloon driver. hm, how many balloon drivers does one kernel need? Although I see that the great majority of this code is hypervisor-specific. Much

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Jeremy Fitzhardinge
On 10/09/2012 06:14 PM, Andrew Morton wrote: On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan k...@microsoft.com wrote: + if (!pg) { + *alloc_error = true; + return i * alloc_unit; + } + + totalram_pages -= alloc_unit; Well, I'd

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Andrew Morton
On Wed, 10 Oct 2012 16:34:37 -0700 Jeremy Fitzhardinge jer...@goop.org wrote: On 10/09/2012 06:14 PM, Andrew Morton wrote: On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan k...@microsoft.com wrote: +if (!pg) { +*alloc_error = true; +

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread KY Srinivasan
a...@canonical.com; > a...@firstfloor.org > Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver > > On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan wrote: > > > > > + if (!pg) { > > > > + *alloc_error = tr

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread Andrew Morton
On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan wrote: > > > + if (!pg) { > > > + *alloc_error = true; > > > + return i * alloc_unit; > > > + } > > > + > > > + totalram_pages -= alloc_unit; > > > > Well, I'd consider totalram_pages to be

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread KY Srinivasan
a...@canonical.com; > a...@firstfloor.org > Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver > > On Sun, 7 Oct 2012 16:59:46 -0700 > "K. Y. Srinivasan" wrote: > > > Add the basic balloon driver. > > hm, how many balloon drivers does one kernel need

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread Andrew Morton
On Sun, 7 Oct 2012 16:59:46 -0700 "K. Y. Srinivasan" wrote: > Add the basic balloon driver. hm, how many balloon drivers does one kernel need? Although I see that the great majority of this code is hypervisor-specific. > Windows hosts dynamically manage the guest > memory allocation via a

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread Andrew Morton
On Sun, 7 Oct 2012 16:59:46 -0700 K. Y. Srinivasan k...@microsoft.com wrote: Add the basic balloon driver. hm, how many balloon drivers does one kernel need? Although I see that the great majority of this code is hypervisor-specific. Windows hosts dynamically manage the guest memory

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread KY Srinivasan
Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver On Sun, 7 Oct 2012 16:59:46 -0700 K. Y. Srinivasan k...@microsoft.com wrote: Add the basic balloon driver. hm, how many balloon drivers does one kernel need? Although I see that the great majority of this code

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread Andrew Morton
On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan k...@microsoft.com wrote: + if (!pg) { + *alloc_error = true; + return i * alloc_unit; + } + + totalram_pages -= alloc_unit; Well, I'd consider totalram_pages to be an

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-09 Thread KY Srinivasan
Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan k...@microsoft.com wrote: + if (!pg) { + *alloc_error = true; + return i * alloc_unit

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-08 Thread KY Srinivasan
nux-foundation.org; a...@firstfloor.org > Cc: KY Srinivasan > Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver > > "K. Y. Srinivasan" writes: > > +static int hot_add; > > + > > +module_param(hot_add, int, S_IRUGO); > > +MODULE_PARM_DESC(hot

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-08 Thread KY Srinivasan
; a...@firstfloor.org Cc: KY Srinivasan Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver K. Y. Srinivasan k...@microsoft.com writes: +static int hot_add; + +module_param(hot_add, int, S_IRUGO); +MODULE_PARM_DESC(hot_add, If set attempt memory hot_add); I think this should

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread Rusty Russell
"K. Y. Srinivasan" writes: > +static int hot_add; > + > +module_param(hot_add, int, S_IRUGO); > +MODULE_PARM_DESC(hot_add, "If set attempt memory hot_add"); I think this should be a 'bool', but I can't tell, since it's not used in this patch. Cheers, Rusty. -- To unsubscribe from this list:

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread KY Srinivasan
; a...@firstfloor.org > Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver > > On Sun, Oct 07, 2012 at 04:59:46PM -0700, K. Y. Srinivasan wrote: > > +config HYPERV_BALLOON > > + tristate "Microsoft Hyper-V Balloon driver" > > + depends on

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread Greg KH
On Sun, Oct 07, 2012 at 04:59:46PM -0700, K. Y. Srinivasan wrote: > +config HYPERV_BALLOON > + tristate "Microsoft Hyper-V Balloon driver" > + depends on HYPERV > + help > + Select this option to enable the Hyper-V Utilities. Your help text is wrong :( > --- /dev/null > +++

[PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread K. Y. Srinivasan
Add the basic balloon driver. Windows hosts dynamically manage the guest memory allocation via a combination memory hot add and ballooning. Memory hot add is used to grow the guest memory upto the maximum memory that can be allocatted to the guest. Ballooning is used to both shrink as well as

[PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread K. Y. Srinivasan
Add the basic balloon driver. Windows hosts dynamically manage the guest memory allocation via a combination memory hot add and ballooning. Memory hot add is used to grow the guest memory upto the maximum memory that can be allocatted to the guest. Ballooning is used to both shrink as well as

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread Greg KH
On Sun, Oct 07, 2012 at 04:59:46PM -0700, K. Y. Srinivasan wrote: +config HYPERV_BALLOON + tristate Microsoft Hyper-V Balloon driver + depends on HYPERV + help + Select this option to enable the Hyper-V Utilities. Your help text is wrong :( --- /dev/null +++

RE: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread KY Srinivasan
Subject: Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver On Sun, Oct 07, 2012 at 04:59:46PM -0700, K. Y. Srinivasan wrote: +config HYPERV_BALLOON + tristate Microsoft Hyper-V Balloon driver + depends on HYPERV + help + Select this option to enable the Hyper-V Utilities

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-07 Thread Rusty Russell
K. Y. Srinivasan k...@microsoft.com writes: +static int hot_add; + +module_param(hot_add, int, S_IRUGO); +MODULE_PARM_DESC(hot_add, If set attempt memory hot_add); I think this should be a 'bool', but I can't tell, since it's not used in this patch. Cheers, Rusty. -- To unsubscribe from this