Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-04 Thread Dmitry Torokhov
On December 4, 2018 11:09:32 AM PST, Tony Lindgren wrote: >Hi, > >* Dmitry Torokhov [181204 04:00]: >> Hi Tony, >> >> On Mon, Dec 03, 2018 at 03:12:51PM -0800, Tony Lindgren wrote: >> > >> > With PM enabled, I noticed that pressing a key on the droid4 >keyboard will >> > block deeper idle state

Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-04 Thread Tony Lindgren
Hi, * Dmitry Torokhov [181204 04:00]: > Hi Tony, > > On Mon, Dec 03, 2018 at 03:12:51PM -0800, Tony Lindgren wrote: > > > > With PM enabled, I noticed that pressing a key on the droid4 keyboard will > > block deeper idle states for the SoC. Looks like we can fix this by > > managing the idle re

Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-03 Thread Dmitry Torokhov
Hi Tony, On Mon, Dec 03, 2018 at 03:12:51PM -0800, Tony Lindgren wrote: > > With PM enabled, I noticed that pressing a key on the droid4 keyboard will > block deeper idle states for the SoC. Looks like we can fix this by > managing the idle register to gether with the interrupt similar to what >

Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-03 Thread Tony Lindgren
Hi, * Dmitry Torokhov [181203 19:24]: > On Sun, Dec 02, 2018 at 05:29:33PM -0800, Tony Lindgren wrote: ... > > Note that we now must also disable OMAP4_DEF_IRQENABLE_LONGKEY as it > > should not be used together with debounce according to the TRM. The above statement is no longer true, it's left

Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-03 Thread Dmitry Torokhov
On Sun, Dec 02, 2018 at 05:29:33PM -0800, Tony Lindgren wrote: > With PM enabled, I noticed that pressing a key on the droid4 keyboard will > block deeper idle states for the SoC. Looks like we can fix this by > managing the idle register to gether with the interrupt similar to what > we already do

[PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-02 Thread Tony Lindgren
With PM enabled, I noticed that pressing a key on the droid4 keyboard will block deeper idle states for the SoC. Looks like we can fix this by managing the idle register to gether with the interrupt similar to what we already do for the GPIO controller. Note that we now must also disable OMAP4_DEF