Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-05 Thread Greg KH
On Tue, Dec 04, 2012 at 08:43:18PM +, Arnd Bergmann wrote: > On Tuesday 04 December 2012, Eli Billauer wrote: > > I'm currently writing some documentation which will cover the API and > > also help reading the code, I hope. It takes some time... > > > > Until it's done, let's look at a usage

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-05 Thread Pavel Machek
Hi! > >Agreed. If I understand you correctly though, your approach is specific > >to a particular hardware implementation (Zynq) on the user interface layer, > >which I think is exactly what we should avoid. Obviously, there is > >always a driver involved that is specific to the IP block you load

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-05 Thread Pavel Machek
Hi! Agreed. If I understand you correctly though, your approach is specific to a particular hardware implementation (Zynq) on the user interface layer, which I think is exactly what we should avoid. Obviously, there is always a driver involved that is specific to the IP block you load into

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-05 Thread Greg KH
On Tue, Dec 04, 2012 at 08:43:18PM +, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: I'm currently writing some documentation which will cover the API and also help reading the code, I hope. It takes some time... Until it's done, let's look at a usage example:

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Eli Billauer
On 12/05/2012 01:05 AM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: On 12/04/2012 10:43 PM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: It's also a bit confusing because it doesn't appear to be a "bus" in the Linux sense of being

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Eli Billauer wrote: > On 12/04/2012 10:43 PM, Arnd Bergmann wrote: > > On Tuesday 04 December 2012, Eli Billauer wrote: > > It's also a bit confusing because it doesn't appear > > to be a "bus" in the Linux sense of being something that provides > > an abstract

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Eli Billauer
On 12/04/2012 10:43 PM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: I'm currently writing some documentation which will cover the API and also help reading the code, I hope. It takes some time... Until it's done, let's look at a usage example: Suppose that the

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Philip Balister wrote: > On 12/01/2012 12:48 PM, Arnd Bergmann wrote: > > On Saturday 01 December 2012, Philip Balister wrote: > >> On 11/30/2012 09:36 AM, Greg KH wrote: > >>> Yes, I know of at least one more device other than the ones listed above > >>> that wants

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Eli Billauer wrote: > I'm currently writing some documentation which will cover the API and > also help reading the code, I hope. It takes some time... > > Until it's done, let's look at a usage example: Suppose that the FPGA's > application is to receive a

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Philip Balister
On 12/01/2012 12:48 PM, Arnd Bergmann wrote: On Saturday 01 December 2012, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: Yes, I know of at least one more device other than the ones listed above that wants this type of functionality as well, so defining it in a standard

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Eli Billauer
On 12/04/2012 05:41 AM, Greg KH wrote: On Sun, Dec 02, 2012 at 07:26:27PM +0200, Eli Billauer wrote: On 11/30/2012 06:32 PM, Greg KH wrote: >>+static struct class *xillybus_class; >Why not just use the misc interface instead of your own class?

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Eli Billauer
On 12/04/2012 05:41 AM, Greg KH wrote: On Sun, Dec 02, 2012 at 07:26:27PM +0200, Eli Billauer wrote: On 11/30/2012 06:32 PM, Greg KH wrote: +static struct class *xillybus_class; Why not just use the misc interface instead of your own class? When

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Philip Balister
On 12/01/2012 12:48 PM, Arnd Bergmann wrote: On Saturday 01 December 2012, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: Yes, I know of at least one more device other than the ones listed above that wants this type of functionality as well, so defining it in a standard

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Eli Billauer wrote: I'm currently writing some documentation which will cover the API and also help reading the code, I hope. It takes some time... Until it's done, let's look at a usage example: Suppose that the FPGA's application is to receive a high-speed

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Philip Balister wrote: On 12/01/2012 12:48 PM, Arnd Bergmann wrote: On Saturday 01 December 2012, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: Yes, I know of at least one more device other than the ones listed above that wants this type of

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Eli Billauer
On 12/04/2012 10:43 PM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: I'm currently writing some documentation which will cover the API and also help reading the code, I hope. It takes some time... Until it's done, let's look at a usage example: Suppose that the

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2012, Eli Billauer wrote: On 12/04/2012 10:43 PM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: It's also a bit confusing because it doesn't appear to be a bus in the Linux sense of being something that provides an abstract interface

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-04 Thread Eli Billauer
On 12/05/2012 01:05 AM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: On 12/04/2012 10:43 PM, Arnd Bergmann wrote: On Tuesday 04 December 2012, Eli Billauer wrote: It's also a bit confusing because it doesn't appear to be a bus in the Linux sense of being

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-03 Thread Greg KH
On Sun, Dec 02, 2012 at 07:26:27PM +0200, Eli Billauer wrote: > On 11/30/2012 06:32 PM, Greg KH wrote: > > >>+static struct class *xillybus_class; > >Why not just use the misc interface instead of your own class? > >>> When Xillybus is used, the whole system's mission is usually around

RE: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-03 Thread John Linn
t; Subject: Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA > (programmable logic) > > On Saturday 01 December 2012, Philip Balister wrote: > > On 11/30/2012 09:36 AM, Greg KH wrote: > > > Yes, I know of at least one more device other than the ones listed a

RE: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-03 Thread John Linn
driver: Xillybus generic interface for FPGA (programmable logic) On Saturday 01 December 2012, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: Yes, I know of at least one more device other than the ones listed above that wants this type of functionality as well, so

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-03 Thread Greg KH
On Sun, Dec 02, 2012 at 07:26:27PM +0200, Eli Billauer wrote: On 11/30/2012 06:32 PM, Greg KH wrote: +static struct class *xillybus_class; Why not just use the misc interface instead of your own class? When Xillybus is used, the whole system's mission is usually around it (e.g. it's a

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-02 Thread Eli Billauer
On 11/30/2012 06:32 PM, Greg KH wrote: > >>+static struct class *xillybus_class; > >Why not just use the misc interface instead of your own class? > When Xillybus is used, the whole system's mission is usually around > it (e.g. it's a computer doing data acquisition

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-02 Thread Eli Billauer
On 12/01/2012 10:48 PM, Arnd Bergmann wrote: I agree that is a concern, but for now, I'm mostly worried about the kernel-to-user interface. If we can agree on a driver interface that works for Xillybus as well as any of the others we know about, we can start using that as the generic kernel FPGA

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-02 Thread Eli Billauer
On 12/01/2012 10:48 PM, Arnd Bergmann wrote: I agree that is a concern, but for now, I'm mostly worried about the kernel-to-user interface. If we can agree on a driver interface that works for Xillybus as well as any of the others we know about, we can start using that as the generic kernel FPGA

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-02 Thread Eli Billauer
On 11/30/2012 06:32 PM, Greg KH wrote: +static struct class *xillybus_class; Why not just use the misc interface instead of your own class? When Xillybus is used, the whole system's mission is usually around it (e.g. it's a computer doing data acquisition through the

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Arnd Bergmann
On Saturday 01 December 2012, Philip Balister wrote: > On 11/30/2012 09:36 AM, Greg KH wrote: > > Yes, I know of at least one more device other than the ones listed above > > that wants this type of functionality as well, so defining it in a > > standard user/kernel api manner would be very good

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Josh Cartwright
On Sat, Dec 01, 2012 at 11:30:55AM -0800, Philip Balister wrote: > On 12/01/2012 08:56 AM, Greg KH wrote: > >On Fri, Nov 30, 2012 at 07:19:16PM -0800, Philip Balister wrote: [..] > > > >>I've been engaged in design discussions today with my customer. Our > >>target is the Xilinx Zynq hardware. The

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Philip Balister
On 12/01/2012 08:56 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 07:19:16PM -0800, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Greg KH
On Sat, Dec 01, 2012 at 08:56:12AM -0800, Greg KH wrote: > So, in the grand tradition of, "The first one there wins", why not base > it all off of your driver, and how that works, and we can go from there :) Oops, sorry s/your/Eli's/, my confusion. greg k-h -- To unsubscribe from this list: send

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Greg KH
On Fri, Nov 30, 2012 at 07:19:16PM -0800, Philip Balister wrote: > On 11/30/2012 09:36 AM, Greg KH wrote: > >On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: > >>On Wednesday 28 November 2012, Eli Billauer wrote: > >>> > >>>Xillybus is a general-purpose framework for communication

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Greg KH
On Fri, Nov 30, 2012 at 07:19:16PM -0800, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose framework for communication between

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Greg KH
On Sat, Dec 01, 2012 at 08:56:12AM -0800, Greg KH wrote: So, in the grand tradition of, The first one there wins, why not base it all off of your driver, and how that works, and we can go from there :) Oops, sorry s/your/Eli's/, my confusion. greg k-h -- To unsubscribe from this list: send the

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Philip Balister
On 12/01/2012 08:56 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 07:19:16PM -0800, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Josh Cartwright
On Sat, Dec 01, 2012 at 11:30:55AM -0800, Philip Balister wrote: On 12/01/2012 08:56 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 07:19:16PM -0800, Philip Balister wrote: [..] I've been engaged in design discussions today with my customer. Our target is the Xilinx Zynq hardware. The first pass

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-12-01 Thread Arnd Bergmann
On Saturday 01 December 2012, Philip Balister wrote: On 11/30/2012 09:36 AM, Greg KH wrote: Yes, I know of at least one more device other than the ones listed above that wants this type of functionality as well, so defining it in a standard user/kernel api manner would be very good to do.

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Philip Balister
On 11/30/2012 09:36 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose framework for communication between programmable logic (FPGA) and a host. It provides a simple connection

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: > On Wednesday 28 November 2012, Eli Billauer wrote: > > > > Xillybus is a general-purpose framework for communication between > > programmable > > logic (FPGA) and a host. It provides a simple connection between hardware > > FIFOs

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Arnd Bergmann
On Friday 30 November 2012, Eli Billauer wrote: > The problem is if the page size smaller than 4kB. The buffers > allocated by the driver must not cross a 4kB boundary, and it's assumed > that anything returned by __get_free_pages() is 4 kB-aligned. Otherwise > the FPGA will generate illegal

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Arnd Bergmann
On Wednesday 28 November 2012, Eli Billauer wrote: > > Xillybus is a general-purpose framework for communication between programmable > logic (FPGA) and a host. It provides a simple connection between hardware > FIFOs > in the FPGA and their respective device files on the host. The user space >

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Eli Billauer
On 11/30/2012 06:32 PM, Greg KH wrote: As we need to review the user/kernel api here, putting the docs as part of the driver submission is a good idea :) I didn't know, nor do I trust, that a random web site would have the correct documentation for a kernel driver. OK. I'll add a file in

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 04:50:39PM +0200, Eli Billauer wrote: > Thanks for the remarks. > > I'm sending the updated patches in a minute. Basically, I divided > the module into three (one core, one for PCIe and one for OF) and > made several corrections. > > On 11/28/2012 06:57 PM, Greg KH wrote:

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Eli Billauer
Thanks for the remarks. I'm sending the updated patches in a minute. Basically, I divided the module into three (one core, one for PCIe and one for OF) and made several corrections. On 11/28/2012 06:57 PM, Greg KH wrote: What is the user/kernel interface for this driver? Is it documented

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Eli Billauer
Thanks for the remarks. I'm sending the updated patches in a minute. Basically, I divided the module into three (one core, one for PCIe and one for OF) and made several corrections. On 11/28/2012 06:57 PM, Greg KH wrote: What is the user/kernel interface for this driver? Is it documented

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 04:50:39PM +0200, Eli Billauer wrote: Thanks for the remarks. I'm sending the updated patches in a minute. Basically, I divided the module into three (one core, one for PCIe and one for OF) and made several corrections. On 11/28/2012 06:57 PM, Greg KH wrote: What

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Eli Billauer
On 11/30/2012 06:32 PM, Greg KH wrote: As we need to review the user/kernel api here, putting the docs as part of the driver submission is a good idea :) I didn't know, nor do I trust, that a random web site would have the correct documentation for a kernel driver. OK. I'll add a file in

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Arnd Bergmann
On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose framework for communication between programmable logic (FPGA) and a host. It provides a simple connection between hardware FIFOs in the FPGA and their respective device files on the host. The user space

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Arnd Bergmann
On Friday 30 November 2012, Eli Billauer wrote: The problem is if the page size smaller than 4kB. The buffers allocated by the driver must not cross a 4kB boundary, and it's assumed that anything returned by __get_free_pages() is 4 kB-aligned. Otherwise the FPGA will generate illegal PCIe

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Greg KH
On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose framework for communication between programmable logic (FPGA) and a host. It provides a simple connection between hardware FIFOs in the

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-30 Thread Philip Balister
On 11/30/2012 09:36 AM, Greg KH wrote: On Fri, Nov 30, 2012 at 05:28:47PM +, Arnd Bergmann wrote: On Wednesday 28 November 2012, Eli Billauer wrote: Xillybus is a general-purpose framework for communication between programmable logic (FPGA) and a host. It provides a simple connection

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-28 Thread Greg KH
On Wed, Nov 28, 2012 at 05:41:33PM +0200, Eli Billauer wrote: > Xillybus is a general-purpose framework for communication between programmable > logic (FPGA) and a host. It provides a simple connection between hardware > FIFOs > in the FPGA and their respective device files on the host. The user

Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

2012-11-28 Thread Greg KH
On Wed, Nov 28, 2012 at 05:41:33PM +0200, Eli Billauer wrote: Xillybus is a general-purpose framework for communication between programmable logic (FPGA) and a host. It provides a simple connection between hardware FIFOs in the FPGA and their respective device files on the host. The user