Re: [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-05-25 Thread Barry Song
2014-05-09 19:57 GMT+08:00 Linus Walleij : > On Thu, May 1, 2014 at 2:40 PM, Barry Song wrote: >> 2014-04-24 5:16 GMT+08:00 Linus Walleij : > >>> Instead of referring to a global static variable for the sgpio >>> locking, use the state container to contain the lock. >>> >>> Signed-off-by: Linus

Re: [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-05-25 Thread Barry Song
2014-05-09 19:57 GMT+08:00 Linus Walleij linus.wall...@linaro.org: On Thu, May 1, 2014 at 2:40 PM, Barry Song bao...@kernel.org wrote: 2014-04-24 5:16 GMT+08:00 Linus Walleij linus.wall...@linaro.org: Instead of referring to a global static variable for the sgpio locking, use the state

Re: [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-05-09 Thread Linus Walleij
On Thu, May 1, 2014 at 2:40 PM, Barry Song wrote: > 2014-04-24 5:16 GMT+08:00 Linus Walleij : >> Instead of referring to a global static variable for the sgpio >> locking, use the state container to contain the lock. >> >> Signed-off-by: Linus Walleij > > hi Linus, thanks! this looks very good

Re: [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-05-09 Thread Linus Walleij
On Thu, May 1, 2014 at 2:40 PM, Barry Song bao...@kernel.org wrote: 2014-04-24 5:16 GMT+08:00 Linus Walleij linus.wall...@linaro.org: Instead of referring to a global static variable for the sgpio locking, use the state container to contain the lock. Signed-off-by: Linus Walleij

Re: [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-05-01 Thread Barry Song
2014-04-24 5:16 GMT+08:00 Linus Walleij : > Instead of referring to a global static variable for the sgpio > locking, use the state container to contain the lock. > > Signed-off-by: Linus Walleij hi Linus, thanks! this looks very good only if we fix the gpiochip_add_pin_range() failure in patch

Re: [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-05-01 Thread Barry Song
2014-04-24 5:16 GMT+08:00 Linus Walleij linus.wall...@linaro.org: Instead of referring to a global static variable for the sgpio locking, use the state container to contain the lock. Signed-off-by: Linus Walleij linus.wall...@linaro.org hi Linus, thanks! this looks very good only if we fix

[PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-04-23 Thread Linus Walleij
Instead of referring to a global static variable for the sgpio locking, use the state container to contain the lock. Signed-off-by: Linus Walleij --- drivers/pinctrl/sirf/pinctrl-sirf.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into state container

2014-04-23 Thread Linus Walleij
Instead of referring to a global static variable for the sgpio locking, use the state container to contain the lock. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/pinctrl/sirf/pinctrl-sirf.c | 24 1 file changed, 12 insertions(+), 12 deletions(-)