Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

2016-07-11 Thread Gregory CLEMENT
Hi Ben, On mar., juin 21 2016, Arnd Bergmann wrote: > On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: >> >> -struct syscore_ops mvebu_mbus_syscore_ops = { >> +static struct syscore_ops mvebu_mbus_syscore_ops = { >> .suspend= mvebu_mbus_suspend, >>

Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

2016-07-11 Thread Gregory CLEMENT
Hi Ben, On mar., juin 21 2016, Arnd Bergmann wrote: > On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: >> >> -struct syscore_ops mvebu_mbus_syscore_ops = { >> +static struct syscore_ops mvebu_mbus_syscore_ops = { >> .suspend= mvebu_mbus_suspend, >> .resume

[PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

2016-06-21 Thread Ben Dooks
Make mvebu_mbus_syscore_ops static as it does not get used or declared outside mvebu-mbus.c to fix the following sparse warning: linux/drivers/bus/mvebu-mbus.c:1092:20: warning: symbol 'mvebu_mbus_syscore_ops' was not declared. Should it be static? Signed-off-by: Ben Dooks

[PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

2016-06-21 Thread Ben Dooks
Make mvebu_mbus_syscore_ops static as it does not get used or declared outside mvebu-mbus.c to fix the following sparse warning: linux/drivers/bus/mvebu-mbus.c:1092:20: warning: symbol 'mvebu_mbus_syscore_ops' was not declared. Should it be static? Signed-off-by: Ben Dooks --- Cc: Jason Cooper

Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

2016-06-21 Thread Arnd Bergmann
On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: > > -struct syscore_ops mvebu_mbus_syscore_ops = { > +static struct syscore_ops mvebu_mbus_syscore_ops = { > .suspend= mvebu_mbus_suspend, > .resume = mvebu_mbus_resume, > }; > Looks good, but I

Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

2016-06-21 Thread Arnd Bergmann
On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: > > -struct syscore_ops mvebu_mbus_syscore_ops = { > +static struct syscore_ops mvebu_mbus_syscore_ops = { > .suspend= mvebu_mbus_suspend, > .resume = mvebu_mbus_resume, > }; > Looks good, but I