Re: [PATCH 2/2] clk: bcm2835: Add PWM clock support

2015-11-05 Thread Remi Pommarel
On Wed, Nov 04, 2015 at 06:17:38PM -0800, Eric Anholt wrote: > Remi Pommarel writes: > > > Register the pwm clock for bcm2835. > > This patch also adds the ability to set a clock default rate. > > I don't think we should be setting a default clock rate. That should be > up to the thing that

Re: [PATCH 2/2] clk: bcm2835: Add PWM clock support

2015-11-05 Thread Remi Pommarel
On Wed, Nov 04, 2015 at 06:17:38PM -0800, Eric Anholt wrote: > Remi Pommarel writes: > > > Register the pwm clock for bcm2835. > > This patch also adds the ability to set a clock default rate. > > I don't think we should be setting a default clock rate. That should be > up

Re: [PATCH 2/2] clk: bcm2835: Add PWM clock support

2015-11-04 Thread Eric Anholt
Remi Pommarel writes: > Register the pwm clock for bcm2835. > This patch also adds the ability to set a clock default rate. I don't think we should be setting a default clock rate. That should be up to the thing that uses the clock. If we need a standard rate set on all Raspberry Pis, other

[PATCH 2/2] clk: bcm2835: Add PWM clock support

2015-11-04 Thread Remi Pommarel
Register the pwm clock for bcm2835. This patch also adds the ability to set a clock default rate. Signed-off-by: Remi Pommarel --- arch/arm/boot/dts/bcm2835.dtsi | 8 drivers/clk/bcm/clk-bcm2835.c | 28 +++- include/dt-bindings/clock/bcm2835.h | 3

[PATCH 2/2] clk: bcm2835: Add PWM clock support

2015-11-04 Thread Remi Pommarel
Register the pwm clock for bcm2835. This patch also adds the ability to set a clock default rate. Signed-off-by: Remi Pommarel --- arch/arm/boot/dts/bcm2835.dtsi | 8 drivers/clk/bcm/clk-bcm2835.c | 28 +++-

Re: [PATCH 2/2] clk: bcm2835: Add PWM clock support

2015-11-04 Thread Eric Anholt
Remi Pommarel writes: > Register the pwm clock for bcm2835. > This patch also adds the ability to set a clock default rate. I don't think we should be setting a default clock rate. That should be up to the thing that uses the clock. If we need a standard rate set on all