Re: [PATCH 2/2] eeprom: ee1004: Deal with nack on page selection

2019-05-06 Thread Jean Delvare
On Mon, 6 May 2019 17:03:20 +0300, Jarkko Nikula wrote: > On 5/6/19 4:16 PM, Jean Delvare wrote: > > Some EE1004 implementations will not properly ack page selection > > commands. They still set the page correctly, so there is no actual > > error. Deal with this case gracefully by checking the

Re: [PATCH 2/2] eeprom: ee1004: Deal with nack on page selection

2019-05-06 Thread Dreamcat4
Don't mind either way, please do as you see fit On Mon, May 6, 2019 at 3:04 PM Jarkko Nikula wrote: > > On 5/6/19 4:16 PM, Jean Delvare wrote: > > Some EE1004 implementations will not properly ack page selection > > commands. They still set the page correctly, so there is no actual > > error.

Re: [PATCH 2/2] eeprom: ee1004: Deal with nack on page selection

2019-05-06 Thread Jarkko Nikula
On 5/6/19 4:16 PM, Jean Delvare wrote: Some EE1004 implementations will not properly ack page selection commands. They still set the page correctly, so there is no actual error. Deal with this case gracefully by checking the currently selected page after we receive a nack. If the page is set

[PATCH 2/2] eeprom: ee1004: Deal with nack on page selection

2019-05-06 Thread Jean Delvare
Some EE1004 implementations will not properly ack page selection commands. They still set the page correctly, so there is no actual error. Deal with this case gracefully by checking the currently selected page after we receive a nack. If the page is set right then we can continue. Signed-off-by: