Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-21 Thread Hans de Goede
Hi, On 20-02-19 21:28, Yauhen Kharuzhy wrote: On Wed, Feb 20, 2019 at 05:42:28PM +0100, Hans de Goede wrote: The input-current-limit only specifies how much current the charger may draw from the micro-usb for both supplying the laptop as well as for charging the battery combined. You can

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-20 Thread Yauhen Kharuzhy
On Wed, Feb 20, 2019 at 05:42:28PM +0100, Hans de Goede wrote: > > > The input-current-limit only specifies how much current the charger may > > > draw from the micro-usb for both supplying the laptop as well as for > > > charging the battery combined. You can safely set this as high as > > > the

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-20 Thread Hans de Goede
Hi, On 2/19/19 9:20 PM, Yauhen Kharuzhy wrote: On Tue, Feb 19, 2019 at 02:39:55PM +0100, Hans de Goede wrote: I also wonder if you've considered just disabling the extcon driver for the PMIC leaving it in automatic mode. Unlike the GPD win / pocket with their Type-C connector, your device

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-19 Thread Yauhen Kharuzhy
On Tue, Feb 19, 2019 at 02:39:55PM +0100, Hans de Goede wrote: > > > I also wonder if you've considered just disabling the extcon driver > > > for the PMIC leaving it in automatic mode. Unlike the GPD win / pocket > > > with their Type-C connector, your device seems to actually be using > > > the

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-19 Thread Hans de Goede
Hi, On 18-02-19 16:07, Yauhen Kharuzhy wrote: пн, 18 февр. 2019 г. в 12:24, Hans de Goede : So, I propose: 1) save initial value of CHGDIS register for restoring it at driver remove (because the extcon-intel-cht-wc driver restores HW control in cht_wc_extcon_remove()). 2) at driver start,

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-18 Thread Yauhen Kharuzhy
пн, 18 февр. 2019 г. в 12:24, Hans de Goede : > > Hi, > > On 17-02-19 22:52, Yauhen Kharuzhy wrote: > > On Fri, Feb 15, 2019 at 09:32:50AM +0300, Yauhen Kharuzhy wrote: > >> On Thu, Feb 14, 2019 at 05:31:48PM +0100, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 10-02-19 21:36, Yauhen Kharuzhy

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-18 Thread Hans de Goede
Hi, On 17-02-19 22:52, Yauhen Kharuzhy wrote: On Fri, Feb 15, 2019 at 09:32:50AM +0300, Yauhen Kharuzhy wrote: On Thu, Feb 14, 2019 at 05:31:48PM +0100, Hans de Goede wrote: Hi, On 10-02-19 21:36, Yauhen Kharuzhy wrote: In some configuration external charge "#charge enable" signal is

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-17 Thread Yauhen Kharuzhy
On Fri, Feb 15, 2019 at 09:32:50AM +0300, Yauhen Kharuzhy wrote: > On Thu, Feb 14, 2019 at 05:31:48PM +0100, Hans de Goede wrote: > > Hi, > > > > On 10-02-19 21:36, Yauhen Kharuzhy wrote: > > > In some configuration external charge "#charge enable" signal is > > > connected to PMIC. Enable it at

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-14 Thread Yauhen Kharuzhy
On Thu, Feb 14, 2019 at 05:31:48PM +0100, Hans de Goede wrote: > Hi, > > On 10-02-19 21:36, Yauhen Kharuzhy wrote: > > In some configuration external charge "#charge enable" signal is > > connected to PMIC. Enable it at device probing to allow charging. > > > > Tested at Lenovo Yoga Book

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-14 Thread Hans de Goede
Hi, On 10-02-19 21:36, Yauhen Kharuzhy wrote: In some configuration external charge "#charge enable" signal is connected to PMIC. Enable it at device probing to allow charging. Tested at Lenovo Yoga Book (YB1-X91L). Signed-off-by: Yauhen Kharuzhy --- drivers/extcon/extcon-intel-cht-wc.c |

[PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-10 Thread Yauhen Kharuzhy
In some configuration external charge "#charge enable" signal is connected to PMIC. Enable it at device probing to allow charging. Tested at Lenovo Yoga Book (YB1-X91L). Signed-off-by: Yauhen Kharuzhy --- drivers/extcon/extcon-intel-cht-wc.c | 33 1 file changed,