Re: [PATCH 2/2] fentry: x86, cleanup function_hook uses

2014-04-29 Thread H. Peter Anvin
On 04/29/2014 12:24 AM, Jiri Slaby wrote: > Let's define fentry_hook depending on CC_USING_FENTRY and use that > macro all over. This saves some #ifdef's here and there. Any reason not to use the existing macro name function_hook? (Valid reasons include "too generic". However, please motivate

[PATCH 2/2] fentry: x86, cleanup function_hook uses

2014-04-29 Thread Jiri Slaby
Let's define fentry_hook depending on CC_USING_FENTRY and use that macro all over. This saves some #ifdef's here and there. Signed-off-by: Jiri Slaby Cc: Thomas Gleixner Cc: "H. Peter Anvin" Cc: Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar --- arch/x86/include/asm/fentry.h

[PATCH 2/2] fentry: x86, cleanup function_hook uses

2014-04-29 Thread Jiri Slaby
Let's define fentry_hook depending on CC_USING_FENTRY and use that macro all over. This saves some #ifdef's here and there. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Thomas Gleixner t...@linutronix.de Cc: H. Peter Anvin h...@zytor.com Cc: x...@kernel.org Cc: Steven Rostedt rost...@goodmis.org

Re: [PATCH 2/2] fentry: x86, cleanup function_hook uses

2014-04-29 Thread H. Peter Anvin
On 04/29/2014 12:24 AM, Jiri Slaby wrote: Let's define fentry_hook depending on CC_USING_FENTRY and use that macro all over. This saves some #ifdef's here and there. Any reason not to use the existing macro name function_hook? (Valid reasons include too generic. However, please motivate in