Re: [PATCH 2/2] fs/epoll: deal with wait_queue only once

2018-11-14 Thread Davidlohr Bueso
On Wed, 14 Nov 2018, Andrew Morton wrote: Why was this moved to before the ep_reset_busy_poll_napi_id() call? That movement placed the code ahead of the block comment which serves to explain its function. Yikes, that was a brain fart. This? Which also fixes that comment and reflows it to

Re: [PATCH 2/2] fs/epoll: deal with wait_queue only once

2018-11-14 Thread Andrew Morton
On Wed, 14 Nov 2018 10:25:32 -0800 Davidlohr Bueso wrote: > There is no reason why we rearm the waitiqueue upon every > fetch_events retry (for when events are found yet send_events() > fails). If nothing else, this saves four lock operations per > retry, and furthermore reduces the scope of the

[PATCH 2/2] fs/epoll: deal with wait_queue only once

2018-11-14 Thread Davidlohr Bueso
There is no reason why we rearm the waitiqueue upon every fetch_events retry (for when events are found yet send_events() fails). If nothing else, this saves four lock operations per retry, and furthermore reduces the scope of the lock even further. Signed-off-by: Davidlohr Bueso --- fs/eventpol