Re: [PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

2018-04-18 Thread Andrew Morton
On Tue, 17 Apr 2018 15:05:33 +0800 Chengguang Xu wrote: > When specifying nls option multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > --- a/fs/hfsplus/options.c > +++

Re: [PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

2018-04-18 Thread Andrew Morton
On Tue, 17 Apr 2018 15:05:33 +0800 Chengguang Xu wrote: > When specifying nls option multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > --- a/fs/hfsplus/options.c > +++

Re: [PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

2018-04-18 Thread Viacheslav Dubeyko
On Tue, 2018-04-17 at 15:05 +0800, Chengguang Xu wrote: > When specifying nls option multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > Signed-off-by: Chengguang Xu Looks

Re: [PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

2018-04-18 Thread Viacheslav Dubeyko
On Tue, 2018-04-17 at 15:05 +0800, Chengguang Xu wrote: > When specifying nls option multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > Signed-off-by: Chengguang Xu Looks good.

[PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

2018-04-17 Thread Chengguang Xu
When specifying nls option multiple times in a mount, current option parsing will cause inaccurate refcount of nls module. Hence, call unload_nls for previous one in this case. Signed-off-by: Chengguang Xu --- fs/hfsplus/options.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

2018-04-17 Thread Chengguang Xu
When specifying nls option multiple times in a mount, current option parsing will cause inaccurate refcount of nls module. Hence, call unload_nls for previous one in this case. Signed-off-by: Chengguang Xu --- fs/hfsplus/options.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff