Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2019-01-10 Thread Yauhen Kharuzhy
On Thu, Jan 10, 2019 at 01:32:36PM +, Charles Keepax wrote: > On Thu, Jan 10, 2019 at 12:47:56AM +0300, Yauhen Kharuzhy wrote: > > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > > > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > > > i2c_device_re

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2019-01-10 Thread Charles Keepax
On Thu, Jan 10, 2019 at 12:47:56AM +0300, Yauhen Kharuzhy wrote: > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > > i2c_device_remove does not clear this. When rebinding an I2C device, > > whos IRQ pro

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2019-01-09 Thread Yauhen Kharuzhy
On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > i2c_device_remove does not clear this. When rebinding an I2C device, > whos IRQ provider has also been rebound this means that an IRQ mapping > will never b

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-31 Thread Wolfram Sang
On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > i2c_device_remove does not clear this. When rebinding an I2C device, > whos IRQ provider has also been rebound this means that an IRQ mapping > will never b

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-31 Thread Wolfram Sang
> It's a bit of a long chain and fairly tricky to say exactly when > the bug was introduced but I think this is probably the closest > match: > > Fixes: 2fd36c552649 ("i2c: core: Map OF IRQ at probe time") Thank you for checking! Then, I'll just leave it and cc stable so it can be applied as lon

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-31 Thread Charles Keepax
On Tue, Oct 30, 2018 at 02:55:50PM +, Wolfram Sang wrote: > > > No, that's fine. Now I get this, and I totally agree with the approach: > > > > Reviewed-by: Benjamin Tissoires > > Thanks! If one of you could provide me with a Fixes tag (for this. or > both patches?), that would be most help

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-30 Thread Wolfram Sang
> No, that's fine. Now I get this, and I totally agree with the approach: > > Reviewed-by: Benjamin Tissoires Thanks! If one of you could provide me with a Fixes tag (for this. or both patches?), that would be most helpful. signature.asc Description: PGP signature

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-30 Thread Benjamin Tissoires
On Tue, Oct 30, 2018 at 12:51 PM Charles Keepax wrote: > > On Mon, Oct 29, 2018 at 11:15:47AM +0100, Benjamin Tissoires wrote: > > On Sun, Oct 28, 2018 at 11:31 PM Wolfram Sang wrote: > > > > > > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > > > > The IRQ will be mapped in i2c

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-30 Thread Charles Keepax
On Mon, Oct 29, 2018 at 11:15:47AM +0100, Benjamin Tissoires wrote: > On Sun, Oct 28, 2018 at 11:31 PM Wolfram Sang wrote: > > > > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > > > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > > > i2c_device_remov

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-29 Thread Benjamin Tissoires
On Sun, Oct 28, 2018 at 11:31 PM Wolfram Sang wrote: > > On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > > i2c_device_remove does not clear this. When rebinding an I2C device, > > whos IRQ provider has

Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-28 Thread Wolfram Sang
On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > i2c_device_remove does not clear this. When rebinding an I2C device, > whos IRQ provider has also been rebound this means that an IRQ mapping > will never b

[PATCH 2/2] i2c: Clear client->irq in i2c_device_remove

2018-10-19 Thread Charles Keepax
The IRQ will be mapped in i2c_device_probe only if client->irq is zero and i2c_device_remove does not clear this. When rebinding an I2C device, whos IRQ provider has also been rebound this means that an IRQ mapping will never be created, causing the I2C device to fail to acquire its IRQ. Fix this i