Re: [PATCH 2/2] i2c: imx: remove id_table entry

2020-10-26 Thread Greg Ungerer 



On 24/10/20 1:28 am, Krzysztof Kozlowski wrote:

On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng@nxp.com wrote:

From: Peng Fan 

The legacy platform device code has been removed under arch/arm/mach-imx,
so we no need id_table entry here.


Cc: Greg, Geert, Angelo,

Aren't you breaking Coldfire platforms?


Well spotted Krzysztof. It is used by quite a few of the ColdFire parts.

Regards
Greg



Best regards,
Krzysztof



Signed-off-by: Peng Fan 
---
  drivers/i2c/busses/i2c-imx.c | 14 --
  1 file changed, 14 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index ba9d639223ec..7ea36a78abb0 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
  
  };
  
-static const struct platform_device_id imx_i2c_devtype[] = {

-   {
-   .name = "imx1-i2c",
-   .driver_data = (kernel_ulong_t)_i2c_hwdata,
-   }, {

RE: [PATCH 2/2] i2c: imx: remove id_table entry

2020-10-25 Thread Peng Fan 
> Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
> 
> On Sat, Oct 24, 2020 at 07:47:13AM +, Peng Fan wrote:
> > > Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
> > >
> > > On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng@nxp.com wrote:
> > > > From: Peng Fan 
> > > >
> > > > The legacy platform device code has been removed under
> > > > arch/arm/mach-imx, so we no need id_table entry here.
> > >
> > > Cc: Greg, Geert, Angelo,
> > >
> > > Aren't you breaking Coldfire platforms?
> >
> > Ok, I see coldfire still use use imx1-i2c. Could we remove imx21-i2c
> > or still keep it?
> 
> Did you check if anything else uses it?

Not find anyone use imx21-i2c under arch/* except arch/arm/boot/*dtsi

Thanks,
Peng.

> 
> Best regards,
> Krzysztof

Re: [PATCH 2/2] i2c: imx: remove id_table entry

2020-10-24 Thread Krzysztof Kozlowski 
On Sat, Oct 24, 2020 at 07:47:13AM +, Peng Fan wrote:
> > Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
> > 
> > On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng@nxp.com wrote:
> > > From: Peng Fan 
> > >
> > > The legacy platform device code has been removed under
> > > arch/arm/mach-imx, so we no need id_table entry here.
> > 
> > Cc: Greg, Geert, Angelo,
> > 
> > Aren't you breaking Coldfire platforms?
> 
> Ok, I see coldfire still use use imx1-i2c. Could we remove imx21-i2c or still
> keep it?

Did you check if anything else uses it?

Best regards,
Krzysztof

RE: [PATCH 2/2] i2c: imx: remove id_table entry

2020-10-24 Thread Peng Fan 
> Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
> 
> On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng@nxp.com wrote:
> > From: Peng Fan 
> >
> > The legacy platform device code has been removed under
> > arch/arm/mach-imx, so we no need id_table entry here.
> 
> Cc: Greg, Geert, Angelo,
> 
> Aren't you breaking Coldfire platforms?

Ok, I see coldfire still use use imx1-i2c. Could we remove imx21-i2c or still
keep it?

Thanks
Peng.

> 
> Best regards,
> Krzysztof
> 
> >
> > Signed-off-by: Peng Fan 
> > ---
> >  drivers/i2c/busses/i2c-imx.c | 14 --
> >  1 file changed, 14 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx.c
> > b/drivers/i2c/busses/i2c-imx.c index ba9d639223ec..7ea36a78abb0
> 100644
> > --- a/drivers/i2c/busses/i2c-imx.c
> > +++ b/drivers/i2c/busses/i2c-imx.c
> > @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata =
> {
> >
> >  };
> >
> > -static const struct platform_device_id imx_i2c_devtype[] = {
> > -   {
> > -   .name = "imx1-i2c",
> > -   .driver_data = (kernel_ulong_t)_i2c_hwdata,
> > -   }, {

Re: [PATCH 2/2] i2c: imx: remove id_table entry

2020-10-23 Thread Krzysztof Kozlowski 
On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng@nxp.com wrote:
> From: Peng Fan 
> 
> The legacy platform device code has been removed under arch/arm/mach-imx,
> so we no need id_table entry here.

Cc: Greg, Geert, Angelo,

Aren't you breaking Coldfire platforms?

Best regards,
Krzysztof

> 
> Signed-off-by: Peng Fan 
> ---
>  drivers/i2c/busses/i2c-imx.c | 14 --
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index ba9d639223ec..7ea36a78abb0 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
>  
>  };
>  
> -static const struct platform_device_id imx_i2c_devtype[] = {
> - {
> - .name = "imx1-i2c",
> - .driver_data = (kernel_ulong_t)_i2c_hwdata,
> - }, {

[PATCH 2/2] i2c: imx: remove id_table entry

2020-10-23 Thread peng . fan 
From: Peng Fan 

The legacy platform device code has been removed under arch/arm/mach-imx,
so we no need id_table entry here.

Signed-off-by: Peng Fan 
---
 drivers/i2c/busses/i2c-imx.c | 14 --
 1 file changed, 14 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index ba9d639223ec..7ea36a78abb0 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
 
 };
 
-static const struct platform_device_id imx_i2c_devtype[] = {
-   {
-   .name = "imx1-i2c",
-   .driver_data = (kernel_ulong_t)_i2c_hwdata,
-   }, {
-   .name = "imx21-i2c",
-   .driver_data = (kernel_ulong_t)_i2c_hwdata,
-   }, {
-   /* sentinel */
-   }
-};
-MODULE_DEVICE_TABLE(platform, imx_i2c_devtype);
-
 static const struct of_device_id i2c_imx_dt_ids[] = {
{ .compatible = "fsl,imx1-i2c", .data = _i2c_hwdata, },
{ .compatible = "fsl,imx21-i2c", .data = _i2c_hwdata, },
@@ -1340,7 +1327,6 @@ static struct platform_driver i2c_imx_driver = {
.of_match_table = i2c_imx_dt_ids,
.acpi_match_table = i2c_imx_acpi_ids,
},
-   .id_table = imx_i2c_devtype,
 };
 
 static int __init i2c_adap_imx_init(void)
-- 
2.28.0