On Thu, Sep 19, 2013 at 06:41:22AM +0100, Jonathan Cameron wrote:
>
>
> >...
> >> >
> >> > struct tiadc_device {
> >> > struct ti_tscadc_dev *mfd_tscadc;
> >> > int channels;
> >> > u8 channel_line[8];
> >> > u8 channel_step[8];
> >> >+ int
"Zubair Lutfullah :" wrote:
>On Wed, Sep 18, 2013 at 02:58:47PM +0100, Jonathan Cameron wrote:
>> On 18/09/13 12:23, Zubair Lutfullah wrote:
>> >Previously the driver had only one-shot reading functionality.
>> >This patch adds continuous sampling support to the driver.
>> >
>...
>>
>> Very
"Zubair Lutfullah :" wrote:
>On Wed, Sep 18, 2013 at 06:05:12PM +0100, Jonathan Cameron wrote:
>>
>> >> >However in this case such conversion us dangerous. With all but
>IRQ
>> >> >resource managed by the traditional methods they will be released
>> >first
>> >> >with IRQ handler deregistered
On Wed, Sep 18, 2013 at 02:58:47PM +0100, Jonathan Cameron wrote:
> On 18/09/13 12:23, Zubair Lutfullah wrote:
> >Previously the driver had only one-shot reading functionality.
> >This patch adds continuous sampling support to the driver.
> >
...
>
> Very very nearly there. Couple of suggestions
On Wed, Sep 18, 2013 at 06:05:12PM +0100, Jonathan Cameron wrote:
>
> >> >However in this case such conversion us dangerous. With all but IRQ
> >> >resource managed by the traditional methods they will be released
> >first
> >> >with IRQ handler deregistered very last. Therefore if device is not
Dmitry Torokhov wrote:
>On Wed, Sep 18, 2013 at 05:12:02PM +0100, Jonathan Cameron wrote:
>>
>>
>> Dmitry Torokhov wrote:
>> >On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
>> >>
>> >>
>> >> "Zubair Lutfullah :" wrote:
>> >> >On Tue, Sep 17, 2013 at 09:27:27PM -0700,
On Wed, Sep 18, 2013 at 05:12:02PM +0100, Jonathan Cameron wrote:
>
>
> Dmitry Torokhov wrote:
> >On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
> >>
> >>
> >> "Zubair Lutfullah :" wrote:
> >> >On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
> >> >> Hi
Dmitry Torokhov wrote:
>On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
>>
>>
>> "Zubair Lutfullah :" wrote:
>> >On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
>> >> Hi Zubair,
>> >>
>> >> On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
>
>
> "Zubair Lutfullah :" wrote:
> >On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
> >> Hi Zubair,
> >>
> >> On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
> >> > +
> >> > +ret =
On 18/09/13 12:23, Zubair Lutfullah wrote:
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
Continuous sampling starts when buffer is enabled.
HW IRQ wakes worker thread that pushes samples to userspace.
Sampling stops
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
> "Zubair Lutfullah :" wrote:
> >On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
> >> Hi Zubair,
> >>
> >> On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
> >> > +
> >> > +ret =
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
Continuous sampling starts when buffer is enabled.
HW IRQ wakes worker thread that pushes samples to userspace.
Sampling stops when buffer is disabled by userspace.
Patil
"Zubair Lutfullah :" wrote:
>On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
>> Hi Zubair,
>>
>> On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
>> > +
>> > + ret = devm_request_threaded_irq(indio_dev->dev.parent,
>> > + irq,
>> > +
On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
> Hi Zubair,
>
> On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
> > +
> > + ret = devm_request_threaded_irq(indio_dev->dev.parent,
> > + irq,
> > +
On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
Hi Zubair,
On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
+
+ ret = devm_request_threaded_irq(indio_dev-dev.parent,
+ irq,
+ pollfunc_th,
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
Hi Zubair,
On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
+
+ ret = devm_request_threaded_irq(indio_dev-dev.parent,
+ irq,
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
Continuous sampling starts when buffer is enabled.
HW IRQ wakes worker thread that pushes samples to userspace.
Sampling stops when buffer is disabled by userspace.
Patil
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
Hi Zubair,
On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
+
+ret =
On 18/09/13 12:23, Zubair Lutfullah wrote:
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
Continuous sampling starts when buffer is enabled.
HW IRQ wakes worker thread that pushes samples to userspace.
Sampling stops
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
Hi Zubair,
On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
+
+ret =
Dmitry Torokhov dmitry.torok...@gmail.com wrote:
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote:
Hi Zubair,
On Tue, Sep 17, 2013 at 09:44:07AM
On Wed, Sep 18, 2013 at 05:12:02PM +0100, Jonathan Cameron wrote:
Dmitry Torokhov dmitry.torok...@gmail.com wrote:
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry
Dmitry Torokhov dmitry.torok...@gmail.com wrote:
On Wed, Sep 18, 2013 at 05:12:02PM +0100, Jonathan Cameron wrote:
Dmitry Torokhov dmitry.torok...@gmail.com wrote:
On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote:
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Wed, Sep 18, 2013 at 06:05:12PM +0100, Jonathan Cameron wrote:
However in this case such conversion us dangerous. With all but IRQ
resource managed by the traditional methods they will be released
first
with IRQ handler deregistered very last. Therefore if device is not
properly
On Wed, Sep 18, 2013 at 02:58:47PM +0100, Jonathan Cameron wrote:
On 18/09/13 12:23, Zubair Lutfullah wrote:
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
...
Very very nearly there. Couple of suggestions in-line.
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Wed, Sep 18, 2013 at 06:05:12PM +0100, Jonathan Cameron wrote:
However in this case such conversion us dangerous. With all but
IRQ
resource managed by the traditional methods they will be released
first
with IRQ handler
Zubair Lutfullah : zubair.lutful...@gmail.com wrote:
On Wed, Sep 18, 2013 at 02:58:47PM +0100, Jonathan Cameron wrote:
On 18/09/13 12:23, Zubair Lutfullah wrote:
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
...
On Thu, Sep 19, 2013 at 06:41:22AM +0100, Jonathan Cameron wrote:
...
struct tiadc_device {
struct ti_tscadc_dev *mfd_tscadc;
int channels;
u8 channel_line[8];
u8 channel_step[8];
+ int buffer_en_ch_steps;
+ u32 *data;
u16 *data;
Hi Zubair,
On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
> +
> + ret = devm_request_threaded_irq(indio_dev->dev.parent,
> + irq,
> + pollfunc_th, pollfunc_bh,
> + flags, indio_dev->name,
>
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
Continuous sampling starts when buffer is enabled.
HW IRQ wakes worker thread that pushes samples to userspace.
Sampling stops when buffer is disabled by userspace.
Patil
Previously the driver had only one-shot reading functionality.
This patch adds continuous sampling support to the driver.
Continuous sampling starts when buffer is enabled.
HW IRQ wakes worker thread that pushes samples to userspace.
Sampling stops when buffer is disabled by userspace.
Patil
Hi Zubair,
On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote:
+
+ ret = devm_request_threaded_irq(indio_dev-dev.parent,
+ irq,
+ pollfunc_th, pollfunc_bh,
+ flags, indio_dev-name,
+
On Sun, Sep 08, 2013 at 02:42:51PM +0100, Jonathan Cameron wrote:
> On 09/01/13 12:17, Zubair Lutfullah wrote:
Thanks for the review. Fitting this driver in the usual trigger ABI
is a bad workaround indeed.
I am still a bit unclear regarding the implementation.
Questions and replies inline.
I
On Sun, Sep 08, 2013 at 02:42:51PM +0100, Jonathan Cameron wrote:
On 09/01/13 12:17, Zubair Lutfullah wrote:
Thanks for the review. Fitting this driver in the usual trigger ABI
is a bad workaround indeed.
I am still a bit unclear regarding the implementation.
Questions and replies inline.
I
On 09/01/13 12:17, Zubair Lutfullah wrote:
> Previously the driver had only one-shot reading functionality.
> This patch adds triggered buffer support to the driver.
>
> Continuous sampling starts when buffer is enabled.
> And samples are pushed to userpace by the trigger which
> triggers
On 09/01/13 12:17, Zubair Lutfullah wrote:
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers automatically
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers automatically at every hardware interrupt
of FIFO1 filling
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers automatically at every hardware interrupt
of FIFO1 filling
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers automatically at every hardware interrupt
of FIFO1 filling
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers automatically at every hardware interrupt
of FIFO1 filling
On Wed, Aug 28, 2013 at 03:01:24PM +0200, Sebastian Andrzej Siewior wrote:
> * Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
>
> I am mostly happy with it. There are just two things I pointed out.
> Besides that, it looks good from my side.
Sign-off?
> >+static irqreturn_t tiadc_irq(int irq,
On Wed, Aug 28, 2013 at 04:18:35PM +0200, Sebastian Andrzej Siewior wrote:
> * Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
>
> >diff --git a/drivers/iio/adc/ti_am335x_adc.c
> >b/drivers/iio/adc/ti_am335x_adc.c
> >index a952538..ae2202b 100644
> >--- a/drivers/iio/adc/ti_am335x_adc.c
> >+++
On Wed, Aug 28, 2013 at 06:43:08PM +0200, Sebastian Andrzej Siewior wrote:
> * Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
>
> >diff --git a/drivers/iio/adc/ti_am335x_adc.c
> >b/drivers/iio/adc/ti_am335x_adc.c
> >index a952538..ae2202b 100644
> >--- a/drivers/iio/adc/ti_am335x_adc.c
> >+++
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
>diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
>index a952538..ae2202b 100644
>--- a/drivers/iio/adc/ti_am335x_adc.c
>+++ b/drivers/iio/adc/ti_am335x_adc.c
>@@ -231,28 +406,56 @@ static int tiadc_probe(struct
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
>diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
>index a952538..ae2202b 100644
>--- a/drivers/iio/adc/ti_am335x_adc.c
>+++ b/drivers/iio/adc/ti_am335x_adc.c
…
>+static struct iio_trigger
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
I am mostly happy with it. There are just two things I pointed out.
Besides that, it looks good from my side.
>diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
>index a952538..ae2202b 100644
>---
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
I am mostly happy with it. There are just two things I pointed out.
Besides that, it looks good from my side.
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index a952538..ae2202b 100644
---
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index a952538..ae2202b 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
…
+static struct iio_trigger
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index a952538..ae2202b 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
@@ -231,28 +406,56 @@ static int tiadc_probe(struct
On Wed, Aug 28, 2013 at 06:43:08PM +0200, Sebastian Andrzej Siewior wrote:
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
diff --git a/drivers/iio/adc/ti_am335x_adc.c
b/drivers/iio/adc/ti_am335x_adc.c
index a952538..ae2202b 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++
On Wed, Aug 28, 2013 at 04:18:35PM +0200, Sebastian Andrzej Siewior wrote:
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
diff --git a/drivers/iio/adc/ti_am335x_adc.c
b/drivers/iio/adc/ti_am335x_adc.c
index a952538..ae2202b 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++
On Wed, Aug 28, 2013 at 03:01:24PM +0200, Sebastian Andrzej Siewior wrote:
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
I am mostly happy with it. There are just two things I pointed out.
Besides that, it looks good from my side.
Sign-off?
+static irqreturn_t tiadc_irq(int irq, void
On Sun, 25 Aug 2013, Zubair Lutfullah wrote:
> Previously the driver had only one-shot reading functionality.
> This patch adds triggered buffer support to the driver.
>
> Continuous sampling starts when buffer is enabled.
> And samples are pushed to userpace by the trigger which
> triggers
On Sun, 25 Aug 2013, Zubair Lutfullah wrote:
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers automatically at every hardware interrupt
of FIFO1 filling
Previously the driver had only one-shot reading functionality.
This patch adds triggered buffer support to the driver.
Continuous sampling starts when buffer is enabled.
And samples are pushed to userpace by the trigger which
triggers automatically at every hardware interrupt
of FIFO1 filling
56 matches
Mail list logo
