Re: [PATCH 2/2] kernfs: remove mutex in kernfs_dop_revalidate

2020-12-02 Thread Fox Chen
On Thu, Dec 3, 2020 at 2:46 AM Tejun Heo wrote: > > Hello, > > On Wed, Dec 02, 2020 at 10:58:37PM +0800, Fox Chen wrote: > > There is a big mutex in kernfs_dop_revalidate which slows down the > > concurrent performance of kernfs. > > > > Since kernfs_dop_revalidate only does some checks, the lock

Re: [PATCH 2/2] kernfs: remove mutex in kernfs_dop_revalidate

2020-12-02 Thread Fox Chen
On Thu, Dec 3, 2020 at 2:26 AM Greg KH wrote: > > On Wed, Dec 02, 2020 at 10:58:37PM +0800, Fox Chen wrote: > > There is a big mutex in kernfs_dop_revalidate which slows down the > > concurrent performance of kernfs. > > > > Since kernfs_dop_revalidate only does some checks, the lock is > >

Re: [PATCH 2/2] kernfs: remove mutex in kernfs_dop_revalidate

2020-12-02 Thread Tejun Heo
Hello, On Wed, Dec 02, 2020 at 10:58:37PM +0800, Fox Chen wrote: > There is a big mutex in kernfs_dop_revalidate which slows down the > concurrent performance of kernfs. > > Since kernfs_dop_revalidate only does some checks, the lock is > largely unnecessary. Also, according to kernel filesystem

Re: [PATCH 2/2] kernfs: remove mutex in kernfs_dop_revalidate

2020-12-02 Thread Greg KH
On Wed, Dec 02, 2020 at 10:58:37PM +0800, Fox Chen wrote: > There is a big mutex in kernfs_dop_revalidate which slows down the > concurrent performance of kernfs. > > Since kernfs_dop_revalidate only does some checks, the lock is > largely unnecessary. Also, according to kernel filesystem locking

[PATCH 2/2] kernfs: remove mutex in kernfs_dop_revalidate

2020-12-02 Thread Fox Chen
There is a big mutex in kernfs_dop_revalidate which slows down the concurrent performance of kernfs. Since kernfs_dop_revalidate only does some checks, the lock is largely unnecessary. Also, according to kernel filesystem locking document: