Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-27 Thread Andrew Jeffery
Hi Jacek, Pavel On Sun, 2017-08-27 at 13:01 +0200, Jacek Anaszewski wrote: > Hi Andrew, > > On 08/25/2017 09:32 AM, Pavel Machek wrote: > > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote: > > > In some systems, such as BMCs, we want to retain the state of LEDs > > > across a reboot of the BMC

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-27 Thread Andrew Jeffery
Hi Jacek, Pavel On Sun, 2017-08-27 at 13:01 +0200, Jacek Anaszewski wrote: > Hi Andrew, > > On 08/25/2017 09:32 AM, Pavel Machek wrote: > > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote: > > > In some systems, such as BMCs, we want to retain the state of LEDs > > > across a reboot of the BMC

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-27 Thread Jacek Anaszewski
Hi Andrew, On 08/25/2017 09:32 AM, Pavel Machek wrote: > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote: >> In some systems, such as BMCs, we want to retain the state of LEDs >> across a reboot of the BMC whilst the host remains up. > > I'd spell out what BMC is... I agree with Pavel. Please

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-27 Thread Jacek Anaszewski
Hi Andrew, On 08/25/2017 09:32 AM, Pavel Machek wrote: > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote: >> In some systems, such as BMCs, we want to retain the state of LEDs >> across a reboot of the BMC whilst the host remains up. > > I'd spell out what BMC is... I agree with Pavel. Please

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-25 Thread Pavel Machek
On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote: > In some systems, such as BMCs, we want to retain the state of LEDs > across a reboot of the BMC whilst the host remains up. I'd spell out what BMC is... Otherwise series looks good. Acked-by: Pavel Machek

Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-25 Thread Pavel Machek
On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote: > In some systems, such as BMCs, we want to retain the state of LEDs > across a reboot of the BMC whilst the host remains up. I'd spell out what BMC is... Otherwise series looks good. Acked-by: Pavel Machek

[PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-25 Thread Andrew Jeffery
In some systems, such as BMCs, we want to retain the state of LEDs across a reboot of the BMC whilst the host remains up. Signed-off-by: Andrew Jeffery --- drivers/leds/leds-gpio.c | 7 ++- include/linux/leds.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-)

[PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown

2017-08-25 Thread Andrew Jeffery
In some systems, such as BMCs, we want to retain the state of LEDs across a reboot of the BMC whilst the host remains up. Signed-off-by: Andrew Jeffery --- drivers/leds/leds-gpio.c | 7 ++- include/linux/leds.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git