Re: [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-25 Thread Lee Jones
On Thu, 25 Oct 2018, Dan Carpenter wrote: > On Thu, Oct 25, 2018 at 09:25:08AM +0100, Lee Jones wrote: > > On Thu, 18 Oct 2018, Dan Carpenter wrote: > > > > > I just noticed this in review. The get_register_interruptible() should > > > return zero on success but it instead returns the value

Re: [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-25 Thread Lee Jones
On Thu, 25 Oct 2018, Dan Carpenter wrote: > On Thu, Oct 25, 2018 at 09:25:08AM +0100, Lee Jones wrote: > > On Thu, 18 Oct 2018, Dan Carpenter wrote: > > > > > I just noticed this in review. The get_register_interruptible() should > > > return zero on success but it instead returns the value

Re: [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-25 Thread Dan Carpenter
On Thu, Oct 25, 2018 at 09:25:08AM +0100, Lee Jones wrote: > On Thu, 18 Oct 2018, Dan Carpenter wrote: > > > I just noticed this in review. The get_register_interruptible() should > > return zero on success but it instead returns the value that it read. > > > > I looked at all the places that

Re: [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-25 Thread Dan Carpenter
On Thu, Oct 25, 2018 at 09:25:08AM +0100, Lee Jones wrote: > On Thu, 18 Oct 2018, Dan Carpenter wrote: > > > I just noticed this in review. The get_register_interruptible() should > > return zero on success but it instead returns the value that it read. > > > > I looked at all the places that

Re: [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-25 Thread Lee Jones
On Thu, 18 Oct 2018, Dan Carpenter wrote: > I just noticed this in review. The get_register_interruptible() should > return zero on success but it instead returns the value that it read. > > I looked at all the places that called this directly and they check for > negatives and treat greater

Re: [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-25 Thread Lee Jones
On Thu, 18 Oct 2018, Dan Carpenter wrote: > I just noticed this in review. The get_register_interruptible() should > return zero on success but it instead returns the value that it read. > > I looked at all the places that called this directly and they check for > negatives and treat greater

[PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-18 Thread Dan Carpenter
I just noticed this in review. The get_register_interruptible() should return zero on success but it instead returns the value that it read. I looked at all the places that called this directly and they check for negatives and treat greater than or equal to zero as success. This function is

[PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()

2018-10-18 Thread Dan Carpenter
I just noticed this in review. The get_register_interruptible() should return zero on success but it instead returns the value that it read. I looked at all the places that called this directly and they check for negatives and treat greater than or equal to zero as success. This function is