Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2016-01-04 Thread Vlastimil Babka
On 12/23/2015 07:57 AM, Joonsoo Kim wrote: What are the cases where pageblock_pfn_to_page() is used for a subset of the pageblock and the result would be problematic for compaction? I.e., do we actually care to use pageblocks that are not contiguous at all? The problematic pageblocks are those

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-22 Thread Joonsoo Kim
On Wed, Dec 23, 2015 at 07:14:21AM +0100, Vlastimil Babka wrote: > On 22.12.2015 23:17, David Rientjes wrote: > > On Mon, 21 Dec 2015, Joonsoo Kim wrote: > > > >> Before vs After > >> Max: 1096 MB/s vs 1325 MB/s > >> Min: 635 MB/s 1015 MB/s > >> Avg: 899 MB/s 1194 MB/s > >> > >> Avg is improved by

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-22 Thread Vlastimil Babka
On 22.12.2015 23:17, David Rientjes wrote: > On Mon, 21 Dec 2015, Joonsoo Kim wrote: > >> Before vs After >> Max: 1096 MB/s vs 1325 MB/s >> Min: 635 MB/s 1015 MB/s >> Avg: 899 MB/s 1194 MB/s >> >> Avg is improved by roughly 30% [2]. >> > > Wow, ok! > > I'm wondering if it would be better to main

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-22 Thread David Rientjes
On Mon, 21 Dec 2015, Joonsoo Kim wrote: > There is a performance drop report due to hugepage allocation and in there > half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. > In that workload, compaction is triggered to make hugepage but most of > pageblocks are un-available for

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-21 Thread Joonsoo Kim
2015-12-21 21:18 GMT+09:00 Joonsoo Kim : > 2015-12-21 19:46 GMT+09:00 Vlastimil Babka : >> On 12/21/2015 07:13 AM, Joonsoo Kim wrote: >>> >>> There is a performance drop report due to hugepage allocation and in there >>> half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. >>> I

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-21 Thread Joonsoo Kim
2015-12-21 19:46 GMT+09:00 Vlastimil Babka : > On 12/21/2015 07:13 AM, Joonsoo Kim wrote: >> >> There is a performance drop report due to hugepage allocation and in there >> half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. >> In that workload, compaction is triggered to make

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-21 Thread Vlastimil Babka
On 12/21/2015 07:13 AM, Joonsoo Kim wrote: There is a performance drop report due to hugepage allocation and in there half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. In that workload, compaction is triggered to make hugepage but most of pageblocks are un-available for com

[PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-20 Thread Joonsoo Kim
There is a performance drop report due to hugepage allocation and in there half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. In that workload, compaction is triggered to make hugepage but most of pageblocks are un-available for compaction due to pageblock type and skip bit so

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-15 Thread Vlastimil Babka
On 12/15/2015 02:06 AM, Aaron Lu wrote: On 12/14/2015 11:25 PM, Joonsoo Kim wrote: 2015-12-14 19:29 GMT+09:00 Vlastimil Babka : Unless I'm mistaken, these results also include my RFC series (Aaron can you clarify?). These patches should better be tested standalone on top of base, as being simpl

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-14 Thread Aaron Lu
On 12/14/2015 11:25 PM, Joonsoo Kim wrote: > 2015-12-14 19:29 GMT+09:00 Vlastimil Babka : >> On 12/14/2015 06:02 AM, Joonsoo Kim wrote: >>> Before vs After >>> Max: 1096 MB/s vs 1325 MB/s >>> Min: 635 MB/s 1015 MB/s >>> Avg: 899 MB/s 1194 MB/s >>> >>> Avg is improved by roughly 30% [2]. >> >> >> Un

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-14 Thread Joonsoo Kim
2015-12-14 19:29 GMT+09:00 Vlastimil Babka : > On 12/14/2015 06:02 AM, Joonsoo Kim wrote: >> >> There is a performance drop report due to hugepage allocation and in there >> half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. >> In that workload, compaction is triggered to make

Re: [PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-14 Thread Vlastimil Babka
On 12/14/2015 06:02 AM, Joonsoo Kim wrote: There is a performance drop report due to hugepage allocation and in there half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. In that workload, compaction is triggered to make hugepage but most of pageblocks are un-available for com

[PATCH 2/2] mm/compaction: speed up pageblock_pfn_to_page() when zone is contiguous

2015-12-13 Thread Joonsoo Kim
There is a performance drop report due to hugepage allocation and in there half of cpu time are spent on pageblock_pfn_to_page() in compaction [1]. In that workload, compaction is triggered to make hugepage but most of pageblocks are un-available for compaction due to pageblock type and skip bit so