Re: [PATCH 2/2] perf expr: Add < and > operators

2020-06-10 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 09, 2020 at 10:17:16PM -0700, Ian Rogers escreveu:
> These are broadly useful and necessary for Intel's top-down analysis.

Ditto.

- Arnaldo
 
> Signed-off-by: Ian Rogers 
> ---
>  tools/perf/util/expr.l | 2 ++
>  tools/perf/util/expr.y | 5 -
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/expr.l b/tools/perf/util/expr.l
> index 298d86660a96..13e5e3c75f56 100644
> --- a/tools/perf/util/expr.l
> +++ b/tools/perf/util/expr.l
> @@ -111,6 +111,8 @@ else  { return ELSE; }
>  "|"  { return '|'; }
>  "^"  { return '^'; }
>  "&"  { return '&'; }
> +"<"  { return '<'; }
> +">"  { return '>'; }
>  "-"  { return '-'; }
>  "+"  { return '+'; }
>  "*"  { return '*'; }
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index fe145344bb39..5fcb98800f9c 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -41,6 +41,7 @@ static double d_ratio(double val0, double val1)
>  %left '|'
>  %left '^'
>  %left '&'
> +%left '<' '>'
>  %left '-' '+'
>  %left '*' '/' '%'
>  %left NEG NOT
> @@ -73,7 +74,7 @@ other: ID
>  |
>  MIN | MAX | IF | ELSE | SMT_ON | NUMBER | '|' | '^' | '&' | '-' | '+' | '*' 
> | '/' | '%' | '(' | ')' | ','
>  |
> -D_RATIO
> +'<' | '>' | D_RATIO
>  
>  all_expr: if_expr{ *final_val = $1; }
>   ;
> @@ -94,6 +95,8 @@ expr: NUMBER
>   | expr '|' expr { $$ = (long)$1 | (long)$3; }
>   | expr '&' expr { $$ = (long)$1 & (long)$3; }
>   | expr '^' expr { $$ = (long)$1 ^ (long)$3; }
> + | expr '<' expr { $$ = $1 < $3; }
> + | expr '>' expr { $$ = $1 > $3; }
>   | expr '+' expr { $$ = $1 + $3; }
>   | expr '-' expr { $$ = $1 - $3; }
>   | expr '*' expr { $$ = $1 * $3; }
> -- 
> 2.27.0.278.ge193c7cf3a9-goog
> 

-- 

- Arnaldo


[PATCH 2/2] perf expr: Add < and > operators

2020-06-09 Thread Ian Rogers
These are broadly useful and necessary for Intel's top-down analysis.

Signed-off-by: Ian Rogers 
---
 tools/perf/util/expr.l | 2 ++
 tools/perf/util/expr.y | 5 -
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/expr.l b/tools/perf/util/expr.l
index 298d86660a96..13e5e3c75f56 100644
--- a/tools/perf/util/expr.l
+++ b/tools/perf/util/expr.l
@@ -111,6 +111,8 @@ else{ return ELSE; }
 "|"{ return '|'; }
 "^"{ return '^'; }
 "&"{ return '&'; }
+"<"{ return '<'; }
+">"{ return '>'; }
 "-"{ return '-'; }
 "+"{ return '+'; }
 "*"{ return '*'; }
diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
index fe145344bb39..5fcb98800f9c 100644
--- a/tools/perf/util/expr.y
+++ b/tools/perf/util/expr.y
@@ -41,6 +41,7 @@ static double d_ratio(double val0, double val1)
 %left '|'
 %left '^'
 %left '&'
+%left '<' '>'
 %left '-' '+'
 %left '*' '/' '%'
 %left NEG NOT
@@ -73,7 +74,7 @@ other: ID
 |
 MIN | MAX | IF | ELSE | SMT_ON | NUMBER | '|' | '^' | '&' | '-' | '+' | '*' | 
'/' | '%' | '(' | ')' | ','
 |
-D_RATIO
+'<' | '>' | D_RATIO
 
 all_expr: if_expr  { *final_val = $1; }
;
@@ -94,6 +95,8 @@ expr:   NUMBER
| expr '|' expr { $$ = (long)$1 | (long)$3; }
| expr '&' expr { $$ = (long)$1 & (long)$3; }
| expr '^' expr { $$ = (long)$1 ^ (long)$3; }
+   | expr '<' expr { $$ = $1 < $3; }
+   | expr '>' expr { $$ = $1 > $3; }
| expr '+' expr { $$ = $1 + $3; }
| expr '-' expr { $$ = $1 - $3; }
| expr '*' expr { $$ = $1 * $3; }
-- 
2.27.0.278.ge193c7cf3a9-goog