Re: [PATCH 2/2] perf tools: Support -x for perf stat report

2020-10-27 Thread Jiri Olsa
On Mon, Oct 26, 2020 at 05:27:37PM -0700, Andi Kleen wrote:
> Add support for the -x, option to enable CSV output with perf stat
> report. Useful to parse the information with other programs.
> 
> % perf stat record --quiet -a -I 1000 sleep 5
> % perf stat report -x,
>  1.000838672,4003.55,msec,cpu-clock,4003548736,100.00,,
>  1.000838672,11243,,context-switches,4003631885,100.00,0.003,M/sec
>  1.000838672,1682,,cpu-migrations,4003672150,100.00,0.420,K/sec
>  1.000838672,13244,,page-faults,4003697471,100.00,0.003,M/sec
>  1.000838672,2953214077,,cycles,4003715495,100.00,0.738,GHz
>  1.000838672,4380820799,,instructions,4003738270,100.00,1.48,insn per 
> cycle
>  1.000838672,809865653,,branches,4003760616,100.00,202.287,M/sec
>  1.000838672,12439843,,branch-misses,4003780785,100.00,1.54,of all 
> branches
> ...
> 
> Signed-off-by: Andi Kleen 
> ---
>  tools/perf/builtin-stat.c | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 743fe47e7a88..31e7bd877f1d 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1988,6 +1988,8 @@ static int __cmd_report(int argc, const char **argv)
>"aggregate counts per numa node", AGGR_NODE),
>   OPT_SET_UINT('A', "no-aggr", _stat.aggr_mode,
>"disable CPU count aggregation", AGGR_NONE),
> + OPT_STRING('x', "field-separator", _config.csv_sep, "separator",
> +"print counts with custom separator"),
>   OPT_END()
>   };
>   struct stat st;
> @@ -2002,6 +2004,11 @@ static int __cmd_report(int argc, const char **argv)
>   input_name = "perf.data";
>   }
>  
> + if (stat_config.csv_sep) {
> + stat_config.csv_output = true;
> + stat_config.big_num = false;
> + }

stat_config.csv_sep is by default ' ' so this will force
the standard output to be with -x

jirka

> +
>   perf_stat.data.path = input_name;
>   perf_stat.data.mode = PERF_DATA_MODE_READ;
>  
> -- 
> 2.28.0
> 



[PATCH 2/2] perf tools: Support -x for perf stat report

2020-10-26 Thread Andi Kleen
Add support for the -x, option to enable CSV output with perf stat
report. Useful to parse the information with other programs.

% perf stat record --quiet -a -I 1000 sleep 5
% perf stat report -x,
 1.000838672,4003.55,msec,cpu-clock,4003548736,100.00,,
 1.000838672,11243,,context-switches,4003631885,100.00,0.003,M/sec
 1.000838672,1682,,cpu-migrations,4003672150,100.00,0.420,K/sec
 1.000838672,13244,,page-faults,4003697471,100.00,0.003,M/sec
 1.000838672,2953214077,,cycles,4003715495,100.00,0.738,GHz
 1.000838672,4380820799,,instructions,4003738270,100.00,1.48,insn per cycle
 1.000838672,809865653,,branches,4003760616,100.00,202.287,M/sec
 1.000838672,12439843,,branch-misses,4003780785,100.00,1.54,of all branches
...

Signed-off-by: Andi Kleen 
---
 tools/perf/builtin-stat.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 743fe47e7a88..31e7bd877f1d 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1988,6 +1988,8 @@ static int __cmd_report(int argc, const char **argv)
 "aggregate counts per numa node", AGGR_NODE),
OPT_SET_UINT('A', "no-aggr", _stat.aggr_mode,
 "disable CPU count aggregation", AGGR_NONE),
+   OPT_STRING('x', "field-separator", _config.csv_sep, "separator",
+  "print counts with custom separator"),
OPT_END()
};
struct stat st;
@@ -2002,6 +2004,11 @@ static int __cmd_report(int argc, const char **argv)
input_name = "perf.data";
}
 
+   if (stat_config.csv_sep) {
+   stat_config.csv_output = true;
+   stat_config.big_num = false;
+   }
+
perf_stat.data.path = input_name;
perf_stat.data.mode = PERF_DATA_MODE_READ;
 
-- 
2.28.0