Re: [PATCH 2/2] phy: phy-brcm-usb: specify init function format at struct level

[Florian Fainelli]

On 12/16/20 6:33 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki 
> 
> This is slightly cleaner solution that assures noone assings a wrong
> function to the pointer.
> 
> Signed-off-by: Rafał Miłecki 

Acked-by: Florian Fainelli 
-- 
Florian

[PATCH 2/2] phy: phy-brcm-usb: specify init function format at struct level

[Rafał Miłecki]

From: Rafał Miłecki 

This is slightly cleaner solution that assures noone assings a wrong
function to the pointer.

Signed-off-by: Rafał Miłecki 
---
 drivers/phy/broadcom/phy-brcm-usb.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/phy/broadcom/phy-brcm-usb.c 
b/drivers/phy/broadcom/phy-brcm-usb.c
index f0f01060bd12..116fb23aebd9 100644
--- a/drivers/phy/broadcom/phy-brcm-usb.c
+++ b/drivers/phy/broadcom/phy-brcm-usb.c
@@ -35,7 +35,7 @@ struct value_to_name_map {
 };
 
 struct match_chip_info {
-   void *init_func;
+   void (*init_func)(struct brcm_usb_init_params *params);
u8 required_regs[BRCM_REGS_MAX + 1];
u8 optional_reg;
 };
@@ -432,7 +432,6 @@ static int brcm_usb_phy_probe(struct platform_device *pdev)
struct device_node *dn = pdev->dev.of_node;
int err;
const char *mode;
-   void (*dvr_init)(struct brcm_usb_init_params *params);
const struct match_chip_info *info;
struct regmap *rmap;
int x;
@@ -448,8 +447,8 @@ static int brcm_usb_phy_probe(struct platform_device *pdev)
info = of_device_get_match_data(&pdev->dev);
if (!info)
return -ENOENT;
-   dvr_init = info->init_func;
-   (*dvr_init)(&priv->ini);
+
+   info->init_func(&priv->ini);
 
dev_dbg(dev, "Best mapping table is for %s\n",
priv->ini.family_name);
-- 
2.26.2