Re: [PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-09 Thread Linus Walleij
On Thu, Nov 8, 2012 at 6:11 PM, Stephen Warren wrote: > Do you actually need to store the run-time data in struct > nmk_pinctrl_soc_data too? I would have expected all the soc_data > pointers to remain const, and to store the runtime register pointer > somewhere else, and perhaps pass it as a

Re: [PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-09 Thread Linus Walleij
On Thu, Nov 8, 2012 at 6:11 PM, Stephen Warren swar...@wwwdotorg.org wrote: Do you actually need to store the run-time data in struct nmk_pinctrl_soc_data too? I would have expected all the soc_data pointers to remain const, and to store the runtime register pointer somewhere else, and

Re: [PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-08 Thread Stephen Warren
On 11/08/2012 04:55 AM, Linus Walleij wrote: > From: Jonas Aaberg > > Currently there are some unnecessary criss-cross > dependencies between the PRCMU driver in MFD and a lot of > other drivers, mainly because other drivers need to poke > around in the PRCM register range. > > In cases like

[PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-08 Thread Linus Walleij
From: Jonas Aaberg Currently there are some unnecessary criss-cross dependencies between the PRCMU driver in MFD and a lot of other drivers, mainly because other drivers need to poke around in the PRCM register range. In cases like this there are actually just a few select registers that the

[PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-08 Thread Linus Walleij
From: Jonas Aaberg jonas.ab...@stericsson.com Currently there are some unnecessary criss-cross dependencies between the PRCMU driver in MFD and a lot of other drivers, mainly because other drivers need to poke around in the PRCM register range. In cases like this there are actually just a few

Re: [PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-08 Thread Stephen Warren
On 11/08/2012 04:55 AM, Linus Walleij wrote: From: Jonas Aaberg jonas.ab...@stericsson.com Currently there are some unnecessary criss-cross dependencies between the PRCMU driver in MFD and a lot of other drivers, mainly because other drivers need to poke around in the PRCM register range.