Re: [PATCH 2/2] riscv: fix build warning of mm/pageattr

2020-07-16 Thread Zong Li 
On Thu, Jul 16, 2020 at 3:24 PM Andreas Schwab  wrote:
>
> On Jul 16 2020, Zong Li wrote:
>
> > Add hearder for missing prototype. Also, static keyword should be at
>
> s/hearder/header/
>
> Andreas.
>
> --
> Andreas Schwab, sch...@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."

Hi all,

Let me describe the details in the commit message and fix the typo in
the next version.
Thanks for reviewing.

Re: [PATCH 2/2] riscv: fix build warning of mm/pageattr

2020-07-16 Thread Andreas Schwab 
On Jul 16 2020, Zong Li wrote:

> Add hearder for missing prototype. Also, static keyword should be at

s/hearder/header/

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [PATCH 2/2] riscv: fix build warning of mm/pageattr

2020-07-16 Thread Pekka Enberg 
On Thu, Jul 16, 2020 at 10:11 AM Pekka Enberg  wrote:
>
> On Thu, Jul 16, 2020 at 9:16 AM Zong Li  wrote:
> >
> > Add hearder for missing prototype. Also, static keyword should be at
> > beginning of declaration.
> >
> > Signed-off-by: Zong Li 
>
> Which prototype is missing?

Aah, never mind, you mention them in the cover letter. I think patch
description would be a better place to ensure they end up in git logs.

For both patches:

Reviewed-by: Pekka Enberg 

- Pekka

Re: [PATCH 2/2] riscv: fix build warning of mm/pageattr

2020-07-16 Thread Pekka Enberg 
On Thu, Jul 16, 2020 at 9:16 AM Zong Li  wrote:
>
> Add hearder for missing prototype. Also, static keyword should be at
> beginning of declaration.
>
> Signed-off-by: Zong Li 

Which prototype is missing?

- Pekka

[PATCH 2/2] riscv: fix build warning of mm/pageattr

2020-07-16 Thread Zong Li 
Add hearder for missing prototype. Also, static keyword should be at
beginning of declaration.

Signed-off-by: Zong Li 
---
 arch/riscv/mm/pageattr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c
index 289a9a5ea5b5..19fecb362d81 100644
--- a/arch/riscv/mm/pageattr.c
+++ b/arch/riscv/mm/pageattr.c
@@ -7,6 +7,7 @@
 #include 
 #include 
 #include 
+#include 
 
 struct pageattr_masks {
pgprot_t set_mask;
@@ -94,7 +95,7 @@ static int pageattr_pte_hole(unsigned long addr, unsigned 
long next,
return 0;
 }
 
-const static struct mm_walk_ops pageattr_ops = {
+static const struct mm_walk_ops pageattr_ops = {
.pgd_entry = pageattr_pgd_entry,
.p4d_entry = pageattr_p4d_entry,
.pud_entry = pageattr_pud_entry,
-- 
2.27.0