Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-11 Thread Guenter Roeck
On Tue, Sep 11, 2018 at 11:28:26AM -0600, Jeremy Gebben wrote: > The abx804 and abx805 chips have support for a simple watchdog > function that can trigger an external reset. > > Signed-off-by: Jeremy Gebben Reviewed-by: Guenter Roeck > --- > drivers/rtc/Kconfig | 1 + >

Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-11 Thread Guenter Roeck
On Tue, Sep 11, 2018 at 11:28:26AM -0600, Jeremy Gebben wrote: > The abx804 and abx805 chips have support for a simple watchdog > function that can trigger an external reset. > > Signed-off-by: Jeremy Gebben Reviewed-by: Guenter Roeck > --- > drivers/rtc/Kconfig | 1 + >

[PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-11 Thread Jeremy Gebben
The abx804 and abx805 chips have support for a simple watchdog function that can trigger an external reset. Signed-off-by: Jeremy Gebben --- drivers/rtc/Kconfig | 1 + drivers/rtc/rtc-abx80x.c | 116 +-- 2 files changed, 113 insertions(+), 4

[PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-11 Thread Jeremy Gebben
The abx804 and abx805 chips have support for a simple watchdog function that can trigger an external reset. Signed-off-by: Jeremy Gebben --- drivers/rtc/Kconfig | 1 + drivers/rtc/rtc-abx80x.c | 116 +-- 2 files changed, 113 insertions(+), 4

Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-11 Thread Alexandre Belloni
On 10/09/2018 16:20:19-0700, Guenter Roeck wrote: > > +static int abx80x_wdog_set_timeout(struct watchdog_device *wdog, > > + unsigned int new_timeout) > > I'll leave multi-line alignment issues to the driver maintainer. > Indeed, I'd like those to be aligned on the

Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-11 Thread Alexandre Belloni
On 10/09/2018 16:20:19-0700, Guenter Roeck wrote: > > +static int abx80x_wdog_set_timeout(struct watchdog_device *wdog, > > + unsigned int new_timeout) > > I'll leave multi-line alignment issues to the driver maintainer. > Indeed, I'd like those to be aligned on the

Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-10 Thread Guenter Roeck
On Mon, Sep 10, 2018 at 03:36:54PM -0600, Jeremy Gebben wrote: > The abx804 and abx805 chips have support for a simple watchdog > function that can trigger an external reset. > > Signed-off-by: Jeremy Gebben I am missing the "select WATCHDOG_CORE" that would normally go with watchdog drivers.

Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-10 Thread Guenter Roeck
On Mon, Sep 10, 2018 at 03:36:54PM -0600, Jeremy Gebben wrote: > The abx804 and abx805 chips have support for a simple watchdog > function that can trigger an external reset. > > Signed-off-by: Jeremy Gebben I am missing the "select WATCHDOG_CORE" that would normally go with watchdog drivers.

[PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-10 Thread Jeremy Gebben
The abx804 and abx805 chips have support for a simple watchdog function that can trigger an external reset. Signed-off-by: Jeremy Gebben --- drivers/rtc/rtc-abx80x.c | 132 +-- 1 file changed, 128 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-10 Thread Jeremy Gebben
The abx804 and abx805 chips have support for a simple watchdog function that can trigger an external reset. Signed-off-by: Jeremy Gebben --- drivers/rtc/rtc-abx80x.c | 132 +-- 1 file changed, 128 insertions(+), 4 deletions(-) diff --git