Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:53:02 +0200 Peter Zijlstra wrote: > On Mon, Jun 13, 2016 at 03:19:42PM +0200, Martin Schwidefsky wrote: > > On Mon, 13 Jun 2016 15:06:47 +0200 > > Peter Zijlstra wrote: > > > > > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:53:02 +0200 Peter Zijlstra wrote: > On Mon, Jun 13, 2016 at 03:19:42PM +0200, Martin Schwidefsky wrote: > > On Mon, 13 Jun 2016 15:06:47 +0200 > > Peter Zijlstra wrote: > > > > > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > > > > Yes, and actually we

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Mon, Jun 13, 2016 at 03:19:42PM +0200, Martin Schwidefsky wrote: > On Mon, 13 Jun 2016 15:06:47 +0200 > Peter Zijlstra wrote: > > > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > > > Yes, and actually we are all virt/LPAR always, so this is

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Mon, Jun 13, 2016 at 03:19:42PM +0200, Martin Schwidefsky wrote: > On Mon, 13 Jun 2016 15:06:47 +0200 > Peter Zijlstra wrote: > > > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > > > Yes, and actually we are all virt/LPAR always, so this is unfortunately > > > not > > >

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:06:47 +0200 Peter Zijlstra wrote: > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > > Yes, and actually we are all virt/LPAR always, so this is unfortunately not > > very easy to do. And yes, I do agree that for the 1:1 case it most

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:06:47 +0200 Peter Zijlstra wrote: > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > > Yes, and actually we are all virt/LPAR always, so this is unfortunately not > > very easy to do. And yes, I do agree that for the 1:1 case it most likely > > would make

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > Yes, and actually we are all virt/LPAR always, so this is unfortunately not > very easy to do. And yes, I do agree that for the 1:1 case it most likely > would make sense, however we don't have any run-time guarantee to stay 1:1.

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > Yes, and actually we are all virt/LPAR always, so this is unfortunately not > very easy to do. And yes, I do agree that for the 1:1 case it most likely > would make sense, however we don't have any run-time guarantee to stay 1:1.

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Heiko Carstens
On Mon, Jun 13, 2016 at 01:06:21PM +0200, Peter Zijlstra wrote: > On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > > The z13 machine added a fourth level to the cpu topology > > information. The new top level is called drawer. > > > > A drawer contains two books, which used to be

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Heiko Carstens
On Mon, Jun 13, 2016 at 01:06:21PM +0200, Peter Zijlstra wrote: > On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > > The z13 machine added a fourth level to the cpu topology > > information. The new top level is called drawer. > > > > A drawer contains two books, which used to be

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Mon, Jun 13, 2016 at 01:25:53PM +0200, Heiko Carstens wrote: > On Mon, Jun 13, 2016 at 01:06:21PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > > > The z13 machine added a fourth level to the cpu topology > > > information. The new top level

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Mon, Jun 13, 2016 at 01:25:53PM +0200, Heiko Carstens wrote: > On Mon, Jun 13, 2016 at 01:06:21PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > > > The z13 machine added a fourth level to the cpu topology > > > information. The new top level

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Heiko Carstens
On Mon, Jun 13, 2016 at 01:06:21PM +0200, Peter Zijlstra wrote: > On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > > The z13 machine added a fourth level to the cpu topology > > information. The new top level is called drawer. > > > > A drawer contains two books, which used to be

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Heiko Carstens
On Mon, Jun 13, 2016 at 01:06:21PM +0200, Peter Zijlstra wrote: > On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > > The z13 machine added a fourth level to the cpu topology > > information. The new top level is called drawer. > > > > A drawer contains two books, which used to be

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > The z13 machine added a fourth level to the cpu topology > information. The new top level is called drawer. > > A drawer contains two books, which used to be the top level. > > Adding this additional scheduling domain did show

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Peter Zijlstra
On Wed, Jun 08, 2016 at 11:09:16AM +0200, Heiko Carstens wrote: > The z13 machine added a fourth level to the cpu topology > information. The new top level is called drawer. > > A drawer contains two books, which used to be the top level. > > Adding this additional scheduling domain did show

[PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-08 Thread Heiko Carstens
The z13 machine added a fourth level to the cpu topology information. The new top level is called drawer. A drawer contains two books, which used to be the top level. Adding this additional scheduling domain did show performance improvements for some workloads of up to 8%, while there don't seem

[PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-08 Thread Heiko Carstens
The z13 machine added a fourth level to the cpu topology information. The new top level is called drawer. A drawer contains two books, which used to be the top level. Adding this additional scheduling domain did show performance improvements for some workloads of up to 8%, while there don't seem