Re: [PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-04 Thread Sven Schnelle
Hi, Thomas Gleixner writes: > Heiko Carstens writes: > >> On Mon, Aug 03, 2020 at 06:05:24PM +0200, Thomas Gleixner wrote: >>> +/** >>> + * vdso_update_begin - Start of a VDSO update section >>> + * >>> + * Allows architecture code to safely update the architecture specific VDSO >>> + * data.

Re: [PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-03 Thread Heiko Carstens
On Mon, Aug 03, 2020 at 09:27:36PM +0200, Thomas Gleixner wrote: > Heiko Carstens writes: > > > On Mon, Aug 03, 2020 at 06:05:24PM +0200, Thomas Gleixner wrote: > >> +/** > >> + * vdso_update_begin - Start of a VDSO update section > >> + * > >> + * Allows architecture code to safely update the

Re: [PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-03 Thread Thomas Gleixner
Heiko Carstens writes: > On Mon, Aug 03, 2020 at 06:05:24PM +0200, Thomas Gleixner wrote: >> +/** >> + * vdso_update_begin - Start of a VDSO update section >> + * >> + * Allows architecture code to safely update the architecture specific VDSO >> + * data. >> + */ >> +void vdso_update_begin(void)

Re: [PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-03 Thread Heiko Carstens
On Mon, Aug 03, 2020 at 06:05:24PM +0200, Thomas Gleixner wrote: > +/** > + * vdso_update_begin - Start of a VDSO update section > + * > + * Allows architecture code to safely update the architecture specific VDSO > + * data. > + */ > +void vdso_update_begin(void) > +{ > + struct vdso_data

Re: [PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-03 Thread Thomas Gleixner
Sven, Sven Schnelle writes: > Thomas Gleixner writes: >>> rc = chsc_sstpc(stp_page, STP_OP_SYNC, 0, >>> _delta); >>> if (rc == 0) { >>> @@ -609,6 +567,8 @@ static int stp_sync_clock(void *data) >>>

Re: [PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-03 Thread Sven Schnelle
Thomas Gleixner writes: > Sven Schnelle writes: > >> - CPUCLOCK_VIRT is now handled with a syscall fallback, which might >> be slower/less accurate than the old implementation. > > I can understand the slower, but why does it become less accurate? Because we saved the system/user times as

Re: [PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-03 Thread Thomas Gleixner
Sven Schnelle writes: > - CPUCLOCK_VIRT is now handled with a syscall fallback, which might > be slower/less accurate than the old implementation. I can understand the slower, but why does it become less accurate? > Performance number from my system do 100 mio gettimeofday() calls: > > Plain

[PATCH 2/2] s390: convert to GENERIC_VDSO

2020-08-02 Thread Sven Schnelle
This patch converts s390 to the generic vDSO. There are a few special things on s390: - vDSO can be called without a stack frame - glibc did this in the past. So we need to allocate a stackframe on our own. - The former assembly code used stcke to get the TOD clock and applied time steering