Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-20 Thread Heiko Carstens
On Tue, Jan 19, 2021 at 11:25:01AM +0100, Christian Borntraeger wrote: > > + if (user_mode(regs)) { > > + send_sig(SIGSEGV, current, 0); > > + return; > > + } else > > + panic("Unexpected PGM 0x3d with TEID bit 61=0"); > >

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-20 Thread Heiko Carstens
On Wed, Jan 20, 2021 at 03:39:14PM +0100, Christian Borntraeger wrote: > On 20.01.21 14:42, Heiko Carstens wrote: > > On Tue, Jan 19, 2021 at 11:25:01AM +0100, Christian Borntraeger wrote: > >>> + if (user_mode(regs)) { > >>> + send_sig(SIGSEGV, current, 0); > >>> +

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-20 Thread Christian Borntraeger
On 20.01.21 14:42, Heiko Carstens wrote: > On Tue, Jan 19, 2021 at 11:25:01AM +0100, Christian Borntraeger wrote: >>> + if (user_mode(regs)) { >>> + send_sig(SIGSEGV, current, 0); >>> + return; >>> + } else >>> +

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-19 Thread Cornelia Huck
On Tue, 19 Jan 2021 11:38:10 +0100 Janosch Frank wrote: > On 1/19/21 11:25 AM, Christian Borntraeger wrote: > > > > > > On 19.01.21 11:04, Janosch Frank wrote: > >> Turns out that the bit 61 in the TEID is not always 1 and if that's > >> the case the address space ID and the address are > >>

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-19 Thread Claudio Imbrenda
On Tue, 19 Jan 2021 05:04:02 -0500 Janosch Frank wrote: > Turns out that the bit 61 in the TEID is not always 1 and if that's > the case the address space ID and the address are > unpredictable. Without an address and it's address space ID we can't *its Reviewed-by: Claudio Imbrenda > export

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-19 Thread Janosch Frank
On 1/19/21 11:25 AM, Christian Borntraeger wrote: > > > On 19.01.21 11:04, Janosch Frank wrote: >> Turns out that the bit 61 in the TEID is not always 1 and if that's >> the case the address space ID and the address are >> unpredictable. Without an address and it's address space ID we can't >>

Re: [PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-19 Thread Christian Borntraeger
On 19.01.21 11:04, Janosch Frank wrote: > Turns out that the bit 61 in the TEID is not always 1 and if that's > the case the address space ID and the address are > unpredictable. Without an address and it's address space ID we can't > export memory and hence we can only send a SIGSEGV to the

[PATCH 2/2] s390: mm: Fix secure storage access exception handling

2021-01-19 Thread Janosch Frank
Turns out that the bit 61 in the TEID is not always 1 and if that's the case the address space ID and the address are unpredictable. Without an address and it's address space ID we can't export memory and hence we can only send a SIGSEGV to the process or panic the kernel depending on who caused