Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Tejun Heo
Robert Hancock wrote: > It looks like the problem is that even though we set the DMA mask after > we allocate the PRD and pad buffers, when the other port is set up, the > DMA mask is already over 64-bit and so it allocates its buffers over 4GB > and fails. I think we just need to explicitly set

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Tejun Heo
Robert Hancock wrote: > Tejun Heo wrote: >> Robert Hancock wrote: >>> This fixes some problems with ATAPI devices on nForce4 controllers in >>> ADMA mode >>> on systems with memory located above 4GB. We need to delay setting >>> the 64-bit >>> DMA mask until the PRD table and padding buffer are

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Tejun Heo
Robert Hancock wrote: Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Tejun Heo
Robert Hancock wrote: It looks like the problem is that even though we set the DMA mask after we allocate the PRD and pad buffers, when the other port is set up, the DMA mask is already over 64-bit and so it allocates its buffers over 4GB and fails. I think we just need to explicitly set to

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Tejun Heo
Robert Hancock wrote: > Tejun Heo wrote: >> Robert Hancock wrote: >>> This fixes some problems with ATAPI devices on nForce4 controllers in >>> ADMA mode >>> on systems with memory located above 4GB. We need to delay setting >>> the 64-bit >>> DMA mask until the PRD table and padding buffer are

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get allocated

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Tejun Heo
Robert Hancock wrote: > This fixes some problems with ATAPI devices on nForce4 controllers in ADMA > mode > on systems with memory located above 4GB. We need to delay setting the 64-bit > DMA mask until the PRD table and padding buffer are allocated so that they > don't > get allocated above 4GB

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Alan Cox
On Tue, 13 Nov 2007 22:15:51 -0600 Robert Hancock <[EMAIL PROTECTED]> wrote: > This fixes some problems with ATAPI devices on nForce4 controllers in ADMA > mode > on systems with memory located above 4GB. We need to delay setting the 64-bit > DMA mask until the PRD table and padding buffer are

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Alan Cox
On Tue, 13 Nov 2007 22:15:51 -0600 Robert Hancock [EMAIL PROTECTED] wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Tejun Heo
Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get allocated above 4GB and

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get allocated

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-14 Thread Tejun Heo
Robert Hancock wrote: Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that

[PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-13 Thread Robert Hancock
This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get allocated above 4GB and break legacy mode (which is

[PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-13 Thread Robert Hancock
This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are allocated so that they don't get allocated above 4GB and break legacy mode (which is