Re: [PATCH 2/2] scsi: libsas: delete sas port if expander discover failed

2019-05-14 Thread John Garry
On 14/05/2019 12:37, Jason Yan wrote: On 2019/5/14 18:45, John Garry wrote: On 14/05/2019 03:42, Jason Yan wrote: The sas_port(phy->port) allocated in sas_ex_discover_expander() will not be deleted when the expander failed to discover. This will cause resource leak and a further issue of

Re: [PATCH 2/2] scsi: libsas: delete sas port if expander discover failed

2019-05-14 Thread Jason Yan
On 2019/5/14 18:45, John Garry wrote: On 14/05/2019 03:42, Jason Yan wrote: The sas_port(phy->port) allocated in sas_ex_discover_expander() will not be deleted when the expander failed to discover. This will cause resource leak and a further issue of kernel BUG like below: [159785.843156] 

Re: [PATCH 2/2] scsi: libsas: delete sas port if expander discover failed

2019-05-14 Thread John Garry
On 14/05/2019 03:42, Jason Yan wrote: The sas_port(phy->port) allocated in sas_ex_discover_expander() will not be deleted when the expander failed to discover. This will cause resource leak and a further issue of kernel BUG like below: [159785.843156] port-2:17:29: trying to add phy

[PATCH 2/2] scsi: libsas: delete sas port if expander discover failed

2019-05-13 Thread Jason Yan
The sas_port(phy->port) allocated in sas_ex_discover_expander() will not be deleted when the expander failed to discover. This will cause resource leak and a further issue of kernel BUG like below: [159785.843156] port-2:17:29: trying to add phy phy-2:17:29 fails: it's already part of another